From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] checkasm: test with random bw value
Date: Thu, 9 Nov 2023 23:32:08 +0200 (EET)
Message-ID: <e8a6be3-266a-1e33-4d49-9e7e36f0ed7f@martin.st> (raw)
In-Reply-To: <20231109202653.18303-1-remi@remlab.net>
On Thu, 9 Nov 2023, Rémi Denis-Courmont wrote:
> With a value of zero, the function is a glorified memory copy.
> ---
> tests/checkasm/sbrdsp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/sbrdsp.c b/tests/checkasm/sbrdsp.c
> index 2fb14d5bf8..5cc3b33215 100644
> --- a/tests/checkasm/sbrdsp.c
> +++ b/tests/checkasm/sbrdsp.c
> @@ -190,8 +190,8 @@ static void test_hf_gen(void)
> for (i = 2; i < 64; i += 2) {
> memset(dst0, 0, 128 * 2 * sizeof(INTFLOAT));
> memset(dst1, 0, 128 * 2 * sizeof(INTFLOAT));
> - call_ref(dst0, low, alpha0, alpha1, 0.0, i, 128);
> - call_new(dst1, low, alpha0, alpha1, 0.0, i, 128);
> + call_ref(dst0, low, alpha0, alpha1, bw, i, 128);
> + call_new(dst1, low, alpha0, alpha1, bw, i, 128);
> if (!float_near_abs_eps_array((INTFLOAT *)dst0, (INTFLOAT *)dst1, EPS, 128 * 2))
> fail();
> bench_new(dst1, low, alpha0, alpha1, bw, i, 128);
> --
> 2.42.0
LGTM, also tested on i386, x86_64, armv7 and aarch64.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-11-09 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 20:26 Rémi Denis-Courmont
2023-11-09 21:32 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a6be3-266a-1e33-4d49-9e7e36f0ed7f@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git