From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8DFCB4323C for ; Sun, 23 Oct 2022 22:59:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D396368BC94; Mon, 24 Oct 2022 01:59:36 +0300 (EEST) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4ECD968BAA0 for ; Mon, 24 Oct 2022 01:59:30 +0300 (EEST) Received: by mail-ot1-f51.google.com with SMTP id r8-20020a056830120800b00661a0a236efso5050732otp.4 for ; Sun, 23 Oct 2022 15:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=XIUB6IE10IyQQhoOYqJh1DK51xouHAJEzA40R/4M9sY=; b=WbXRaDmGJqU0GNeYYkVyHBoyXK2j+qclb38cChp770QAZS3U0cRoX3CFulmPg2GlBu KNkyIgAo0kSgau2AGhiv4S+wrJBmbAL9YZ98HWtmRVeGem4SbV/l0hAMgt0KQNi/PAC/ NEPFYOiUr2jLB9LPewt3mLrU6BXKjWGOuK/WlfwRwCirKPziT5c8MPuMowxNBFuup/Gb 6RKnvgDtCqDDqHYE7Ee1H+GP5OPAhwUMfnk+kHD/ocg2CLvsW29UP/lIbqqw1ALj0eDr AMGi28ZeIU2q8Z/pTA4a6NWrqGOEHuMZ3cywgay0Nh3NOUm2hZKNG26bf2whAKr9eitH qzmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XIUB6IE10IyQQhoOYqJh1DK51xouHAJEzA40R/4M9sY=; b=jh+c9O6kGniTMKfCViJfc0wGQ5fboAgE7jY+cOnmCTZkp0agcwUJDNzCfuNmGkirl8 oNf0aLD4NfGpkaV5bIWhTarog0C9UzT0MbUUm+VzKxk1lyW6+Q0MsVaBe14OVzBpCrOw kiwP7pU0OXlzc0G9+DxJxGa1Lg2WUeG2lLWCv30w7C2LM4WQBl6wnFVr73EKyP7JFNpY 092HxJaNfALTqPHdCRcERFq+/nJNGbFA4FX1+G+OrVeZsQPXMzPGBAK+Z/VOlRv4HAtZ kzKaxkeKkL+JuD9lSWiCsKwHPwhtJIPku7gb7H2aNxy1RyHIs7O+GGHbP3S64Ipg6YIL J4zQ== X-Gm-Message-State: ACrzQf2XymKfBTWRGc8Yxdp/8wR4k+qB46hrXptJt1bkAX7KTYtViT+c 9enLAJzFdgrO7JTtMuvere8tnrkChcY= X-Google-Smtp-Source: AMsMyM75VzZZ61hr3hfUSoVW1+xKt+JZS5mXUHRMHeQLYR8EE4cSMfmf90YoWIUt1elPaCqtxurJAQ== X-Received: by 2002:a9d:6f05:0:b0:661:95eb:c170 with SMTP id n5-20020a9d6f05000000b0066195ebc170mr14773870otq.128.1666565967433; Sun, 23 Oct 2022 15:59:27 -0700 (PDT) Received: from [192.168.0.13] ([191.97.187.183]) by smtp.gmail.com with ESMTPSA id a30-20020a056870a19e00b0013b911d5960sm1401074oaf.49.2022.10.23.15.59.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Oct 2022 15:59:26 -0700 (PDT) Message-ID: Date: Sun, 23 Oct 2022 19:59:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: ffmpeg-devel@ffmpeg.org References: <20221022210226.2200-1-jamrial@gmail.com> <20221022210226.2200-2-jamrial@gmail.com> <20221023153517.GD4048598@pb2> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aac_ac3_parser: don't fill stream info in the sync function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/23/2022 2:34 PM, Andreas Rheinhardt wrote: > Michael Niedermayer: >> On Sat, Oct 22, 2022 at 06:02:23PM -0300, James Almer wrote: >>> Have it only find frame boundaries. The stream props will then be filled once >>> we have an assembled frame. >>> >>> Signed-off-by: James Almer >>> --- >>> libavcodec/aac_ac3_parser.c | 63 +++++++++++++++++++++++++++++-------- >>> libavcodec/aac_ac3_parser.h | 12 +------ >>> libavcodec/aac_parser.c | 7 +---- >>> libavcodec/ac3_parser.c | 16 +--------- >>> 4 files changed, 53 insertions(+), 45 deletions(-) >> >> i probably forgot something but this breaks: >> >> --- ./tests/ref/fate/adtstoasc_ticket3715 2022-10-22 10:37:36.046518037 +0200 >> +++ tests/data/fate/adtstoasc_ticket3715 2022-10-23 17:32:17.096459090 +0200 >> @@ -1,4 +1,4 @@ >> -29ef0632a8eb5c336bf45a1d5076626e *tests/data/fate/adtstoasc_ticket3715.mov >> +4110be924e21846d0e174fac679b062e *tests/data/fate/adtstoasc_ticket3715.mov >> 33324 tests/data/fate/adtstoasc_ticket3715.mov >> #extradata 0: 2, 0x00340022 >> #tb 0: 1/44100 >> Test adtstoasc_ticket3715 failed. Look at tests/data/fate/adtstoasc_ticket3715.err for details. >> tests/Makefile:306: recipe for target 'fate-adtstoasc_ticket3715' failed >> make: *** [fate-adtstoasc_ticket3715] Error 1 >> >> [...] >> > > You are not alone: Same thing happened with patchwork. Yes, i noticed and fixed it last night, but didn't send the patch for it since it was late. Will do it in a bit. > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".