From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aac_ac3_parser: don't fill stream info in the sync function
Date: Sun, 23 Oct 2022 19:59:32 -0300
Message-ID: <e891043c-d200-7b0c-3e2e-e67a981a1b9e@gmail.com> (raw)
In-Reply-To: <AS8P250MB07441325F4B6EACBFD51C7788F2F9@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On 10/23/2022 2:34 PM, Andreas Rheinhardt wrote:
> Michael Niedermayer:
>> On Sat, Oct 22, 2022 at 06:02:23PM -0300, James Almer wrote:
>>> Have it only find frame boundaries. The stream props will then be filled once
>>> we have an assembled frame.
>>>
>>> Signed-off-by: James Almer <jamrial@gmail.com>
>>> ---
>>> libavcodec/aac_ac3_parser.c | 63 +++++++++++++++++++++++++++++--------
>>> libavcodec/aac_ac3_parser.h | 12 +------
>>> libavcodec/aac_parser.c | 7 +----
>>> libavcodec/ac3_parser.c | 16 +---------
>>> 4 files changed, 53 insertions(+), 45 deletions(-)
>>
>> i probably forgot something but this breaks:
>>
>> --- ./tests/ref/fate/adtstoasc_ticket3715 2022-10-22 10:37:36.046518037 +0200
>> +++ tests/data/fate/adtstoasc_ticket3715 2022-10-23 17:32:17.096459090 +0200
>> @@ -1,4 +1,4 @@
>> -29ef0632a8eb5c336bf45a1d5076626e *tests/data/fate/adtstoasc_ticket3715.mov
>> +4110be924e21846d0e174fac679b062e *tests/data/fate/adtstoasc_ticket3715.mov
>> 33324 tests/data/fate/adtstoasc_ticket3715.mov
>> #extradata 0: 2, 0x00340022
>> #tb 0: 1/44100
>> Test adtstoasc_ticket3715 failed. Look at tests/data/fate/adtstoasc_ticket3715.err for details.
>> tests/Makefile:306: recipe for target 'fate-adtstoasc_ticket3715' failed
>> make: *** [fate-adtstoasc_ticket3715] Error 1
>>
>> [...]
>>
>
> You are not alone: Same thing happened with patchwork.
Yes, i noticed and fixed it last night, but didn't send the patch for it
since it was late. Will do it in a bit.
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-23 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 21:02 [FFmpeg-devel] [PATCH 1/5 v2] avcodec/ac3dec: split off code discarding garbage at the beginning of a packet James Almer
2022-10-22 21:02 ` [FFmpeg-devel] [PATCH 2/5] avcodec/aac_ac3_parser: don't fill stream info in the sync function James Almer
2022-10-23 15:35 ` Michael Niedermayer
2022-10-23 17:34 ` Andreas Rheinhardt
2022-10-23 22:59 ` James Almer [this message]
2022-10-22 21:02 ` [FFmpeg-devel] [PATCH 3/5] avcodec/aac_ac3_parser: don't try to sync when the parser is configured to handle complete frames James Almer
2022-10-24 21:49 ` Michael Niedermayer
2022-10-24 22:26 ` [FFmpeg-devel] [PATCH 4/6 v2] " James Almer
2022-10-22 21:02 ` [FFmpeg-devel] [PATCH 4/5] avcodec/aac_ac3_parser: reindent after previous commit James Almer
2022-10-22 21:02 ` [FFmpeg-devel] [PATCH 5/5 v2] avcodec/ac3_parser: improve false positive detection when parsing sync frames James Almer
2022-10-23 23:04 ` [FFmpeg-devel] [PATCH 2/6] avcodec/adts_parsed: allow passing a pre allocated AACADTSHeaderInfo to avpriv_adts_header_parse() James Almer
2022-10-26 12:09 ` [FFmpeg-devel] [PATCH 1/5 v2] avcodec/ac3dec: split off code discarding garbage at the beginning of a packet James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e891043c-d200-7b0c-3e2e-e67a981a1b9e@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git