From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id EDEAD4BC19
for <ffmpegdev@gitmailbox.com>; Sat, 29 Mar 2025 21:02:50 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCA47687C17;
Sat, 29 Mar 2025 23:02:46 +0200 (EET)
Received: from btbn.de (btbn.de [144.76.60.213])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3E104687AEC
for <ffmpeg-devel@ffmpeg.org>; Sat, 29 Mar 2025 23:02:41 +0200 (EET)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id
777EF2819FE5D
for <ffmpeg-devel@ffmpeg.org>; Sat, 29 Mar 2025 22:02:40 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
s=mail; t=1743282160;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=m+oGpDr4UIr16TrVm9p8ZdrqkMqcDQCCj2Cff/8nPZY=;
b=gm/AL/7ea+8Mr26un3JH/52xR+ElHbvCFCkBvmeurDT/Lh9gej8//0CfO8DPT3Ukw4i6Xt
tbHuuJn67qF/TnWd7YVJcvZcwtoeqWk6IJos53I2QgCFfr5oX56kpcMfDS5zq583Ojk+vQ
4zbMj4y/VnGPcKbZ4D2WfFZVzhMfNSQzIDJ+hWv8MQQ+x2zNLKIP1jTuuN0WSw93KW+kqI
5ujvim8tHXGerp6fDL7M4R6EtqtznW46LHp9GWLqKatk67Vg7R8brpDJgTwo0mK50hd0WL
xYdOvDg45IsoI9qFzOAQNgbRwRksWE50qE6MSlnu4vQrYJqelmWjcNS+m+wm9Q==
Message-ID: <e88ad017-8c74-47d3-a556-06108e7e9dd8@rothenpieler.org>
Date: Sat, 29 Mar 2025 22:02:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20250329205922.293412-1-aicommander@gmail.com>
Content-Language: en-US
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <20250329205922.293412-1-aicommander@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: add option to skip
padding OBUs
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/e88ad017-8c74-47d3-a556-06108e7e9dd8@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On 29.03.2025 21:58, Cameron Gutman wrote:
> Some scenarios (such as game streaming or videoconferencing) may use CBR
> to strictly cap the maximum encoded bitrate, but they don't mind the
> bitrate falling below the target if the encoder doesn't need the
> additional headroom.
But why aren't they using vbr with a maxrate then?
I didn't add this conditionally since when in CBR mode, you actually
really want a constant bitrate.
If you're okay with it dropping lower, why not use another mode with a
maxrate set?
> Allow users to opt-out of filler data in CBR mode for those usecases
> where it is unwanted.
>
> Signed-off-by: Cameron Gutman <aicommander@gmail.com>
> ---
> v2: Rebased to resolve conflicts against master
> ---
> libavcodec/nvenc.c | 2 +-
> libavcodec/nvenc.h | 1 +
> libavcodec/nvenc_av1.c | 2 ++
> 3 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
> index 0f5e772b3e..0f2336b0ec 100644
> --- a/libavcodec/nvenc.c
> +++ b/libavcodec/nvenc.c
> @@ -1624,7 +1624,7 @@ static av_cold int nvenc_setup_av1_config(AVCodecContext *avctx)
>
> av1->idrPeriod = cc->gopLength;
>
> - if (IS_CBR(cc->rcParams.rateControlMode)) {
> + if (ctx->filler_data && IS_CBR(cc->rcParams.rateControlMode)) {
> av1->enableBitstreamPadding = 1;
> }
>
> diff --git a/libavcodec/nvenc.h b/libavcodec/nvenc.h
> index e035e123c6..3431457422 100644
> --- a/libavcodec/nvenc.h
> +++ b/libavcodec/nvenc.h
> @@ -309,6 +309,7 @@ typedef struct NvencContext
> int unidir_b;
> int split_encode_mode;
> int mdm, cll;
> + int filler_data;
> } NvencContext;
>
> int ff_nvenc_encode_init(AVCodecContext *avctx);
> diff --git a/libavcodec/nvenc_av1.c b/libavcodec/nvenc_av1.c
> index 01626113ab..c00817af7b 100644
> --- a/libavcodec/nvenc_av1.c
> +++ b/libavcodec/nvenc_av1.c
> @@ -156,6 +156,8 @@ static const AVOption options[] = {
> OFFSET(extra_sei), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE },
> { "a53cc", "Use A53 Closed Captions (if available)", OFFSET(a53_cc), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE },
> { "s12m_tc", "Use timecode (if available)", OFFSET(s12m_tc), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE },
> + { "filler_data", "Use filler data to ensure CBR bitrate is strictly adhered to",
> + OFFSET(filler_data), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE },
> #ifdef NVENC_HAVE_H264_AND_AV1_TEMPORAL_FILTER
> { "tf_level", "Specifies the strength of the temporal filtering",
> OFFSET(tf_level), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, INT_MAX, VE, .unit = "tf_level" },
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".