From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C528E406C8 for ; Mon, 28 Feb 2022 06:39:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F335968B174; Mon, 28 Feb 2022 08:39:16 +0200 (EET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0202268B0C9 for ; Mon, 28 Feb 2022 08:39:09 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646030355; x=1677566355; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=k5mzCGIUqIFvUsSJk5/fTA06X2q30NTiuM8p1AvCxbk=; b=UT9CI9UeikdB70shkEBbIPS18DWfWXdBAYQOb5/d/YPd49t9092zZYgd giWll0v466Q5+Y68CbeWOsXw3T9hZn4jc+LZo1QvyxOvw19xL29z8fF4I qkkZOEvZo3+iwVFk5wSirHHyf1JcIGs5XIWKrj3YvcJVbMsSHqKCsKobo qGGOJFWlTSqPz8NnN3B2bUWdFpTh7toJS5/u7Sa2v1XBsNeb2IS3CCinh kmE0F13ML8qkmS+5PHkDlHf2FqkkDxDT2ofGc+TCDKGt7v5Na3JSiGvlj EwjzNSqh/vCaicyj4GTK0nUAK0sgBJ4zDzghCK+iKpseQ4z/L0BsclF3Y w==; X-IronPort-AV: E=McAfee;i="6200,9189,10271"; a="316032154" X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="316032154" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2022 22:39:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="708536694" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 27 Feb 2022 22:39:08 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 27 Feb 2022 22:39:07 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 27 Feb 2022 22:39:07 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Sun, 27 Feb 2022 22:39:07 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 27 Feb 2022 22:39:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTOHD6YaUr3ppbBaiQv8Ml7esc6yBsDx3yPWjEQ5asm21eN+EPeJCvCSMQFYTLuGplLu53pt9wFc3tlGJ+iX8guBYXIY+gVlWSMz6lrSpxILnJnmOgLb9E5y+aUqGbndtWsf1tkJMHp8t+D9d672NTp/V7oxHP/jDDbADXLTp7imSYr8EiXCiSFvjyQRJpo3TE4iAFqKum/K2DdbNIy/7v4mlOY4I4EN6ImIq+pKmmP8SkDqvTuUno78ChNG8zo2QFgzhz/FhgjDfuMPxqzq+kJBqJVZDPK4pkuNaTwUbUfYSSL5hx6LXX6kfKgv0bscBvfZHCwmp2HXA1r8ovYsgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k5mzCGIUqIFvUsSJk5/fTA06X2q30NTiuM8p1AvCxbk=; b=XZMyA4G6bWeaGjLB/H/Zo1lmql4m6IFPipgUkd+VSEHogSKreSdzS0t0sM2KII5+sxwwEbWxHxok2ZHYquhok8hWdNyFxOQ3vZffZ7IEL/E8jNP+Jx3gJkhWlV3LvMvENDlmiazgxejWaVAOeD+KfdRnYTf56ca9UxKck2KqN/F4VGm7uJxavlKXhnart7lf5ig9G+/xyWwA5pqHlWN9j9JfxGOD1PaVDDAFLLMEjEzxb5QIKPPe80hQWcJiN0YhzQ+Hog025hL558jg3sPN0wtrzrPq13rj2UrPwegKXyNXQ0bTHH3WFVv1wpbGpDH3PitSlot4Bua0EfRxJbBJ1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MWHPR11MB1311.namprd11.prod.outlook.com (2603:10b6:300:2a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Mon, 28 Feb 2022 06:39:01 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::9b4:2af2:de92:517f]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::9b4:2af2:de92:517f%5]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022 06:39:01 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] libavcodec/qsvenc: add mbbrc to hevc_qsv Thread-Index: AQHYJwEOq8wJ5/1QoE2SZIJOcvRLL6yojboA Date: Mon, 28 Feb 2022 06:39:00 +0000 Message-ID: References: <20220221085656.971981-1-wenbin.chen@intel.com> In-Reply-To: <20220221085656.971981-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 478e7518-d772-4a68-e2b8-08d9fa850163 x-ms-traffictypediagnostic: MWHPR11MB1311:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /CWGZpl6p1ulhaidi1zzm39RIG5PDIs/KOR2H8tc4pZGodmrIBN5uWa2ZzKi1L+JreIRGB7DR4XfCMoX8fyQUXj868lKvlZ+6V0VNnzovmjDE5h2X5MvjCwvRgcxSgDsum88bEdBPu6qtzfzLkn1xRpqB9pX2XQfIC9VyDEyeH8tVFIfBKP5kIzXUU/FegeqTpjEhMVl3EvmgwjMgN9wHWYYUf0cMezlXsg+ETZVPUtFMBZmHDtlACMHxjjAecf5hKyLv1qeKF2QjVpWd9dFNbcpo6JAn33nOkRhek8TjWuNC6mwtJXhtd582urUsN9poIMn+T3mQlik4xvHwTtVg+/+Tq0DN7SfD3CsOVZeQXVZKM49FQU03N+AmolUsUQivo2lgTVsWjA4nJ4KGPOZXasMBAWw5YshZtjv5jmZg1HpQF+hJfovuVM8XwQHfc3ahEc5buZ1gtnIGGI+6Sm1w1rJA2pP+R2O7sHWkYlMBARP+R+4kBvSHxHP+j0qHclxtieO6EtfWi6fZD9+GLDeBzy+f3+/RZpVxQIs+VJx1ozX6jkrNKbRdbw7iMc3RMSSoBAhJVcJ/rufGuqbRlKyjiUfAjHLZW/+hz7lNJ7ME4pEvzLFuNrdX4tVCWNIAQLCVBVVTa2vGVtLDK3RyrnJJdywLi8z9BUgGVUKqq4onIK22UXm+mdHLwHr5OpchIPRW5/MJpJJIgsrBwARjj4jr8RxQRo6gw7Zbt1GxduvvSD0kJuLOLvvXkTyDnueF0gl05wqSTXC49+GCvXe4+WtwaRwa5qut40P5Uwe2RkMWzqOWMsK31QJwej/kigCO/th x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(76116006)(91956017)(36756003)(83380400001)(66946007)(66556008)(66476007)(64756008)(8676002)(86362001)(66446008)(5660300002)(508600001)(2616005)(6486002)(71200400001)(38100700002)(8936002)(2906002)(26005)(38070700005)(82960400001)(966005)(186003)(6506007)(122000001)(6916009)(316002)(6512007)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZDRKRGdnNHVEV0NGVUtKcm1mcDJ0UTN3d0o2bDBwNXpNSTN5SWc5VzRENEhp?= =?utf-8?B?eFFKSVAveEtrQUIyYUhES2pKYUFJTnFKY2RvWTJibk5GWkFsa3M1RTdzTUt3?= =?utf-8?B?V0tTUWQrTnd0ald4UlIrYjJPVFdVWURiTU8yeEVSeGw2YWJOdHZDMDV0OXph?= =?utf-8?B?Y1pWd0hVaTJYSHpQdURwcVpBdzV2YkowM2xWVXVULzBRaVpCVGQ2RWlQMHQv?= =?utf-8?B?em1pdVFhZXFFdjN2cGJ4RmNpd3RxQ0ptZWVUYWtEY2pkajlYK3NTbkZXQkF6?= =?utf-8?B?SFF5UFQ5QWZtMFUrN1daYnhxSGNrRjArSnhMcGVYbVN5U2xJdGpXeldTLyts?= =?utf-8?B?aExXODRVSHp4ZUxLY0ZpNS9MVGRmV0tNaHd5QVRTQTl2VHBMVEUzNXo2c1lV?= =?utf-8?B?NGQxQ3pBTUhaam1mWEdRL3hNU1JhcU9UQ2dtU2hZaXlya01JMVhHMytIN3pU?= =?utf-8?B?aXZSUG9oeGNSMlBhUzZodHErcHo5Mkd0d2lmYW5ST2RZTmlhTGJTWFhNVHc5?= =?utf-8?B?R1VDOHRCTmJhOW1sSnBCaW1PU01XZHJhWGQ0LzNubzlpbVExbkd5ZGZCRzMx?= =?utf-8?B?bGNuYW1VRWVOU0VLUUhBSW1NeldsQWl0OEw1Ym95ZTR1ZlFOckFzMTRlL1hk?= =?utf-8?B?bzl3VkNPMzFYTE1uUyt2c281TzhINlVJckw2L1RwNS90TWw0clhzenMwNXRN?= =?utf-8?B?T3JodEFrd3VrOXJCakRzdDBCNGFiQjFjeFVZUktOalhPN01YMWRWWHpKVnda?= =?utf-8?B?NnB6b0pKVXc0dXRkTXU5d3BWZWF4Y3ZkMm5XcW5BSlhDNDF1YVg2bEc4RUVh?= =?utf-8?B?MFdoMmVySTJQQXRJUnYvRElwMUd0ZEkyb3FOQW5ndnkxck9zaTE5ajIzVWdw?= =?utf-8?B?N2l6MnhRTkptWXBZMHRNdVYydXp5RS90TnNuQlJIdyt5ZTd1bzZBdTN6bWpu?= =?utf-8?B?UnFRQUxFcktQTHlNTmlFd2VqUHZoSTdNY0VzRmdqbEtTd0MydUhraUQ5a2E4?= =?utf-8?B?Y0RRWFovRUU3NXd4VERkcUZ2VEhGY09SSDVsK2UxcXo5bGt5V1drTjJPbUU1?= =?utf-8?B?T2FHOW55b3ZtOUg5a080U0lXQ2cxaHZSUlY3N3dGaXI1OUhiL2pMUlROKzdB?= =?utf-8?B?MmQrRjloWEVVS0xOdDNXMTJvQXRYQUFOTW1PQk9jcW5XNVFkeGtEUHU1dGpx?= =?utf-8?B?b2lhWGtuSGhEdWJxQU8zNFJFWmhUM3RyYWlPZkFlVS95U2hMcTNjYVJLUU5r?= =?utf-8?B?UGRMTFVqQ0Y0MTdQWHQ1V2V0c28ydXNFV2NFd210OVkvVUlzTjdiT3ltbk9h?= =?utf-8?B?dHI3OUl4cEpkQXVHRnUyL1BLUnZ4cFVWekRQaUhMMGEvbDg0VStiNU9QZEY0?= =?utf-8?B?S01TSUpFVStkVDlFVHpWZ094K0RjREtWb0dSOG5rV1pwVk1iK29sUHM3aE5C?= =?utf-8?B?TTN1RElVUkl4S01PNWVCcjZIdkFuUXh6Tmg0citxR3AxdzY2Q0xpTjM4UTRD?= =?utf-8?B?UC9RRmxXWXJOdk5idWNXdEpKUDM2ZHp5aHFJV2VoOExHZkRFOWhrNi84ZjJB?= =?utf-8?B?SVN4cFlaeVdsMUJQWFYwdDVGcUNjL0REeXdhTGNTWm9LeXc4RnlHS0RHQ05E?= =?utf-8?B?UHZySTQvNGhDdjNUZzg0SUhxTG1KYndxOHlVaUJiL3V3RWdkdW1XTmUwME4w?= =?utf-8?B?QWg0VFl0cGZ0NWlFMWRJMDNSazVza2NwL1BXVW1ZRmkrR1ozNklFdmRXMTcw?= =?utf-8?B?Z1I3V2FZamNQSWpBWTB5SnJ1QkhpM2x0NDBXaFRKaXFJQk9xS0Rqd1hUNGJ4?= =?utf-8?B?Q3VUa2pyUkJFMjlCRml6dEg5WVdtVXd1TVNrZ1NHNlprb0Njc2Z4Q3J1K2U3?= =?utf-8?B?QTdZZk9mQnR6K00zcTkrcjVLQVA0Znp0clFRSlZldUQ5TmdxcDJicXJYQW5V?= =?utf-8?B?YWw4cDJqT0tsWUs4SGVsUnpEUnFDNDVEUkhpcWN0VEpuR3hzTmZqdmxHUGJO?= =?utf-8?B?RGdYYW5jYjVObTl1c3Y4cDlhY1M4T2VBRloxTy92WEF6bzMrRjJJN2lHMDFW?= =?utf-8?B?UTd3Q1Y1UFBrWE53TU9DSkdRTW1JRXdPeHVEbVYwRzRMQmo4L1p0dGJmYVJJ?= =?utf-8?B?aTh3ZHJoUWE0SXl4TXJyRzE3ZWJPNFpDK2xrU2lYY3BtS0xHZm1NV2x2RVJn?= =?utf-8?Q?LU2CNwzoo0sdveuw/w8tM5w=3D?= Content-ID: <092103EC7005B946A55E3696519DB5BA@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 478e7518-d772-4a68-e2b8-08d9fa850163 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 06:39:00.9616 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XcfpH0+UbRPifb3TieHJ1fCA9RWKh8ELgBT3yQLfPkgLC1aTYU5gTu2BshOZ9fYXDCEICjfTqA34Hm20WLySdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1311 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] libavcodec/qsvenc: add mbbrc to hevc_qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-02-21 at 16:56 +0800, Wenbin Chen wrote: > Add mbbrc to hevc_qsv > For detailed description, please see "mbbrc" part in: > https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md#mfxextcodingoption2 > > Signed-off-by: Wenbin Chen > --- > doc/encoders.texi | 5 +++++ > libavcodec/qsvenc.c | 5 +++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index bfb6c7eef6..4325fdd6b0 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -3404,6 +3404,11 @@ Maximum encoded frame size in bytes. > @item @var{max_slice_size} > Maximum encoded slice size in bytes. > > +@item @var{mbbrc} > +Setting this flag enables macroblock level bitrate control that generally > +improves subjective visual quality. Enabling this flag may have negative > impact > +on performance and objective visual quality metric. > + > @item @var{p_strategy} > Enable P-pyramid: 0-default 1-simple 2-pyramid(bf need to be set to 0). > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index 07be4287b7..3aed0508a4 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -877,8 +877,6 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > if (avctx->codec_id == AV_CODEC_ID_H264) { > if (q->bitrate_limit >= 0) > q->extco2.BitrateLimit = q->bitrate_limit ? > MFX_CODINGOPTION_ON : MFX_CODINGOPTION_OFF; > - if (q->mbbrc >= 0) > - q->extco2.MBBRC = q->mbbrc ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > > #if QSV_HAVE_TRELLIS > if (avctx->trellis >= 0) > @@ -935,6 +933,9 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco2.MaxQPP = q->extco2.MaxQPB = q->extco2.MaxQPI; > } > #endif > + if (q->mbbrc >= 0) > + q->extco2.MBBRC = q->mbbrc ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > + > q->extco2.Header.BufferId = MFX_EXTBUFF_CODING_OPTION2; > q->extco2.Header.BufferSz = sizeof(q->extco2); > LGTM, applied -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".