From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5D48E4F1EC for ; Sun, 15 Jun 2025 17:03:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id DA4D268DA27; Sun, 15 Jun 2025 19:59:06 +0300 (EEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 953A768DA21 for ; Sun, 15 Jun 2025 19:59:05 +0300 (EEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3135f3511bcso3654198a91.0 for ; Sun, 15 Jun 2025 09:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750006743; x=1750611543; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=0n18/JRQAlrMclY3gu1TwMnRRcZYCs4Qx/B2Hwtn1kQ=; b=nFrFrm5zFlNp6cR2IGudjMe+tVg8k9+YKHs8pWZ9HKZXBVBOi5w0BhQNY8vIDVYqlM i+pZkApCWruyG/fiQ34+If1PizvYj2Ycfk4O+5Zn0DnDOMN1XGVGHp60ySFa4R82SsG3 nkKINS6vNKpukIomMTvsJej+8dRAPv1PMlHPDHVImVT/cCkoVr0PwfgGjPpnucKAsrF2 uzf/vY5DaHMVgwlBjIFwfp3j1j6Kr6iWUyIB6Y84YYu98Z3QTVj0THmsYETSZJ3xeHDN DFCEPMWZX2YbdKUnAN5NAGwpUlF+Ziesj9HSpW1gM7ISNMVQTiM9qPhN5RIUUsTxvuQC rhYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750006743; x=1750611543; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0n18/JRQAlrMclY3gu1TwMnRRcZYCs4Qx/B2Hwtn1kQ=; b=XCwZphcrG1EUUbIotd7gliOZS4ii83vMjT7aran0em73l5Vip2lmDHLsyym7Te3oFS sAJ0h0q1W5SKIITd2QO3rhDHcy6ki2tijee3Bj46LL/xzeI6z+IyxrZQKBC5Z97ElF5N wg5bZUiKl4xeNSMhdBZiOLoRdwzO5uYw9ZYaECtcQgdColFMGenEVDu+Hg6iQ/nZA4aR fw0NOkxQ7j8wfd+hLM9xzDKB/ZA/XymgfNyOqUHiJfQX6qt9/1n+4kREmjAG1nqQxkc+ YTEtUZdA0eolwQuWJNks4uaYmeQ8x/crf9G8qvJMfqhvw5c1gUqFxLnjc++rLRVvUi2v Perg== X-Gm-Message-State: AOJu0YyaNh0050xG2vJK0btXFpGH4jZlhvPz2F4l/gE9XkaiqnyMrqT4 r4sV6o5NUop7SNqmAvpTdoDeHTrbwHGADUt7JUvdBhHzxzmRYVhLViBMpuA5gw== X-Gm-Gg: ASbGncuGkd+oKuaQpnMduSAWxMCRE040V+2xUrLiNBKct9nATDl+NpkNrGDAlOdwLSk yrfU6VJcw3SC2wm81PqbOAPNl9vNrZq5IEqSgbgHThw9Wukr+KG39Fw+hOidqrOCFRiZ35IETfU x+DgPezq2LRCuHljEyqkGdx+BqM2IpcDhaW58KV66qS12C3Wpsg9/IBz0YQaXcYpL44Z/yZ7uiL vxOehYv5zKEka1uFqL0i2D9SysZqQ8DXMCE9KAc8UhfNNU/zN3D9Iw8hr1gK5EYl15jV/LH4fuR qLzqhW4NyNwCk1VwZBfuIsTiQReL0za4C3ILWUfIfAYnTif8pzZKtyv5UCA8Q6HhjAAfxKIG7GF 4Q9YQFIS3gIyKNTW2 X-Google-Smtp-Source: AGHT+IH7aZsyzHiPvSMfioFCNQtAbEqg726Eg3Q2uDpj8muXo5aUv0g0E1JPNiKhJL9AARMXq1LaqA== X-Received: by 2002:a17:90b:380c:b0:311:baa0:89ce with SMTP id 98e67ed59e1d1-313f1c06bf5mr12282785a91.12.1750006742914; Sun, 15 Jun 2025 09:59:02 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365dea7d74sm45994605ad.152.2025.06.15.09.59.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Jun 2025 09:59:02 -0700 (PDT) From: Andreas Rheinhardt X-Google-Original-From: Andreas Rheinhardt Message-Id: In-Reply-To: References: Date: Sun, 15 Jun 2025 16:54:36 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 45/47] avcodec/ituh263enc: Simplify encoding umotion vectors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Andreas Rheinhardt There is no need to use two loops. Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c | 38 ++++++++++---------------------------- 1 file changed, 10 insertions(+), 28 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index d1d07bc5f8..903bb45fce 100644 --- a/libavcodec/ituh263enc.c +++ b/libavcodec/ituh263enc.c @@ -573,38 +573,20 @@ static void h263_encode_block(MPVEncContext *const s, int16_t block[], int n) /* Encode MV differences on H.263+ with Unrestricted MV mode */ static void h263p_encode_umotion(PutBitContext *pb, int val) { - short sval = 0; - short i = 0; - short n_bits = 0; - short temp_val; - int code = 0; - int tcode; - if ( val == 0) put_bits(pb, 1, 1); - else if (val == 1) - put_bits(pb, 3, 0); - else if (val == -1) - put_bits(pb, 3, 2); else { - - sval = ((val < 0) ? (short)(-val):(short)val); - temp_val = sval; - - while (temp_val != 0) { - temp_val = temp_val >> 1; - n_bits++; - } - - i = n_bits - 1; - while (i > 0) { - tcode = (sval & (1 << (i-1))) >> (i-1); - tcode = (tcode << 1) | 1; - code = (code << 2) | tcode; - i--; + unsigned code = (val < 0) << 1; + unsigned aval = val < 0 ? -val : val; + unsigned n_bits = 2; + + while (aval != 1) { // The leading digit is implicitly coded via length + unsigned tmp = (aval & 1) << 1 | 1; + aval >>= 1; + code |= tmp << n_bits; + n_bits += 2; } - code = ((code << 1) | (val < 0)) << 1; - put_bits(pb, (2*n_bits)+1, code); + put_bits(pb, n_bits + 1, code); } } -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".