From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: Avoid an unchecked bytesteram read
Date: Mon, 24 Jul 2023 23:28:20 -0300
Message-ID: <e7c1cd23-4e42-e475-d1c0-b7e8cdbba943@gmail.com> (raw)
In-Reply-To: <20230725004609.17750-3-michael@niedermayer.cc>
On 7/24/2023 9:46 PM, Michael Niedermayer wrote:
> The unchecked read caused the 2nd subsequent tell call to move backward resulting
> in a negative length
>
> Fixes: assertion failure
> Fixes: 60276/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5434126636023808
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/cbs_h2645.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c
> index 34c5d1d372..21c8bc76d5 100644
> --- a/libavcodec/cbs_h2645.c
> +++ b/libavcodec/cbs_h2645.c
> @@ -695,7 +695,7 @@ static int cbs_h2645_split_fragment(CodedBitstreamContext *ctx,
> int nal_unit_type = bytestream2_get_byte(&gbc) & 0x1f;
> unsigned int num_nalus = 1;
> if(nal_unit_type != VVC_DCI_NUT && nal_unit_type != VVC_OPI_NUT)
> - num_nalus = bytestream2_get_be16u(&gbc);
> + num_nalus = bytestream2_get_be16(&gbc);
>
> start = bytestream2_tell(&gbc);
> for(i = 0; i < num_nalus; i++) {
LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-25 2:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 0:46 [FFmpeg-devel] [PATCH 1/3] avformat/imf_cpl: Replace NULL content_title_utf8 by "" Michael Niedermayer
2023-07-25 0:46 ` [FFmpeg-devel] [PATCH 2/3] avcodec/cbs_h266_syntax_template: Check num_subpic_cols for 0 Michael Niedermayer
2023-07-25 1:54 ` James Almer
2023-07-25 21:03 ` Michael Niedermayer
2023-07-25 21:08 ` James Almer
2023-07-25 0:46 ` [FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: Avoid an unchecked bytesteram read Michael Niedermayer
2023-07-25 2:28 ` James Almer [this message]
2023-07-25 20:41 ` Michael Niedermayer
2023-07-25 4:35 ` [FFmpeg-devel] [PATCH 1/3] avformat/imf_cpl: Replace NULL content_title_utf8 by "" Pierre-Anthony Lemieux
2023-07-25 20:37 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7c1cd23-4e42-e475-d1c0-b7e8cdbba943@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git