From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F17E44B9D1 for ; Mon, 8 Jul 2024 16:08:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 523E468DC69; Mon, 8 Jul 2024 19:08:16 +0300 (EEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 76D8468D5F7 for ; Mon, 8 Jul 2024 19:08:10 +0300 (EEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-706524adf91so3311115b3a.2 for ; Mon, 08 Jul 2024 09:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720454888; x=1721059688; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=pZzPwjL5WzFNpcqk6Ihv4NT6s1HFU1qdB+zaVZJjHxc=; b=SfKQAvDXZvi6tdr1bTa//efjsAP7wW5VGS7nCwWsuwY7EPjivnBcNG9kebtvIKt6l2 LLQIEOaep7mq8orgnmd7cPaydV6bz+HxONEDjeQ1GSp0m9adV2MC5q/IUp8XJoM931n0 DTZCtOcFyiKUipZbqM12ipu+mnUSpLnPHGPImGHJ9oVjT1PO/MSb00faqoORjmxCzSUJ KFKqQt82FMxaHJBdnsa8OjRQZnkTUu3umWs8ufRotljh/8d0IjqJqSzM9f+4GvGtIm9D Wg65RpZU7v2/sF9/fRN4Wm3XW2RJP7QmhvOwuVBcVBuwk9iQ9SQ9+4mbIwZHxMg/FTnV BNQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720454888; x=1721059688; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pZzPwjL5WzFNpcqk6Ihv4NT6s1HFU1qdB+zaVZJjHxc=; b=O4XGTwtlqjeYU+2LzotlVP95/K3+7qj7y1FziYoWE513wktoeWBwAuyfZ7AYoq3i5S 8bgiPytCy3m3ytt5TtBou/UueKRgbxSuKlE9hdsK0ULBmDSA9yug6jn31cKjMaacgC+1 SCxZXMQvMrSI5tpL/KqMOtsT+ZWZuF3txvmb3n96yzCVlxk3xmPCSwMYiTqgg1+rtF5m JCyqeLp+0h+arFfYPy4ts80ZDZMERxMSGu3unX/mknHfTFSo6PRKTZoALbDnd7ySr3t6 vm4wrWX+nmrqXCskScbUtu45Haor+TrklJrFBrf+NDu38P/oFXx1Ycfy7NxaAHtXLucI hkEg== X-Gm-Message-State: AOJu0YyFqg5gLWT1XvKHdampMiDsiC97tUPiczxl3AE8hYPB4S1FpYLb lpGE/BhQ3g8GhAE/GEKKqYSQAQuuT1SWqEtTowAlABPn9quLo4qOOSx+5A== X-Google-Smtp-Source: AGHT+IEnOX8SjYblfB5xcB1j+tTjEj+CaHR6Yc9v9TTYNJlEhrsZ1TR8tIAsKdoCl5Y3nMPpi4f3Kw== X-Received: by 2002:a05:6a00:3d4a:b0:705:ac9e:1740 with SMTP id d2e1a72fcca58-70b435422d7mr198623b3a.10.1720454887596; Mon, 08 Jul 2024 09:08:07 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b439b82ebsm23360b3a.193.2024.07.08.09.08.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 09:08:07 -0700 (PDT) Message-ID: Date: Mon, 8 Jul 2024 13:08:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: Fix member access within null pointer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/8/2024 12:58 PM, Andreas Rheinhardt wrote: > This "works" because the public AVCodecHWConfig is at the beginning of > AVCodecHWConfigInternal. > > Fixes libavcodec/decode.c:1035:61: runtime error: member access within > null pointer of type 'const struct AVCodecHWConfigInternal'. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/decode.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 791940648d..cdb682cf69 100644 > --- a/libavcodec/decode.c > +++ b/libavcodec/decode.c > @@ -1023,6 +1023,7 @@ enum AVPixelFormat avcodec_default_get_format(struct AVCodecContext *avctx, > const enum AVPixelFormat *fmt) > { > const AVPixFmtDescriptor *desc; > + const FFCodec *const codec = ffcodec(avctx->codec); > const AVCodecHWConfig *config; > int i, n; > > @@ -1031,10 +1032,8 @@ enum AVPixelFormat avcodec_default_get_format(struct AVCodecContext *avctx, > if (avctx->hw_device_ctx && ffcodec(avctx->codec)->hw_configs) { > AVHWDeviceContext *device_ctx = > (AVHWDeviceContext*)avctx->hw_device_ctx->data; > - for (i = 0;; i++) { > - config = &ffcodec(avctx->codec)->hw_configs[i]->public; > - if (!config) > - break; > + for (size_t i = 0; codec->hw_configs[i]; i++) { nit: Change both i and n to size_t above instead of shadowing i here. Or just don't change the type at all. > + config = &codec->hw_configs[i]->public; > if (!(config->methods & > AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX)) > continue; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".