Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Scott Theisen <scott.the.elm@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/h264_refs.c: respect ref_frame_count when adding short term refs after a frame num gap
Date: Fri, 21 Feb 2025 00:40:04 -0500
Message-ID: <e7692e7f-6d41-440f-8f0f-8b2424dd5757@gmail.com> (raw)
In-Reply-To: <20241114045933.604098-1-scott.the.elm@gmail.com>

On 11/13/24 23:59, Scott Theisen wrote:
> From: Janne Grunau <jgrunau@mythtv.org>
>
> this silences the "number of reference frames exceeds max
> (probably corrupt input), discarding one" message
> in the uninteresting cases, i.e. after seeking, playback start
>
> originally from:
> https://github.com/MythTV/mythtv/commit/53257097eb6c1fd4259d20bc92f8820a023ec953
>
> referencing:
> https://code.mythtv.org/trac/ticket/6729
> https://code.mythtv.org/trac/ticket/8367
> ---
>   libavcodec/h264_refs.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c
> index 5eb2855065..63ad617268 100644
> --- a/libavcodec/h264_refs.c
> +++ b/libavcodec/h264_refs.c
> @@ -759,6 +759,12 @@ int ff_h264_execute_ref_pic_marking(H264Context *h)
>               h->short_ref[0] = h->cur_pic_ptr;
>               h->short_ref_count++;
>               h->cur_pic_ptr->reference |= h->picture_structure;
> +
> +            // do not add more reference frames than allowed after seeing frame num gap
> +            if (!mmco_count && h->short_ref_count > h->ps.sps->ref_frame_count) {
> +                pic = h->short_ref[h->short_ref_count - 1];
> +                remove_short(h, pic->frame_num, 0);
> +            }
>           }
>       }
>   

Ping?  Rebased onto master cleanly.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

           reply	other threads:[~2025-02-21  5:40 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20241114045933.604098-1-scott.the.elm@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7692e7f-6d41-440f-8f0f-8b2424dd5757@gmail.com \
    --to=scott.the.elm@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git