From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D2B7146006 for ; Sat, 29 Apr 2023 14:06:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1CFD968BFBF; Sat, 29 Apr 2023 17:06:40 +0300 (EEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 59BC268BF86 for ; Sat, 29 Apr 2023 17:06:34 +0300 (EEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-63b50a02bffso749833b3a.2 for ; Sat, 29 Apr 2023 07:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682777192; x=1685369192; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cFtpK97eLmnJTJLpNX2MvYTXiwBoD5zqvqCIrBL9lCA=; b=PEPFUZ13zmF26DQNhjXSmnkJQnCSZxomJ2Lv45LtlnrBTJ6Sx/1pUHvOyErs/LvVJz l7CIuW6kk/DR5jNPXIitb6oUhFm/mPMzQWIE3VPa1mX5TZyn1QTxHvwezfqT1fy3vQgU zKIEbb2S/KwUdHz/Oy0XSFq5K1vzooO2X7tQKVChHHgHknwLBv5K9WW8mq06xrDZnc/c k6zGiOrTMCOgwPonTsweh/v5D10Zn2+eZsCf+uK95snzW2+m4KxGIr1K8ltuLKPLIANN nz286YXLgWxylKIbKM01ntumSEyXPjDxYBFRrwqb4pLMWd59E3gybsJuhU4xa92+Gao7 qpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682777192; x=1685369192; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cFtpK97eLmnJTJLpNX2MvYTXiwBoD5zqvqCIrBL9lCA=; b=gPj+u6wxzJjpK4ijrk0Fhntffv7OIs8K8T22Gu8KMdns9KFHV05HJdd8Axs28qyN+Q 3vFFnsSIG1PKlN9bvkpwnGQCFxbX1jXa/zwJEajefeEWBktdX8dJXDzGpX3vc7JnmlOc dk9BmlZfmp/cExs0rKrKhimsWqDBegWImFnIXA2LT7t5+fdx1tIhOuV29utWg/+NMK78 aBF9F5mIyFvPf2Th7n7v0a0+h2DYDZ5fZ7EtAWAcXW+oMzU5sN1yL/T9FAqlov/Y3xLu o9iAGUPDseGqc3Eo7T1pB29wiB23FvhVLrVrFek3rWKYyAaV0XZTLL2PFIqELgSOCdn0 eSSA== X-Gm-Message-State: AC+VfDxKK/09fUj06HkoTqKJFRyKukhKK4YjCKkyLt+uCXlCUzaerg43 GU88K3JHzdaPxWGZpI1E/ZxnGX3nEhM= X-Google-Smtp-Source: ACHHUZ6UrdbSTBasCfCfHUCDA5u9f1D1bw29AOt2QFvOdHv3rjL6srtxRaCIi3VEt8Dr0kO9TjylDg== X-Received: by 2002:a05:6a00:10c9:b0:63a:ea04:634a with SMTP id d9-20020a056a0010c900b0063aea04634amr12637221pfu.21.1682777191928; Sat, 29 Apr 2023 07:06:31 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id l4-20020a056a00140400b00622e01989cbsm17538297pfu.176.2023.04.29.07.06.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Apr 2023 07:06:31 -0700 (PDT) Message-ID: Date: Sat, 29 Apr 2023 11:06:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230428095508.221826-1-george@nsup.org> <20230428095508.221826-5-george@nsup.org> <168276131126.3843.11789945625076765172@lain.khirnov.net> From: James Almer In-Reply-To: <168276131126.3843.11789945625076765172@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 5/8] lavu: add a JSON writer API (WIP) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/29/2023 6:41 AM, Anton Khirnov wrote: > Quoting Nicolas George (2023-04-29 11:11:59) >> Nicolas George (12023-04-28): >>> Signed-off-by: Nicolas George >>> --- >>> libavutil/Makefile | 1 + >>> libavutil/json.c | 368 +++++++++++++++++++++++++++++++++++ >>> libavutil/json.h | 470 +++++++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 839 insertions(+) >>> create mode 100644 libavutil/json.c >>> create mode 100644 libavutil/json.h >> >> I forgot to write: I wrote this code not only because we have half-baked >> JSON output in multiple places in the code > > As far as I can see, there are exactly two places in the codebase that > produce JSON: af_loudnorm and ffprobe. > > af_loudnorm: > * can optionally produce final filter stats as JSON output with av_log() > * the relevant code has ~25 lines and is unlikely to be simplified by > this > * IMO the filter should not be doing this at all and instead produce some > sort of a struct and let the users process it as they wish It should be exporting frame metadata, like aphasemeter, cropdetect, etc. av_log() output is not meant to be parseable. It's why the relevant output of vf_showinfo can be freely changed, whereas output from things like framecrc/framehash muxers is standardized. > > ffprobe: > * is not one of the libraries, but rather their caller > * we are not in business of providing random non-multimedia-related > services to callers, unless they are useful in our libraries; > if this code is only useful in ffprobe then it should live in fftools/ > * it is not at all obvious that switching ffprobe to this code would > be an improvement; a patch actually demonstrating this would be most > useful > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".