From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 5DBE94DD1A
	for <ffmpegdev@gitmailbox.com>; Thu, 24 Apr 2025 04:10:38 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5E1C368B6AC;
	Thu, 24 Apr 2025 07:10:33 +0300 (EEST)
Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E6EEA68B6AC
 for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Apr 2025 07:10:26 +0300 (EEST)
Received: from smtp202.mailbox.org (smtp202.mailbox.org
 [IPv6:2001:67c:2050:b231:465::202])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4ZjjDw2yl9z9sv3
 for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Apr 2025 06:10:24 +0200 (CEST)
Message-ID: <e73d5f84-f894-4066-b3b2-c8ef41c080c0@gyani.pro>
Date: Thu, 24 Apr 2025 09:40:20 +0530
MIME-Version: 1.0
To: ffmpeg-devel@ffmpeg.org
References: <20250423141720.4033649-1-cenzhanquan2@gmail.com>
 <35b7ea21-11fe-2b5a-485b-b6565c87861a@passwd.hu>
Content-Language: en-US
From: Gyan Doshi <ffmpeg@gyani.pro>
In-Reply-To: <35b7ea21-11fe-2b5a-485b-b6565c87861a@passwd.hu>
X-Rspamd-Queue-Id: 4ZjjDw2yl9z9sv3
Subject: Re: [FFmpeg-devel] [PATCH 1/1] libavfilter/volume: do fade when
 adjusting the volume.
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/e73d5f84-f894-4066-b3b2-c8ef41c080c0@gyani.pro/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>



On 2025-04-24 02:05 am, Marton Balint wrote:
>
>
> On Wed, 23 Apr 2025, cenzhanquan2@gmail.com wrote:
>
>> From: zhanquan cen <cenzhanquan2@gmail.com>
>>
>> 1. add simple fade when volume.
>> 2. do fade when adjust volume to maximal.
>>
>> when to adjust volume we hope that the audio sample is smooth
>> we need to calculate the gradient step between each sample based
>> on the total change of the gradient (i.e. dst_volume - src_volume)
>> and the number of samples (nb_samples) and apply it to the target 
>> sample.
>
> I don't understand this. Why would you want any fading when you want 
> to apply the audio gain uniformly over the whole duration of audio?
It is useful to transition into the new volume level.
However, this shouldn't be hardcoded. Add an option for the transition 
time with default value of 0.

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".