Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/1] libavfilter/volume: do fade when adjusting the volume.
Date: Thu, 24 Apr 2025 09:40:20 +0530
Message-ID: <e73d5f84-f894-4066-b3b2-c8ef41c080c0@gyani.pro> (raw)
In-Reply-To: <35b7ea21-11fe-2b5a-485b-b6565c87861a@passwd.hu>



On 2025-04-24 02:05 am, Marton Balint wrote:
>
>
> On Wed, 23 Apr 2025, cenzhanquan2@gmail.com wrote:
>
>> From: zhanquan cen <cenzhanquan2@gmail.com>
>>
>> 1. add simple fade when volume.
>> 2. do fade when adjust volume to maximal.
>>
>> when to adjust volume we hope that the audio sample is smooth
>> we need to calculate the gradient step between each sample based
>> on the total change of the gradient (i.e. dst_volume - src_volume)
>> and the number of samples (nb_samples) and apply it to the target 
>> sample.
>
> I don't understand this. Why would you want any fading when you want 
> to apply the audio gain uniformly over the whole duration of audio?
It is useful to transition into the new volume level.
However, this shouldn't be hardcoded. Add an option for the transition 
time with default value of 0.

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-04-24  4:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 14:17 cenzhanquan2
2025-04-23 20:35 ` Marton Balint
2025-04-24  4:10   ` Gyan Doshi [this message]
2025-04-25 19:23     ` Marton Balint
2025-04-26  4:52       ` Gyan Doshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e73d5f84-f894-4066-b3b2-c8ef41c080c0@gyani.pro \
    --to=ffmpeg@gyani.pro \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git