From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 12A0241238 for ; Tue, 19 Apr 2022 11:19:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4BB1068B353; Tue, 19 Apr 2022 14:19:29 +0300 (EEST) Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 374B768B21B for ; Tue, 19 Apr 2022 14:19:23 +0300 (EEST) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-e604f712ecso3804738fac.9 for ; Tue, 19 Apr 2022 04:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=xqHaiE3Vq5Vrge8ci2g9lSa2ShhBJ1RP6RYTiINCrT8=; b=TtS/xMyYPBNcRoxivZhjseBGEqJfETStlyt+mqvhwge1Nw83VM+eaWP3NWIf3ZaGDu QmXs0ufhYfdSZXRfWBzjAmy3zhFpb6m96PcSqmbAb6NBVLoHJhpq/CVuoOUHUBMvlMgB ZDHcbPF28CqdeeS8Q9iT/9DK4hC+gUcPFpHCIWtUgJP+EvHEHRqgdbaHC93kRTcSdgVM Ql6BphDNoBnJw5rPGS6P3+OmHSZXviZsPGMG+deC/0hKLNzx7ZOhDEkNtGgxd1Awba+y QwLMokGpxkMAJptZJ5miONLXRlBONrDQCfwBdUIqqSjTSmtUhprQcjfW0crfYgno4+16 rTxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=xqHaiE3Vq5Vrge8ci2g9lSa2ShhBJ1RP6RYTiINCrT8=; b=nUHD0YiAU0izWSRIAmzwY7GjjktJeVql2L6FRi6TF6THmeianD5IKMdcqKUHFPA20g oo657ZPB2rEZRkzrI+fpDRNqBzcq5rLrPfDa1QO3PPNcqedcVJM/9D3t9NqWcz3YThsj yratC5h2zNirBwEawsh4PE2HYyweuqsNenL07TMtvlv9dv+7uDTyFiot0ZhHPmID8hdv GD5cCpWHGEFkadlv1q0XDblhILHWdtjZ2U6w3BVz/pD/wbKFKE2BYXruUariMLEjNooU QMvXbua5gZJvE0uVq79FaMRx08jELhd3WTRhqr8biE0LPooCnrpUW99n+V/TBsp/4iXe D7HQ== X-Gm-Message-State: AOAM533RgXxzA1Vit6FgxiHxbYg6ehLQcbTqb3wU0Tpjq/rORsjkktMS B6GdmTY/w5XUZFC7eoXZJrh9co26HUs= X-Google-Smtp-Source: ABdhPJzxMLt1fOUOritqj45f7rMrmh+D31E9wMv+teo3Wfx21XEWHe19dOdn5ZVPJFxPl4BHUum15Q== X-Received: by 2002:a05:6870:414e:b0:e5:8f84:96ed with SMTP id r14-20020a056870414e00b000e58f8496edmr8285387oad.299.1650367160087; Tue, 19 Apr 2022 04:19:20 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id r23-20020a056830237700b005b2610517c8sm5257603oth.56.2022.04.19.04.19.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 04:19:19 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 08:19:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220413161515.6999-1-jamrial@gmail.com> <20220413161515.6999-2-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/2] avdevice/dshow: silence warnings about unused variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/19/2022 3:05 AM, Roger Pack wrote: > On Wed, Apr 13, 2022 at 10:15 AM James Almer wrote: >> >> Use av_unused instead of wrapping the declaration under the DSHOWDEBUG check >> in case future changes make use of it. >> >> Signed-off-by: James Almer >> --- >> libavdevice/dshow.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c >> index ac8b64366f..6277a27453 100644 >> --- a/libavdevice/dshow.c >> +++ b/libavdevice/dshow.c >> @@ -976,7 +976,7 @@ dshow_cycle_formats(AVFormatContext *avctx, enum dshowDeviceType devtype, >> } >> } else { >> WAVEFORMATEX *fx; >> - AUDIO_STREAM_CONFIG_CAPS *acaps = caps; >> + AUDIO_STREAM_CONFIG_CAPS av_unused *acaps = caps; >> #if DSHOWDEBUG >> ff_print_AUDIO_STREAM_CONFIG_CAPS(acaps); >> #endif > > Or maybe put it within the #if ? Just an idea. I mentioned as much in the commit message, but figured it would be nicer to not do it in case it's needed later. But ok, will go that route instead. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".