From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make InputFilterPriv and OutputFilterPriv private again Date: Sun, 1 Jun 2025 23:40:40 -0300 Message-ID: <e7178846-7ae4-4d9b-95ef-322160269bc7@gmail.com> (raw) In-Reply-To: <DM8P223MB036574717916509A2C5C0ABABA62A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> [-- Attachment #1.1.1: Type: text/plain, Size: 1666 bytes --] On 6/1/2025 11:07 PM, softworkz . wrote: > > >> -----Original Message----- >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of softworkz . >> Sent: Samstag, 31. Mai 2025 03:44 >> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make >> InputFilterPriv and OutputFilterPriv private again > > [..] > >> 7 lines further down, there's another change needed: >> >> >> if (ofilter->output_name && ofilter->filter) >> av_dict_set(&output_map, ofilter->filter->name, ofilter- >>> output_name, 0); >> >> >> This is what broke the graph connections on the output side. >> >> Thanks >> sw >> >> _______________________________________________ > > > Hello James, > > I have seen you already pushed this. > > What I would like to note is that you could have just asked me > and I would have done it myself. This goes without saying. I pushed the set because i authored it. No point asking someone else to do it. I did however forget to send a reply acknowledging your review and LGTM before pushing it. > > I'm still saying it because I've already seen a satement > of something like "had to clean up your mess" or similar. > Though, nobody "has to". Just tell me and I'll do it, unless > you're having fun doing it. > > Not telling me and later saying "I had to..." - that's not > valid. (just hypothetically, I'm not saying you did) > > Please talk to me next time, I don't bite. > > PS: you might be upset at the moment, but I've been 10 > times more for sure I'm not. [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-02 2:40 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-05-29 3:06 [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: make FilterGraphPriv " James Almer 2025-05-29 3:06 ` [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: make InputFilterPriv and OutputFilterPriv " James Almer 2025-05-31 0:49 ` softworkz . 2025-05-31 1:44 ` softworkz . 2025-06-02 2:07 ` softworkz . 2025-06-02 2:40 ` James Almer [this message] 2025-06-02 2:46 ` softworkz . 2025-06-02 2:57 ` softworkz . 2025-05-29 3:16 ` [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: make FilterGraphPriv " softworkz . 2025-05-31 1:42 ` softworkz .
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e7178846-7ae4-4d9b-95ef-322160269bc7@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git