From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4500345888 for ; Fri, 24 Feb 2023 13:53:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2BBE968C14A; Fri, 24 Feb 2023 15:53:20 +0200 (EET) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 528A168BF35 for ; Fri, 24 Feb 2023 15:53:13 +0200 (EET) Received: by mail-wr1-f48.google.com with SMTP id bt28so7328755wrb.8 for ; Fri, 24 Feb 2023 05:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=gDukEecRQE/IS+WpsXxKCCXDXURTSb2weR7Z0E8vPYU=; b=FkTkMJTO5C3lamF+GRVTpDGe7fVLiBcFWdPYB2HtxhMjB/Chhr8xC/JXi2ZGaLrB7v +2LsH27wVOpeDs9H2o81XCBzdFWRW6dtAQcEAh5zlwsDNoJ6vMCEn8met3vCE/pwbSPA CfrwyaQQUPSC4m2gTKOVedlzoUPwCo+PZskGdNX/ojmIE3ZJlY5thXNrVraf98omLxzV XfT8lZyDVLhBj9TZLpvIub16f2doP5jIjJs+s+0DM9jJBDEHIHhmRPA8M5hMF9zt6fiX ZbLmIj1rnj51fJP7fKNJLrGj7f4RXTOuDqo1d8voSd7bNdEeiHRVnIwn00lfkBqYL0tJ 8wVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gDukEecRQE/IS+WpsXxKCCXDXURTSb2weR7Z0E8vPYU=; b=FaUH6j1BQnBtf/UZYt13Qh/jRTURw3saVOr7CRFMmWhUGqgltpB7yblSytGj65LihU +LQHL1UFC//IKWKoTlJsLHHg1wQ+qK1je2uDypn6vpPjdY/ibrtA9Hz+GRh2gtm0kCyX Waez3IARcUULTH7NlPQGpRlT1WotZQVAUZz9H+9Hbbm/D1zeoQPSq0pMu7wTQoJaHZm5 UG6NvoJaQZQNulyadwl3hE+NergVMVNGhteWMlAYBcWBAW2qLAz1tgFr3O8rOvUhUt63 YVeeZyckR9d4d0M15nuifLZO2CId8pML+Mec+QVuwgocOfg6ytj9DbT+o7Bs42s8Be7Q MusQ== X-Gm-Message-State: AO0yUKV81J6EvaPt4XXCZsqvaqpK2AoDyQrBT1kbNNszRgTKMr6lTFpv PJQLUv4agdJNTKAsAQZsU2QoMUjYj0A= X-Google-Smtp-Source: AK7set9HlytyE98p9sS7C0tSGuwHAQ9J78JQ553uWX36wY3cOn8+p+Mx5l23n/cHi4LwFnLjgclSEA== X-Received: by 2002:a05:6000:18a5:b0:2c5:5335:73f3 with SMTP id b5-20020a05600018a500b002c5533573f3mr11792649wri.34.1677246792680; Fri, 24 Feb 2023 05:53:12 -0800 (PST) Received: from [192.168.5.22] (d51A44418.access.telenet.be. [81.164.68.24]) by smtp.gmail.com with ESMTPSA id 18-20020a05600c231200b003e21f20b646sm2908049wmo.21.2023.02.24.05.53.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 05:53:11 -0800 (PST) From: James Darnley X-Google-Original-From: James Darnley Message-ID: Date: Fri, 24 Feb 2023 14:51:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: In-Reply-To: Subject: Re: [FFmpeg-devel] libavfilter/x86/vf_convolution.asm- fix missing decelerator for AVX512ICL sobel X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/24/23 04:00, Felix LeClair wrote: > Fixes: Compilation of Sobel with AVX512ICL > Caused: Comment left without deleniator in AVX512ICL version of SOBEL > > Testing:Confirmed working on AVX512 Alderlake (AKA SPR without AMX) > diff --git a/libavfilter/x86/vf_convolution.asm b/libavfilter/x86/vf_convolution.asm > index 9ac9ef5d73..8b85897819 100644 > --- a/libavfilter/x86/vf_convolution.asm > +++ b/libavfilter/x86/vf_convolution.asm > @@ -232,8 +232,8 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, > psubd m4, m5 > vpermb m3, m6, m3 > mova m5, m4 > - vpdpbusd m4, m2, [sobel_mulA] {1to16} > - vpdpbusd m5, m3, [sobel_mulB] {1to16} > + vpdpbusd m4, m2, [sobel_mulA]; {1to16} > + vpdpbusd m5, m3, [sobel_mulB]; {1to16} > > cvtdq2ps m4, m4 > mulps m4, m4 Fix compilation with what? I'm not familiar with the sobel algorith/function so I can't say whether the code is correct. However those constants are only dword sized and that is how you do a memory broadcast with avx512(icl). Furthermore testing your change on an icl system results in a failure in checkasm. So what program and what version fails to assemble that? [re-sending to list] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D7CD945884 for ; Fri, 24 Feb 2023 13:53:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1607968C159; Fri, 24 Feb 2023 15:53:28 +0200 (EET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F9A568C151 for ; Fri, 24 Feb 2023 15:53:21 +0200 (EET) Received: by mail-wm1-f46.google.com with SMTP id p16so9232518wmq.5 for ; Fri, 24 Feb 2023 05:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obe-tv.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gDukEecRQE/IS+WpsXxKCCXDXURTSb2weR7Z0E8vPYU=; b=sRFoXmrLiNbZhYIUs25iGkZLNLpTevA4Nw+3Qy0j7WPBC7v16OPlm3QBTh4FWQsn9X 6pI/uZawkPr55br9z+mW3j3f8mWz4BIU7VIA3wr8Aaidw5zBCFPHJjrMT7aPLWf6Tc6K V1W9kRUkE7kMgsrhrxju968Pxwfgapk2qRYYTDb9WMIZRXp3yNmznAjVCSVpA+U82YDO N61ebHvm7EmP5PihLfVFgvH0qIgWV3+O/C6q73BYxDwr5llzqbogeNEiAuziAC5kAk9y 6wmf1kyweMhvSbgzvEfLBs7T+WMZ7IRjbAFPNXO4qeflTlnXZO8hPlMVH/5ZFKKLGvod FFBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gDukEecRQE/IS+WpsXxKCCXDXURTSb2weR7Z0E8vPYU=; b=QFg3X+wQRtRlwrooaNvjWaz7qc1lcPdgOcV4idF8ulWQjWuHXy9InLplUCLIO0moBa F+DqJ5ZXb9uICYierFmu/sPk/KkSCKwEbHxPlTA0B8vHFEd3dZrHXIiOiM2yha7J5IDu nVpy5gXTLWt+8j5IHm4kxdGojyvySYZawNiY8q6Cv9XXaG5dc8LaeZyQM+AFMn2rulxy pNPBZJ7mu6csSSTxTYhHmJQkD8D3y2ZmbrQPAaBW6Ck2IV/VSTCLkAE1/bTIRVQ2Oy9b qzxstdT7NIaNjn6zSBDOmdI2MxKEXKTE5vhbcuWQK6LJtb33Nfn3NTzJ5IYpr/TFbRp4 ONzg== X-Gm-Message-State: AO0yUKXKRb8ba+fHX3UGyWU5BGc86gxPEgU0bskM00CCk5OJk/EKzh5P sTr4Mi4cOQzguBrfLFMpxJCgw/McKOYf4i1JI7ZxPA== X-Google-Smtp-Source: AK7set9UE1SCmKhedRwqT9PT9pgZ0d2+HQaA4qdfI2diEJKerM/x2Isa2E39ddXNyrNnJweB+mEEog== X-Received: by 2002:a05:600c:4e11:b0:3df:9858:c03a with SMTP id b17-20020a05600c4e1100b003df9858c03amr13212167wmq.15.1677246800261; Fri, 24 Feb 2023 05:53:20 -0800 (PST) Received: from [192.168.5.22] (d51A44418.access.telenet.be. [81.164.68.24]) by smtp.gmail.com with ESMTPSA id t25-20020a7bc3d9000000b003e896d953a8sm2927536wmj.17.2023.02.24.05.53.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 05:53:19 -0800 (PST) Message-ID: Date: Fri, 24 Feb 2023 14:51:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Darnley In-Reply-To: Subject: Re: [FFmpeg-devel] libavfilter/x86/vf_convolution.asm- fix missing decelerator for AVX512ICL sobel X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Message-ID: <20230224135108.ysPuyG05S5jVt78R1iVL7u-RTHp2siXtgeghE6Rh7k8@z> Archived-At: List-Archive: List-Post: On 2/24/23 04:00, Felix LeClair wrote: > Fixes: Compilation of Sobel with AVX512ICL > Caused: Comment left without deleniator in AVX512ICL version of SOBEL > > Testing:Confirmed working on AVX512 Alderlake (AKA SPR without AMX) > diff --git a/libavfilter/x86/vf_convolution.asm b/libavfilter/x86/vf_convolution.asm > index 9ac9ef5d73..8b85897819 100644 > --- a/libavfilter/x86/vf_convolution.asm > +++ b/libavfilter/x86/vf_convolution.asm > @@ -232,8 +232,8 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, > psubd m4, m5 > vpermb m3, m6, m3 > mova m5, m4 > - vpdpbusd m4, m2, [sobel_mulA] {1to16} > - vpdpbusd m5, m3, [sobel_mulB] {1to16} > + vpdpbusd m4, m2, [sobel_mulA]; {1to16} > + vpdpbusd m5, m3, [sobel_mulB]; {1to16} > > cvtdq2ps m4, m4 > mulps m4, m4 Fix compilation with what? I'm not familiar with the sobel algorith/function so I can't say whether the code is correct. However those constants are only dword sized and that is how you do a memory broadcast with avx512(icl). Furthermore testing your change on an icl system results in a failure in checkasm. So what program and what version fails to assemble that? [re-sending to list] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".