From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC4114975C for ; Mon, 19 Feb 2024 00:08:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A7A8568D3B2; Mon, 19 Feb 2024 02:08:42 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 54EDE68D3AB for ; Mon, 19 Feb 2024 02:08:36 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 0D6CBE9FD5 for ; Mon, 19 Feb 2024 01:08:36 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zPZBl6e-Olla for ; Mon, 19 Feb 2024 01:08:31 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 0061CE9F8F for ; Mon, 19 Feb 2024 01:08:30 +0100 (CET) Date: Mon, 19 Feb 2024 01:08:30 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20240218192054.665995-1-chen.stonechen@gmail.com> Message-ID: References: <20240218192054.665995-1-chen.stonechen@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 18 Feb 2024, Stone Chen wrote: > In commit 6c45d34, a line was added that always sets rdiv to 0, overriding any user input. This removes that line allowing user set values for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294. This is likely not the correct fix, because resetting it to 0 was added to support dynamic reconfigurations. The way I see it, the user option rdiv-s and internally used rdivs should be separated, init_params should always recalculate the internal rdivs based on the user option rdivs... Regards, Marton > > Signed-off-by: Stone Chen > --- > libavfilter/vf_convolution.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c > index bf67f392f6..a00bb2b3c4 100644 > --- a/libavfilter/vf_convolution.c > +++ b/libavfilter/vf_convolution.c > @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) > p = orig = av_strdup(s->matrix_str[i]); > if (p) { > s->matrix_length[i] = 0; > - s->rdiv[i] = 0.f; > sum = 0.f; > > while (s->matrix_length[i] < 49) { > -- > 2.43.2 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".