[FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check

[FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check

[Gyan Doshi]

Fixes CID 1524608.
---
 libavformat/tcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index a889633457..db41394a84 100644
--- a/libavformat/tcp.c
+++ b/libavformat/tcp.c
@@ -169,7 +169,7 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
         if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) {
             av_freep(&s->local_port);
             s->local_port = av_strdup(buf);
-            if (!s->local_addr)
+            if (!s->local_port)
                 return AVERROR(ENOMEM);
         }
         if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) {
-- 
2.39.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check

[Gyan Doshi]

Plan to push in 24h.

On 2023-03-30 11:22 pm, Gyan Doshi wrote:
> Fixes CID 1524608.
> ---
>   libavformat/tcp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/tcp.c b/libavformat/tcp.c
> index a889633457..db41394a84 100644
> --- a/libavformat/tcp.c
> +++ b/libavformat/tcp.c
> @@ -169,7 +169,7 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
>           if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) {
>               av_freep(&s->local_port);
>               s->local_port = av_strdup(buf);
> -            if (!s->local_addr)
> +            if (!s->local_port)
>                   return AVERROR(ENOMEM);
>           }
>           if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) {

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check

[Gyan Doshi]

On 2023-04-01 09:42 am, Gyan Doshi wrote:
> Plan to push in 24h.
Pushed as dd7e30724b739af9642917b1d04ba56d12e5e13f


>
> On 2023-03-30 11:22 pm, Gyan Doshi wrote:
>> Fixes CID 1524608.
>> ---
>>   libavformat/tcp.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/tcp.c b/libavformat/tcp.c
>> index a889633457..db41394a84 100644
>> --- a/libavformat/tcp.c
>> +++ b/libavformat/tcp.c
>> @@ -169,7 +169,7 @@ static int tcp_open(URLContext *h, const char 
>> *uri, int flags)
>>           if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) {
>>               av_freep(&s->local_port);
>>               s->local_port = av_strdup(buf);
>> -            if (!s->local_addr)
>> +            if (!s->local_port)
>>                   return AVERROR(ENOMEM);
>>           }
>>           if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) {
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".