From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/tcp: correct strdup check
Date: Sun, 2 Apr 2023 10:20:09 +0530
Message-ID: <e698dd5f-bdcf-0ce3-0ee4-8df45af2931e@gyani.pro> (raw)
In-Reply-To: <d9fe3204-139c-0577-78d6-f50ca10d980b@gyani.pro>
On 2023-04-01 09:42 am, Gyan Doshi wrote:
> Plan to push in 24h.
Pushed as dd7e30724b739af9642917b1d04ba56d12e5e13f
>
> On 2023-03-30 11:22 pm, Gyan Doshi wrote:
>> Fixes CID 1524608.
>> ---
>> libavformat/tcp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/tcp.c b/libavformat/tcp.c
>> index a889633457..db41394a84 100644
>> --- a/libavformat/tcp.c
>> +++ b/libavformat/tcp.c
>> @@ -169,7 +169,7 @@ static int tcp_open(URLContext *h, const char
>> *uri, int flags)
>> if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) {
>> av_freep(&s->local_port);
>> s->local_port = av_strdup(buf);
>> - if (!s->local_addr)
>> + if (!s->local_port)
>> return AVERROR(ENOMEM);
>> }
>> if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) {
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-04-02 4:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 17:52 Gyan Doshi
2023-04-01 4:12 ` Gyan Doshi
2023-04-02 4:50 ` Gyan Doshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e698dd5f-bdcf-0ce3-0ee4-8df45af2931e@gyani.pro \
--to=ffmpeg@gyani.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git