[FFmpeg-devel] [PATCH] avcodec/libsvtav1: unbreak build with latest svtav1

[FFmpeg-devel] [PATCH] avcodec/libsvtav1: unbreak build with latest svtav1

[Gyan Doshi]

SVT-AV1 made a change in their public API in 988e930c but without a
version bump or any other accessible marker, thus breaking ffmpeg build
with current versions of SVT-AV1.

They have finally bumped versions a month later, so check added.
---
 libavcodec/libsvtav1.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index 79b28eb4df..43fe531fde 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@ -435,7 +435,11 @@ static av_cold int eb_enc_init(AVCodecContext *avctx)
 
     svt_enc->eos_flag = EOS_NOT_REACHED;
 
+#if SVT_AV1_CHECK_VERSION(3, 0, 0)
+    svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, &svt_enc->enc_params);
+#else
     svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, svt_enc, &svt_enc->enc_params);
+#endif
     if (svt_ret != EB_ErrorNone) {
         return svt_print_error(avctx, svt_ret, "Error initializing encoder handle");
     }
-- 
2.46.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: unbreak build with latest svtav1

[Timo Rothenpieler]

On 22.02.2025 06:14, Gyan Doshi wrote:
> SVT-AV1 made a change in their public API in 988e930c but without a
> version bump or any other accessible marker, thus breaking ffmpeg build
> with current versions of SVT-AV1.
> 
> They have finally bumped versions a month later, so check added.
> ---
>   libavcodec/libsvtav1.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> index 79b28eb4df..43fe531fde 100644
> --- a/libavcodec/libsvtav1.c
> +++ b/libavcodec/libsvtav1.c
> @@ -435,7 +435,11 @@ static av_cold int eb_enc_init(AVCodecContext *avctx)
>   
>       svt_enc->eos_flag = EOS_NOT_REACHED;
>   
> +#if SVT_AV1_CHECK_VERSION(3, 0, 0)
> +    svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, &svt_enc->enc_params);
> +#else
>       svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, svt_enc, &svt_enc->enc_params);
> +#endif
>       if (svt_ret != EB_ErrorNone) {
>           return svt_print_error(avctx, svt_ret, "Error initializing encoder handle");
>       }

LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: unbreak build with latest svtav1

[Gyan Doshi]

On 2025-02-22 06:47 pm, Timo Rothenpieler wrote:
> On 22.02.2025 06:14, Gyan Doshi wrote:
>> SVT-AV1 made a change in their public API in 988e930c but without a
>> version bump or any other accessible marker, thus breaking ffmpeg build
>> with current versions of SVT-AV1.
>>
>> They have finally bumped versions a month later, so check added.
>> ---
>>   libavcodec/libsvtav1.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
>> index 79b28eb4df..43fe531fde 100644
>> --- a/libavcodec/libsvtav1.c
>> +++ b/libavcodec/libsvtav1.c
>> @@ -435,7 +435,11 @@ static av_cold int eb_enc_init(AVCodecContext 
>> *avctx)
>>         svt_enc->eos_flag = EOS_NOT_REACHED;
>>   +#if SVT_AV1_CHECK_VERSION(3, 0, 0)
>> +    svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, 
>> &svt_enc->enc_params);
>> +#else
>>       svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, 
>> svt_enc, &svt_enc->enc_params);
>> +#endif
>>       if (svt_ret != EB_ErrorNone) {
>>           return svt_print_error(avctx, svt_ret, "Error initializing 
>> encoder handle");
>>       }
>
> LGTM

Thanks. Pushed as d1ed5c06e3edc5f2b5f3664c80121fa55b0baa95

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".