Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: unbreak build with latest svtav1
Date: Sat, 22 Feb 2025 18:59:25 +0530
Message-ID: <e605a754-ee51-425f-a2d4-0f88a9707e68@gyani.pro> (raw)
In-Reply-To: <8fafeb3b-d2c7-44cc-81bb-f7dbfa88c8d9@rothenpieler.org>



On 2025-02-22 06:47 pm, Timo Rothenpieler wrote:
> On 22.02.2025 06:14, Gyan Doshi wrote:
>> SVT-AV1 made a change in their public API in 988e930c but without a
>> version bump or any other accessible marker, thus breaking ffmpeg build
>> with current versions of SVT-AV1.
>>
>> They have finally bumped versions a month later, so check added.
>> ---
>>   libavcodec/libsvtav1.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
>> index 79b28eb4df..43fe531fde 100644
>> --- a/libavcodec/libsvtav1.c
>> +++ b/libavcodec/libsvtav1.c
>> @@ -435,7 +435,11 @@ static av_cold int eb_enc_init(AVCodecContext 
>> *avctx)
>>         svt_enc->eos_flag = EOS_NOT_REACHED;
>>   +#if SVT_AV1_CHECK_VERSION(3, 0, 0)
>> +    svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, 
>> &svt_enc->enc_params);
>> +#else
>>       svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, 
>> svt_enc, &svt_enc->enc_params);
>> +#endif
>>       if (svt_ret != EB_ErrorNone) {
>>           return svt_print_error(avctx, svt_ret, "Error initializing 
>> encoder handle");
>>       }
>
> LGTM

Thanks. Pushed as d1ed5c06e3edc5f2b5f3664c80121fa55b0baa95

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-02-22 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-22  5:14 Gyan Doshi
2025-02-22 13:17 ` Timo Rothenpieler
2025-02-22 13:29   ` Gyan Doshi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e605a754-ee51-425f-a2d4-0f88a9707e68@gyani.pro \
    --to=ffmpeg@gyani.pro \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git