From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DA94A4D83F for ; Mon, 24 Feb 2025 19:16:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 977F268CA0E; Mon, 24 Feb 2025 21:16:33 +0200 (EET) Received: from sender2-op-o10.zoho.eu (sender2-op-o10.zoho.eu [136.143.171.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 01BCC68C2EF for ; Mon, 24 Feb 2025 21:16:26 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; t=1740424582; cv=none; d=zohomail.eu; s=zohoarc; b=SE54dxVA/4wloTZge35C5TGKPSdtt47cFsT41DyeUs8SANIJd557mzsNpKI2+SzMiv4APFWqhTsfol3gypSVbuuhAbuMlO6fEUXYxm0sGnVY3fl722N5sMwjah5A9dBHOgXRXv0gKIJp5RXGR/CB/0xfplja5iKWlyM6lToxvm4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1740424582; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=x2GpLJha3Hghmyg/5nuzcODFYFYEZWktud4XGOmF5xI=; b=e59BuoYTGN87scWEGRRMnb3RWPvzvJ8DZFQxVkr59EuLhzlROMN463i636v+rg/lFD8g9aypRcGA+gJmBHs22BQyu1nYjYKLdkuLt6SJpKs6wRt1r4R5YsM6u2Bak8d6ZBYVDrRKx8ULAihyozsbcqfeiDNYaw6Ybi5iDOBtna4= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=frankplowman.com; spf=pass smtp.mailfrom=post@frankplowman.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1740424582; s=zmail; d=frankplowman.com; i=post@frankplowman.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=x2GpLJha3Hghmyg/5nuzcODFYFYEZWktud4XGOmF5xI=; b=NB6Pl/RojtpBvKhQHOq4VvuhFNxhNzQ4y5Pvu70PviqTycs7+N8IOhl3T75Kpl0m 84VqEaPHsulqP0cjJfdzY7pcgdgNNmcPSz2m2ZvLSBjikB7Azzg1va/C86d2CibcyRU RY+ShdQMsuBbMYVwGQhLEub/6N690XDbhi475qiE= Received: by mx.zoho.eu with SMTPS id 1740424580444739.0145720565309; Mon, 24 Feb 2025 20:16:20 +0100 (CET) Message-ID: Date: Mon, 24 Feb 2025 19:16:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20250223120454.37614-1-post@frankplowman.com> <20250223120454.37614-2-post@frankplowman.com> <6ca54bfe-2161-49d2-b52f-ce9392f8d0eb@gmail.com> From: Frank Plowman In-Reply-To: <6ca54bfe-2161-49d2-b52f-ce9392f8d0eb@gmail.com> X-ZohoMailClient: External Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/vvc: Fix pps_single_slice_picture X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 24/02/2025 02:23, James Almer wrote: > On 2/23/2025 9:04 AM, Frank Plowman wrote: >> Signed-off-by: Frank Plowman >> --- >> libavcodec/vvc/ps.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c >> index fae6655cc0..603a6d42d1 100644 >> --- a/libavcodec/vvc/ps.c >> +++ b/libavcodec/vvc/ps.c >> @@ -368,9 +368,10 @@ static int pps_add_ctus(VVCPPS *pps, int *off, const int rx, const int ry, >> >> static void pps_single_slice_picture(VVCPPS *pps, int *off) >> { >> + pps->num_ctus_in_slice[0] = 0; >> for (int j = 0; j < pps->r->num_tile_rows; j++) { >> for (int i = 0; i < pps->r->num_tile_columns; i++) { >> - pps->num_ctus_in_slice[0] = pps_add_ctus(pps, off, >> + pps->num_ctus_in_slice[0] += pps_add_ctus(pps, off, >> pps->col_bd[i], pps->row_bd[j], >> pps->r->col_width_val[i], pps->r->row_height_val[j]); >> } > > Is there a sample in the conformance suite this fixes? Or one we can > upload to FATE to make a test. Hi James, The conformance suite is pretty lacking here considering the number of combinations of these different partitioning tools possible in VVC. I think the lack of examples in the conformance suite is the main reason we're still running into bugs in this area. I crafted a sample which exhibits this bug though, and have sent it to samples-request@ffmpeg.org. I tried to also craft a sample which tests 93aae172ea909ec96b67077b8b3005886a83d0ae, but any attempt at this seemed to segfault the reference software :) -- All the best, Frank _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".