From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 66AA745E59 for ; Sat, 13 May 2023 01:05:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0DAE968C089; Sat, 13 May 2023 04:04:59 +0300 (EEST) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 28B2668BF9B for ; Sat, 13 May 2023 04:04:52 +0300 (EEST) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6ab094a7c04so2692803a34.3 for ; Fri, 12 May 2023 18:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683939890; x=1686531890; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=SHVK5RkbDldVDX8SyLbo+pw8bejiSYQx/BVtfXbYALw=; b=C3l/t4Zu/IswlmsyakCibl34sXeffjydnhOnXbjEleR1K1gqI3vc0sSl0lhRXO079g YF597xyVP9MNTnma2s0qHpOx0zUW7v47u9g5Guf2c2bKzbICDd+m1XxZ8rRYf5epCNOj QDE0HB+dbl6vSCBI+LGxXD7g1g0wu9hSor57F3aTfnW/0arv6qiE92m/pCZdjodYYP0f Io+H2Tis/3St1WEOoLXz7GpN820RPrc2OwP4EW971uMQRBJrzLhiNr/hyehgJZGoG1Hb UMBF8y9unwiQ3SDWzJa+tYwtsWgXEb8szq7K6fw7YfCCq2+BIrzTp4rjIjDbCHDwoYsq pO9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683939890; x=1686531890; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SHVK5RkbDldVDX8SyLbo+pw8bejiSYQx/BVtfXbYALw=; b=XITsQ377afI1tZaCC83g87zpvQOcr2wNm3JAUgG4foKFHx6KSJDNcUQmYso9MakvIW TjYwTpmDN+d/6qTrX+RPqmoN3tLyfPgeRjYe4SeAXU+3NhiKl2ItP0L+4+ozruW1GC4t GW5uNkUhScyJOkNqdVtIwYQr+YvZk6Q8mLmwnHGHQcJzgmX05YRSL/GdlpcUJT8O3HRs 6iw2V2ka+fuF6ITsv1ck1HA5X16iEtS4rDZ5xw6ZhG56yth5WHBJQDWYfIrpxanGzseM FJYcLtUJ2ZyPXHrS8PjmZfe8rUqVgVlNOBrlOS6xxSkg6M6IXKNOm9IW8tPUK1Kzb9H7 8+fw== X-Gm-Message-State: AC+VfDzQSV39aZDfCtQvk3+hLEuIqYwhih9FV+0LY45zlTfvw9RwaE8r THCjqb2L1ulMAlc6SSN/pDs4dD8jIno= X-Google-Smtp-Source: ACHHUZ5V2bvdXlm9QPzF2Tmy2e3obnwdttbcX6Vw4rZFPip0GR+PjysA6PHrkUYpN3RtHKaQhAqX8A== X-Received: by 2002:a05:6870:8220:b0:192:b208:bc63 with SMTP id n32-20020a056870822000b00192b208bc63mr12634555oae.16.1683939889733; Fri, 12 May 2023 18:04:49 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id s3-20020a05687087c300b0017243edbe5bsm9635761oam.58.2023.05.12.18.04.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 18:04:49 -0700 (PDT) Message-ID: Date: Fri, 12 May 2023 22:04:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avfilter/avfiltergraph: fix illogical flaws in code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/12/2023 5:49 PM, Paul B Mahol wrote: > Attached. > From 11907ee612b0440faeb3804e8f9af5e36a63db89 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Fri, 12 May 2023 21:01:41 +0200 > Subject: [PATCH] avfilter/avfiltergraph: fix illogical flaws in code > > Signed-off-by: Paul B Mahol > --- > libavfilter/avfiltergraph.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c > index 53f468494d..744f480e1d 100644 > --- a/libavfilter/avfiltergraph.c > +++ b/libavfilter/avfiltergraph.c > @@ -748,8 +748,10 @@ static int reduce_formats_on_filter(AVFilterContext *filter) > (KNOWN(fmt) || fmts->all_counts)) { > /* Turn the infinite list into a singleton */ > fmts->all_layouts = fmts->all_counts = 0; > - if (ff_add_channel_layout(&outlink->incfg.channel_layouts, fmt) < 0) > - ret = 1; > + ret = ff_add_channel_layout(&outlink->incfg.channel_layouts, fmt); > + if (ret < 0) > + return ret; > + ret = 1; > break; > } Probably ok. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".