From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AA8EA4972D for ; Tue, 18 Jun 2024 00:34:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9952468D7A3; Tue, 18 Jun 2024 03:34:08 +0300 (EEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 18A2568D77B for ; Tue, 18 Jun 2024 03:34:02 +0300 (EEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1f32a3b9491so40154715ad.0 for ; Mon, 17 Jun 2024 17:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718670839; x=1719275639; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=ocbh5YHVxyYMdZ9x5vIyH4Ps18wmZgVvjeTr9coyqQs=; b=iwGokdHV/ka5kWGm4MSiQNzGkp6l1XPCoLAXnhmLhQTYTGI77dlBh/oCvc6D1PzcNc gmtPOa+oOabLsI6vC6wRscQdsMwumyiMfxoiKbQwJRTq5X8/nwtn7Bz87Yv9lhQA1UcL tQBtqF1hzZEWdKGI86Ln6wnUHMAyQLDxqCgDhWHNcWL0im/Ki+izPbJ7WAvtQRx/e7Uf rhq2rWmeZDJ8/l1Qum+3/Gkr4zlKsdWlrx3cIb83z1NguDRf0pi/g+1vLvyPB+cwJP55 gXtlzJivLFFjDzA46+niFp3GOmNW/bn0djm2CAb+u47aaIdruR1ISQs095DwA7UXtzL4 V22A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718670839; x=1719275639; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ocbh5YHVxyYMdZ9x5vIyH4Ps18wmZgVvjeTr9coyqQs=; b=hMNzNVxPzkHclj5L/6/JnMJN/rG6xdSu5e1M48VUk30i8oZs1gKa77m2C6BQDM3fjk FDI9J0bZNgd+EUtwmo3llZ/NFC1Q+NA5YIdLfv3EI0yJHvD1NqtC9JvEXh2tJSXH256T xFLukLmjDfgpjmhJElBsgF50kBsnVVtKldWIb4VDcHICC4DHrTTgB6ztCjKtRksN+dTA rRnGooEHN3ytEz8NCHININjeI/QzK6dLkftmkop5sm5nCbAs1SYIeuPI8nxFBdyvkVVF FlQmtpwyIcV+qLeZpFiMGxk1/uoPTOn1mVMLjzchA0AamQuv4/JeS7Prp5BafgyOcdMb m5sA== X-Gm-Message-State: AOJu0YzxYJPxef5UCrayQb8HB3V7CWXDIgD2a23BzeBxOHeFuY2MKa9r VGYOtCPH4Lu9GYaIMyTXi8SkEd/++zbniSJh9nsZsjdPLVDwDeyt6XgLow== X-Google-Smtp-Source: AGHT+IGeScs3yR5NRWjQp58iJr0iu15UzpsRY9e6ALoXoteqMBtww9fKAyhQ82PmxLGSAEF/w+B9iQ== X-Received: by 2002:a17:902:d504:b0:1f8:55da:bd1a with SMTP id d9443c01a7336-1f8625d39ccmr114729925ad.25.1718670838676; Mon, 17 Jun 2024 17:33:58 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855e56177sm85335205ad.56.2024.06.17.17.33.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 17:33:58 -0700 (PDT) Message-ID: Date: Mon, 17 Jun 2024 21:33:59 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240616230831.912377-1-michael@niedermayer.cc> <20240616230831.912377-4-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20240616230831.912377-4-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 4/9] avformat/iamf_parse: Layer, thou shalt not be 0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/16/2024 8:08 PM, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: 68302/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4665793796177920 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/iamf_parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c > index 5c2ff6862a7..12c2b9533a8 100644 > --- a/libavformat/iamf_parse.c > +++ b/libavformat/iamf_parse.c > @@ -330,7 +330,7 @@ static int scalable_channel_layout_config(void *s, AVIOContext *pb, > nb_layers = avio_r8(pb) >> 5; // get_bits(&gb, 3); > // skip_bits(&gb, 5); //reserved > > - if (nb_layers > 6) > + if (nb_layers > 6 || nb_layers == 0) > return AVERROR_INVALIDDATA; > > audio_element->layers = av_calloc(nb_layers, sizeof(*audio_element->layers)); LGMT, but please change the commit message. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".