From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0A3A94B4A9 for ; Sun, 7 Jul 2024 16:09:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B28468DA25; Sun, 7 Jul 2024 19:09:45 +0300 (EEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3841468D9B0 for ; Sun, 7 Jul 2024 19:09:38 +0300 (EEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2c967e21888so2123292a91.1 for ; Sun, 07 Jul 2024 09:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720368574; x=1720973374; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=QZTCqTya8jZ8uS/YwSgzJknCcnVRHZ7r1R4ca+IalbA=; b=L0PYRCwYFtXHwZRsy7gYKgwWLGAYlGQxh4JLGfw7tBkKkpXfNESX0Npp7riOID9Cqt AdfhbDOTF2QkaWE3RdDpoeJ9Iv8m5BCbY3fhvknpSq5DR+hImjwZURsbHzAeeVkPK/JG 7Qr+WkkAhp4hVjH/7tX4lwKErgFvY+xpKB5m9S2xe/5/fYzpfXuE/hMj9dWIyMy0Y88R O6K+hYVKlAbUmujdyKWjPUOtt8yeuznoiV73TESJVJkqkQ2yFKrXe1BOY5t502QOu87o FtCQ2zBSACfUsA4V7e5BLwCAKw/3qEz62H8EDFF2jK6OKwcQ6ZH+uYppKr6Q6J0Q+SMH G4xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720368574; x=1720973374; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QZTCqTya8jZ8uS/YwSgzJknCcnVRHZ7r1R4ca+IalbA=; b=Q/96wKGL4e0absq6/ny6yPRFiwqhFr1B1ZgMNH3YY3M8rfiLCrw6FiGj8TMSqI5LED sK0ONO5b8FIoEMIU7AMVGjdABjxHrl6WCVgIuDYDhkq7L4+PuulxVNaJQ6YFF+MS3GeK AeRXRCDisXQfCA2Z3T5sQj1dfnsU5/MqodSExr2jN1A/OtNrBfd8enibskk/AU2ZB2qk BxubNJA9WXjnCBIc6YNTHnrYbAZ5WjnATMDJr2PZz6SpQIK5QkR4hEt4fiT1BA/ZIb5L 9n+vxrGe01dr+LDJ8HtA5NEEhOtfKJYCshHt9CegNaFw1WZbcM/wSGALYXzgYuCeMXaH N0jg== X-Gm-Message-State: AOJu0Ywr/ncIaAyvpGkCSUWpaGNKQ1kZrNIj1PJcUQEg6iKTIehT/3eS /L77jJ1Rygq+ML8iKQzWU0rcz+w7OLc/aeOhUVdEEn0PMGf3nYzeiGGu6w== X-Google-Smtp-Source: AGHT+IEFdtKS9xiGN5VRV8ym1ZLS6Fa3fuRrmUyUHppu26qukjTz9Vr+hOSaFmfxWAqJgUz9dKfTsA== X-Received: by 2002:a17:90a:9c6:b0:2c9:993b:e2fb with SMTP id 98e67ed59e1d1-2c99c6d0938mr7425237a91.40.1720368574039; Sun, 07 Jul 2024 09:09:34 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c9965827fesm6304055a91.0.2024.07.07.09.09.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jul 2024 09:09:33 -0700 (PDT) Message-ID: Date: Sun, 7 Jul 2024 13:09:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240703212648.48483-1-jamrial@gmail.com> <20240703212648.48483-4-jamrial@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 04/11] avformat/hevc: don't write NALUs with nuh_layer_id > 0 in hvcC boxes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/7/2024 12:46 PM, Andreas Rheinhardt wrote: > James Almer: >> hvcC should only contain nuh_layer_id == 0 NALUs. Support for a box meant to >> contain higher layer NALUs will be added in a following patch. >> To achieve this, all sources are parsed and filtered, including hvcC source >> that until now were propagated untouched. This is reflected in how the affected >> reference files now have ps_array_completeness set to 0 instead of 1 for some >> non-PS NALUs. > > Was the earlier stuff wrong? Probably, but it's unlikely that any nuh_layer_id > 0 NALU was ever written as it would have required either a broken isobmff source (where such NALUs were wrongly put in hvcC for us to then blindly copy), or a raw multilayer annex-b source. > >> >> Signed-off-by: James Almer >> --- >> libavformat/hevc.c | 140 ++++++++++++++++----- >> libavformat/hevc.h | 3 +- >> tests/ref/fate/enhanced-flv-hevc | 4 +- >> tests/ref/fate/matroska-dovi-write-config8 | 4 +- >> tests/ref/lavf-fate/hevc.flv | 2 +- >> 5 files changed, 118 insertions(+), 35 deletions(-) >> > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".