From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1B6CB47958 for ; Wed, 27 Dec 2023 17:16:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9EB4968C6F3; Wed, 27 Dec 2023 19:16:03 +0200 (EET) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D0F8E68C496 for ; Wed, 27 Dec 2023 19:15:56 +0200 (EET) Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3600dc78bc0so6813915ab.2 for ; Wed, 27 Dec 2023 09:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703697354; x=1704302154; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=acL1hNMlHR/zo/FfKk6UfcRgqr1ZuYeqGXzh9Bu5OZo=; b=D0gzEnU5EP7wnRobZXSQaZ0VmKIqhuaUqk9rNuawppWU5issxIL10vknj5KSuOxKL7 5IoO90EXMtxVEIqDKRNibrL3abHjVzOLTomSZgAApDM9Ct5vfzbdxDXe9mdGrM/G4p2J 8t28a0z2Ebn9i159Jfd4hUI+BKEyFTsmBwuDLxuAq7bhc5Ma/Qty8W5pzXUEMn4EE2aw WodeIhrkp1UdT/Ri8WWEK0xH5v44vPU4PzvP8Q8SGjJw+BKxw3a37cIKMI5rPzRMt+Js DZTgI1x4oDtT/ou0KC6JQaUqgTa4Fp4vTWdUYepRjDDcFMvPkC1gpETTtNS0HjFKgH6J zbNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703697354; x=1704302154; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=acL1hNMlHR/zo/FfKk6UfcRgqr1ZuYeqGXzh9Bu5OZo=; b=TBezSohQBPBq4OvtA+eR2h4KGJqevu26ete5pWQKV14DTUbQ/mesNr6A/c1kEw4zHb k/TpFPYF2TZbuBL/CftgwEc82tjNTFQ3S4aZK/bdT6shgHCVEcP1bJBAI6/Bp6QJqo2t 2UXGOxM1wCfc0udFZQ+kUgGnMa4pjNWez8zJI1bgxmo8Mabzj/EnmWQMQ0IeqQXQ81wO KQ2FLKrpi6zMdD4uKqoEpHs9gm8oNYnLSZxEqLMBj6J4DhUmfEEjTA7ZJJy9Gm9FM8xO em7GYTKlaB61VvRpL/+XqOAHFpAfq3lmVSYyq60ol+l6H7GxwClkh/nBANcMALSOomQs mqnA== X-Gm-Message-State: AOJu0Ywq+HpFXNlGKo4UcKmsKIdKeKVpvZDNothlnJRadEs3o89ryr18 y6euwvxvPL1iKIU+h+zoIkeRCVP37x8= X-Google-Smtp-Source: AGHT+IGkPx8/cwk2lotSa+n6Sob3D4YWVDYCHL1aoZZrqZ++WAAzqZC/xukxrilVgx5FwEpiWAxVJw== X-Received: by 2002:a05:6e02:1b09:b0:35f:b106:9092 with SMTP id i9-20020a056e021b0900b0035fb1069092mr14926795ilv.10.1703697354343; Wed, 27 Dec 2023 09:15:54 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id o23-20020a63e357000000b005c66a7d70fdsm11222830pgj.61.2023.12.27.09.15.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Dec 2023 09:15:53 -0800 (PST) Message-ID: Date: Wed, 27 Dec 2023 14:16:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231226162033.782945-1-stefasab@gmail.com> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add quirc filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/27/2023 8:37 AM, Stefano Sabatini wrote: > On date Tuesday 2023-12-26 22:33:36 -0300, James Almer wrote: >> On 12/26/2023 10:25 PM, Stefano Sabatini wrote: >>> On date Tuesday 2023-12-26 17:20:33 +0100, Stefano Sabatini wrote: >>>> --- >>>> Changelog | 1 + >>>> configure | 4 + >>>> doc/filters.texi | 35 ++++++++ >>>> libavfilter/Makefile | 1 + >>>> libavfilter/allfilters.c | 1 + >>>> libavfilter/vf_quirc.c | 183 +++++++++++++++++++++++++++++++++++++++ >>>> 6 files changed, 225 insertions(+) >>>> create mode 100644 libavfilter/vf_quirc.c >>> >>> V2 with a few fixes and all corners put in the metadata (e.g. in case >>> the QR code is rotated). >> > >> Looking at the library, the license is very permissive and the code hasn't >> been touched in many years. It is also pretty small, so why not just add it >> as a native filter instead of requiring an external dependency for what >> seems to be a relatively simple process? > > I see pros and cons, in total that would be about 3K lines of pretty > clean code and data, and this would simplify integration for end-users > (since they would not need to build the library, which seems not > packaged by many distributions), and having the code would help to > solve similar problems and probably could be generalized and optimized > (e.g. to support other pixel formats). > > OTOH it would add to the maintenance burden since we would be owners > of the code, which also means we would not benefit from fixes to the > upstream project, in case they happen (last commit is from March > 2023, so not very old): > https://github.com/dlbeer/quirc/commit/542848dd6b9b0eaa9587bbf25b9bc67bd8a71fca That's a build system change, so not really relevant. Last real change was https://github.com/dlbeer/quirc/commit/cc673124335785d220dbb9057b21c51e4a87e0b2, also from March 2023, but the one before it is from August 2021. I really think this should be ported as a native filter. It's not big and complex like a scaler (sws, zscale) which should not live within libavfilter. Any change can be contributed back to libquirc (A library that's not going to be abandoned like it happened with libdcadec after it was merged into lavc, because its license is more permissive than our LGPL, which has its merits). Lets try to keep external dependencies as limited as possible. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".