From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: fix alignment requirements for audio and video filters
Date: Wed, 2 Mar 2022 07:23:08 +0000
Message-ID: <e4a6805a4d2896c0ba923b96586174cb0a240a77.camel@intel.com> (raw)
In-Reply-To: <ae4f31e6-e0cf-cb9b-4ffd-0ba5126f2ad4@gmail.com>
On Tue, 2022-03-01 at 10:43 -0300, James Almer wrote:
> On 3/1/2022 4:12 AM, Xiang, Haihao wrote:
> > Hi,
> >
> > fate-vsynth1-mpeg2-422 is broken after this patch (commit 17a59a6).
> >
> > --- ./tests/ref/vsynth/vsynth1-mpeg2-422 2021-11-22
> > 12:59:25.013517219 +0800
> > +++ tests/data/fate/vsynth1-mpeg2-422 2022-03-01 13:30:48.446378312 +0800
> > @@ -1,4 +1,4 @@
> > -6e135a1a27235a320311a932147846b4 *tests/data/fate/vsynth1-mpeg2-
> > 422.mpeg2video
> > -730780 tests/data/fate/vsynth1-mpeg2-422.mpeg2video
> > -0273cd8463d1fc115378748239951560 *tests/data/fate/vsynth1-mpeg2-
> > 422.out.rawvideo
> > -stddev: 10.27 PSNR: 27.90 MAXDIFF: 162 bytes: 7603200/ 7603200
> > +ac2bfd738a93180bd3cb285367236d85 *tests/data/fate/vsynth1-mpeg2-
> > 422.mpeg2video
> > +702035 tests/data/fate/vsynth1-mpeg2-422.mpeg2video
> > +b8db8de89c37fab3b9a0248c2820a5ed *tests/data/fate/vsynth1-mpeg2-
> > 422.out.rawvideo
> > +stddev: 10.30 PSNR: 27.87 MAXDIFF: 167 bytes: 7603200/ 7603200
> >
> > configuration: --prefix=/usr --libdir=/usr/lib/x86_64-linux-gnu --
> > shlibdir=/usr/lib/x86_64-linux-gnu --disable-static --enable-shared --
> > enable-gpl
> >
> > It works with option --disable-ssse3
> >
> > Below is the info for my CPU
> >
> > $ cat /proc/cpuinfo | grep 'model name' | head -1
> > model name : Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz
> >
> > Thanks
> > Haihao
>
> Does this help?
>
> > diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c
> > index 5b510c9af9..8258a79845 100644
> > --- a/libavfilter/framepool.c
> > +++ b/libavfilter/framepool.c
> > @@ -90,7 +90,7 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef*
> > (*alloc)(size_t size),
> > }
> >
> > for (i = 0; i < 4 && pool->linesize[i]; i++) {
> > - int h = pool->height;
> > + int h = FFALIGN(pool->height, align);
> > if (i == 1 || i == 2)
> > h = AV_CEIL_RSHIFT(h, desc->log2_chroma_h);
>
> It's the only behavior change i could find in the patch that could make
> a difference.
>
The above change doesn't work for me.
Thanks
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-02 7:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 12:27 Paul B Mahol
2022-02-21 17:57 ` James Almer
2022-02-21 18:14 ` Paul B Mahol
2022-02-21 22:36 ` James Almer
2022-03-01 7:12 ` Xiang, Haihao
2022-03-01 8:07 ` Paul B Mahol
2022-03-01 13:43 ` James Almer
2022-03-02 7:23 ` Xiang, Haihao [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-20 22:02 Paul B Mahol
2022-02-21 1:53 ` James Almer
2022-02-21 11:33 ` Paul B Mahol
2022-02-21 12:08 ` James Almer
2022-02-20 18:07 Paul B Mahol
2022-02-21 11:07 ` Anton Khirnov
2022-02-21 11:34 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a6805a4d2896c0ba923b96586174cb0a240a77.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git