From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v9 13/13] vvcdec: add vvc decoder
Date: Fri, 5 Jan 2024 17:48:57 -0300
Message-ID: <e4a18984-5269-4bf0-8a4f-51038112cf74@gmail.com> (raw)
In-Reply-To: <TYSPR06MB6433BDADB7306C064B6637FCAA62A@TYSPR06MB6433.apcprd06.prod.outlook.com>
On 1/1/2024 11:12 AM, Nuo Mi wrote:
> +static int decode_nal_units(VVCContext *s, VVCFrameContext *fc, AVPacket *avpkt)
> +{
> + const CodedBitstreamH266Context *h266 = s->cbc->priv_data;
> + CodedBitstreamFragment *frame = &s->current_frame;
> + int ret = 0;
> + int eos_at_start = 1;
This never changes, yet it's checked below like it does.
> + s->last_eos = s->eos;
> + s->eos = 0;
> +
> + ff_cbs_fragment_reset(frame);
> + ret = ff_cbs_read_packet(s->cbc, frame, avpkt);
> + if (ret < 0) {
> + av_log(s->avctx, AV_LOG_ERROR, "Failed to read packet.\n");
> + return ret;
> + }
> + /* decode the NAL units */
> + for (int i = 0; i < frame->nb_units; i++) {
> + const H2645NAL *nal = h266->common.read_packet.nals + i;
> + const CodedBitstreamUnit *unit = frame->units + i;
> +
> + if (unit->type == VVC_EOB_NUT || unit->type == VVC_EOS_NUT) {
> + if (eos_at_start)
> + s->last_eos = 1;
> + else
> + s->eos = 1;
> + } else {
> + ret = decode_nal_unit(s, fc, nal, unit);
> + if (ret < 0) {
> + av_log(s->avctx, AV_LOG_WARNING,
> + "Error parsing NAL unit #%d.\n", i);
> + goto fail;
> + }
> + }
> + }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-05 20:49 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240101141239.6623-1-nuomi2021@gmail.com>
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 01/13] vvcdec: add vvc_data Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 02/13] vvcdec: add parameter parser for sps, pps, ph, sh Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder Nuo Mi
2024-01-01 15:13 ` Lynne
2024-01-02 13:21 ` Nuo Mi
2024-01-02 15:57 ` Lynne
2024-01-03 1:38 ` Nuo Mi
2024-01-01 17:34 ` Michael Niedermayer
2024-01-02 13:44 ` Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 04/13] vvcdec: add reference management Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 05/13] vvcdec: add motion vector decoder Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 06/13] vvcdec: add inter prediction Nuo Mi
2024-01-01 15:04 ` Lynne
2024-01-02 14:16 ` Nuo Mi
2024-01-02 14:30 ` Kieran Kunhya
2024-01-02 15:59 ` Lynne
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 07/13] vvcdec: add inv transform 1d Nuo Mi
2024-01-01 14:50 ` Lynne
2024-01-02 13:01 ` Nuo Mi
2024-01-02 15:55 ` Lynne
2024-01-03 12:04 ` Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 08/13] vvcdec: add intra prediction Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters Nuo Mi
2024-01-01 15:17 ` Lynne
2024-01-02 9:47 ` Nuo Mi
2024-01-02 11:38 ` Jean-Baptiste Kempf
2024-01-02 15:51 ` Lynne
2024-01-03 1:14 ` Nuo Mi
2024-01-03 18:38 ` Michael Niedermayer
2024-01-04 11:45 ` Nuo Mi
2024-01-04 12:06 ` Martin Storsjö
2024-01-04 13:57 ` Nuo Mi
2024-01-04 14:53 ` James Almer
2024-01-05 0:02 ` Nuo Mi
2024-01-05 11:55 ` Martin Storsjö
2024-01-05 20:47 ` Michael Niedermayer
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 10/13] vvcdec: add dsp init and inv transform Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 11/13] vvcdec: add CTU parser Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 12/13] vvcdec: add CTU thread logical Nuo Mi
2024-01-01 14:12 ` [FFmpeg-devel] [PATCH v9 13/13] vvcdec: add vvc decoder Nuo Mi
2024-01-01 14:53 ` Lynne
2024-01-01 15:14 ` Hendrik Leppkes
2024-01-01 15:22 ` Lynne
2024-01-02 9:38 ` Nuo Mi
2024-01-02 11:41 ` Jean-Baptiste Kempf
2024-01-02 16:00 ` Lynne
2024-01-05 20:48 ` James Almer [this message]
2024-01-06 17:47 ` James Almer
2024-01-07 5:31 ` Nuo Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a18984-5269-4bf0-8a4f-51038112cf74@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git