Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through

From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through
Date: Tue, 03 Jan 2023 19:11:43 +0100
Message-ID: <e4710a4962b374695a5964b4940afa5cabd00733.camel@haerdin.se> (raw)
In-Reply-To: <tencent_D04A9F47AB3E4E0070DE2D009A3A401D9A08@qq.com>

tis 2023-01-03 klockan 18:18 +0800 skrev Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
> ---
>  libavcodec/videotoolboxenc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/videotoolboxenc.c
> b/libavcodec/videotoolboxenc.c
> index 27db4e0d5e..3b00e542cb 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -2156,7 +2156,7 @@ static int get_cv_pixel_info(
>  
>      status = get_cv_pixel_format(avctx, av_format, av_color_range,
> color, &range_guessed);
>      if (status)
> -        return AVERROR(EINVAL);
> +        return status;
>  
>      if (range_guessed) {
>          if (!vtctx->warned_color_range) {
> @@ -2338,7 +2338,7 @@ static int
> create_cv_pixel_buffer(AVCodecContext   *avctx,
>              status
>          );
>  
> -        return AVERROR_EXTERNAL;
> +        return status;

Are these guaranteed to always be negative?

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".