From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 7C56946135
	for <ffmpegdev@gitmailbox.com>; Sun,  7 May 2023 22:30:04 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 40DD468C11E;
	Mon,  8 May 2023 01:30:02 +0300 (EEST)
Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com
 [209.85.167.179])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A29368C06A
 for <ffmpeg-devel@ffmpeg.org>; Mon,  8 May 2023 01:29:56 +0300 (EEST)
Received: by mail-oi1-f179.google.com with SMTP id
 5614622812f47-38ef6217221so2188933b6e.3
 for <ffmpeg-devel@ffmpeg.org>; Sun, 07 May 2023 15:29:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1683498594; x=1686090594;
 h=content-transfer-encoding:in-reply-to:from:content-language
 :references:to:subject:user-agent:mime-version:date:message-id:from
 :to:cc:subject:date:message-id:reply-to;
 bh=BIk0sCqL2olW96wdJ7yNmU/ZUt1RctA9gtowxxSG7as=;
 b=CMWRpTXvYFHlYLeEUe2ChhiKDAH/ryWbwWE4jm/ImlykYQ77STekVrFY5p8HHxsmaR
 5Q2EvExiiShPPqrcdskoIFeIcZtvgxZ91M+FlN9SNZIPZnDfydU7aKUl1wRVIPnVNQKh
 g5gsDUxd7hlgcNRPRdxzon3pgJ7gU0MYvP/Ws1W7nDrw6arVOcoImafIPxMXfw7sb2u8
 oL8I7T/w8CHIIG64iNPRCb7s9iX1K0ZOP86zCJL4IRKKlHT4HdBbibLzE+k9zo9yTu5Q
 OSdUhRk8CrYZVjFSpn3l8HrDqkdf1M5nPKVHvxtuQdmQY3VvFM+RWqozwX4e1chR3wxo
 x67g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1683498594; x=1686090594;
 h=content-transfer-encoding:in-reply-to:from:content-language
 :references:to:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=BIk0sCqL2olW96wdJ7yNmU/ZUt1RctA9gtowxxSG7as=;
 b=Tym4+bCxsl1FTD9fRMc7dpd+rUPv+ku6WPdOcCeqbGuLtp1K8UC5MPWFnaRS9XKEB9
 Ck0wdLTKDfbmsPpnvhC0gGHswXkJ84uKYuKFJBJhOaxlJ+Ozrw+8hjdS3FNFHn5dSLMV
 4c8E3hfhAgcELelgKwYgXOBPJJ+mila72Nj9p7L0m9Gs/hb1+ro2VfqCbptfNKvDJjMs
 obfrTLjsZWHyKtADLZ0St66DdlGFJL+xZptRNDcqNeD9xwWKjhh0EfRfU4eU7wZxfppC
 hTzc83vrgj7ipgLPEHok/OaCQfMbdWACeoIRaKoSM8Nh/zktg4TwiPqW98oWm7nhOxFu
 NcfA==
X-Gm-Message-State: AC+VfDzuZYTZNZ4codZ17M4OxWDl2UVSbIXA6FFj0cXJwobpmjbzW77n
 SAC29t1TlzfBk9CKYI75nW9Y/7fcB+4=
X-Google-Smtp-Source: ACHHUZ4x94upswcBWMToW19aNZwE3qcUSjaEfBJ9v7xT1xHU6r7pQA/T9b0gAKCKFsCQcrjhFXW8Zg==
X-Received: by 2002:aca:902:0:b0:392:54ca:90eb with SMTP id
 2-20020aca0902000000b0039254ca90ebmr3848929oij.14.1683498593995; 
 Sun, 07 May 2023 15:29:53 -0700 (PDT)
Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar.
 [190.225.105.197]) by smtp.gmail.com with ESMTPSA id
 r5-20020a056870414500b0018e996a507esm4337549oad.31.2023.05.07.15.29.52
 for <ffmpeg-devel@ffmpeg.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 07 May 2023 15:29:53 -0700 (PDT)
Message-ID: <e4646074-b00b-e2e2-e1d9-bb3df3845f77@gmail.com>
Date: Sun, 7 May 2023 19:30:03 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
To: ffmpeg-devel@ffmpeg.org
References: <20230505231856.29607-1-jamrial@gmail.com>
 <20230507212050.GA4348@mariano>
Content-Language: en-US
From: James Almer <jamrial@gmail.com>
In-Reply-To: <20230507212050.GA4348@mariano>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: print exported stream
 AVOptions
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/e4646074-b00b-e2e2-e1d9-bb3df3845f77@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 5/7/2023 6:20 PM, Stefano Sabatini wrote:
> On date Friday 2023-05-05 20:18:56 -0300, James Almer wrote:
>> Similar to the decoder AVOptions above.
> 
> Please briefly specify the use case in the log.

A line about how these are options whose values are changed by the 
demuxer and thus exported back to the caller?

> 
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>   fftools/ffprobe.c             | 12 ++++++++++++
>>   tests/ref/fate/flv-demux      |  4 ++--
>>   tests/ref/fate/ts-demux       |  6 +++---
>>   tests/ref/fate/ts-opus-demux  |  2 +-
>>   tests/ref/fate/ts-small-demux |  2 +-
>>   5 files changed, 19 insertions(+), 7 deletions(-)
>>
>> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
>> index 43bf10db54..9599b3b1b2 100644
>> --- a/fftools/ffprobe.c
>> +++ b/fftools/ffprobe.c
>> @@ -3127,6 +3127,18 @@ static int show_stream(WriterContext *w, AVFormatContext *fmt_ctx, int stream_id
>>           }
>>       }
>>   
>> +    if (fmt_ctx->iformat->priv_class && show_private_data) {
>> +        const AVOption *opt = NULL;
>> +        while (opt = av_opt_next(fmt_ctx->priv_data, opt)) {
>> +            uint8_t *str;
>> +            if (!(opt->flags & AV_OPT_FLAG_EXPORT)) continue;
>> +            if (av_opt_get(fmt_ctx->priv_data, opt->name, 0, &str) >= 0) {
>> +                print_str(opt->name, str);
>> +                av_free(str);
>> +            }
>> +        }
>> +    }
> 
> maybe factorize with the other similar code?

Sure.

> 
> [...]
> 
> LGTM otherwise.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".