From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C6794407DB for ; Mon, 31 Jan 2022 11:56:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 517F168B25E; Mon, 31 Jan 2022 13:56:03 +0200 (EET) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C163268B07D for ; Mon, 31 Jan 2022 13:55:56 +0200 (EET) Received: by mail-ot1-f53.google.com with SMTP id d18-20020a9d51d2000000b005a09728a8c2so12704856oth.3 for ; Mon, 31 Jan 2022 03:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=6jFWeb1EnNEBEdBBMbZRguleKAbL/Rwx1tz5iN/CMqM=; b=Ms2BJdzun2XoeTx2xUd1gag3E5Qahgx4jM6uLBm/1Z3nmHXYWa1Cu8Oy0PhHIgGiFC CZ1EMRXu9Ya+wfCsv6TBdQxlCqQkN8dOsvtRVMRMUTkDRCOt0y/DZj7ubikqMIX6ejNd WFdoGKBiclsVQ/nQoMHCZApJhUaWEt2LKrWTcTrws2TftIqmUK2lIGRwUS0IjkLqQret O0q5Aq/LpovdrcNYMW36J1iBdzzeIezKJ72UcGmyro6diYhrDlMGVfsGS2uzf2Q+CkGI HP376yD3VCjWVsabivuYkGXF6dd/ckqEO/ywcgHFe38iobMeuGia7x8LsBv6qqkhHj5c M7EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=6jFWeb1EnNEBEdBBMbZRguleKAbL/Rwx1tz5iN/CMqM=; b=VyPICsixwrTkZlGDbJXhGuMqRJVz1qjJPhKcW4VXKYhK9n68++4WoT2fK2u4LO7+92 PlEl5DCzMvk5cpd1Tpa0t++JX1I2r3l34KA5902cxWb1opK4lz3LZvbO2knqAo191h/N PeJXyfgMOqzWT7O4yIhJa5vusQJlSdGpRWPh0K2E9hhQnxst8pRV8K6KQV6mGaLN6itU NjVMKLHwHeB8NSq71kGEUGQin9MsmOnlOp973sWZ/HC+P1+DecJGFxBoLo/jayIZn5JA Fm/rHUbLAqPZt1DJZiGrblGgfY8CAkYqjZ5baFbzU4UV5lE+yJZ2t6HLUmlVxWhjCKKh Rzfg== X-Gm-Message-State: AOAM531hLOVN9zh2oEy3LPOEYcEZ4TuzMz5TeRnvG/k7Bat+UkD0n0wO sNZhsZ6Mk+dMetaab2Mb4PfnThFGb24= X-Google-Smtp-Source: ABdhPJzPCmv+b9ZwxSO0tba2w4BH59WQKWUsew4biRLR0iEVYZ9Fby2pBHWZ5EFJS1n0pEpop81pqA== X-Received: by 2002:a9d:4b0a:: with SMTP id q10mr11182588otf.345.1643630155054; Mon, 31 Jan 2022 03:55:55 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id n66sm14521312oif.35.2022.01.31.03.55.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 03:55:54 -0800 (PST) Message-ID: Date: Mon, 31 Jan 2022 08:55:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> <164363001951.23111.4989616914372511566@lain.red.khirnov.net> From: James Almer In-Reply-To: <164363001951.23111.4989616914372511566@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/31/2022 8:53 AM, Anton Khirnov wrote: > Quoting Thilo Borgmann (2022-01-18 14:58:07) >>>> Violations of code style. >> >> Enhanced. > > Not enough. There are still many remaining, e.g. > * opening brace of a function definition should be on its own line > * the context should generally be the first argument > * unsigned char* should be uint8_t* > * mixed declarations and code (the compiler should warn about that) I think someone said that clang (or some versions) is apparently not warning about this, hence why so many of these end up being missed in reviews or even by the patch author. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".