From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A753543D3F for ; Tue, 9 Aug 2022 05:40:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 687CD68B6A7; Tue, 9 Aug 2022 08:40:08 +0300 (EEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4B1D168B687 for ; Tue, 9 Aug 2022 08:40:01 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660023606; x=1691559606; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jdMUH9eb5Ev1kiBRe8zBSV5s4PTR20gV3aPDdVg/4eE=; b=KRKFDj78MDitKRrjr9h5VKwjXfOlLsdE+vKKEQVh9AMdY6ypPTcIdVR+ e7FvslmJBqeHUHUj4b1lY2flzyYhp3yKMQNGBbdQLzCdQYE0goOntsEGw 1Qhl5l2rmoBDQ8nc/m7b45hBCN1jdGqhOxA/Fawm/8kaGud4NTSlCYtCa liu2Tq906YFRTzctG3gPZyTKKa8ZVvb0dRzvGwRc2xkCTfMHMkcuZVwb2 N0DGPwPwPS3mBH0tTQle/XFddgEAJ83u7GgwdT1rKqi5nyTQfLUPC2NvX ioW0pcYjdqt6/eFx9gMD6MIxw9XgjzV4FHIVEvGSaag4H1AbQJoo2mITb w==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="271144655" X-IronPort-AV: E=Sophos;i="5.93,223,1654585200"; d="scan'208";a="271144655" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 22:39:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,223,1654585200"; d="scan'208";a="555213728" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 08 Aug 2022 22:39:53 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 22:39:53 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 22:39:53 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 8 Aug 2022 22:39:53 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Mon, 8 Aug 2022 22:39:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oaeTAah+qtZh+/QuAkS5BCRI+rkFSZcZUYYOoSBtHB1YmsProiPvYzQR2NfbLakb3c5xhWiProKnzj6n6Fvr7hF7TXb5DHmmlTYp7ZQSoX/uO1HtpFw/lHsHqja1P7+VF00oHAbOjKZ1bi6iB0SYMqI9u4cta2kQJfUz+yKJlX806xTGBvXqgnExj6HVqU2hfWLJ0M4K32AT0xRf/4tcWSlaL/jMsXolYQ+uIflq/Jwsdt/Jqlj9Ejz6vcvyCRCqNGriEzWZLrbAS+ouiX9HT3CgcyKDeU3xLjKlh7i2yV/D3H3MDsTVMV7Iqs2rZ+0FHOZXLJFNK3iUOrPomCX36A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jdMUH9eb5Ev1kiBRe8zBSV5s4PTR20gV3aPDdVg/4eE=; b=Zw45CJJLkZI6DhsGXDnsRZMyhWuSKI/gloy/FSBNdprz4LaNcCEcRO/V8LXK2GnmQ018VTzhzl/mcODNrxPMFybsiuOfiKWz7rY870gg017RVsT5AremxT0nVwJ7AR9MkCkCRGqKNbIl2BOK3Zb+odA+qyh7yUVL3R0DmnWrZBMW8zb89HrEs5OmoVzxvKdpZhEITaU/IWEeK7N7hIreCTvgE0COuk10O8isUHzvymErNQjSG19FojUnJWzlM2WIdxen6c9Qarok8Vcjg5mSY8wCdPONSt7S3/hjNRgCVSfnsyldTd+1iWhAIUWLEFOupRNUVBbNle7RTBOj4M+k4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MW3PR11MB4617.namprd11.prod.outlook.com (2603:10b6:303:59::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Tue, 9 Aug 2022 05:39:51 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5504.020; Tue, 9 Aug 2022 05:39:50 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_decode: add missing flag when picking best pixel format Thread-Index: AQHYqYBBjXFozoZDGUOURqPKzpDcda2mEeCA Date: Tue, 9 Aug 2022 05:39:50 +0000 Message-ID: References: <20220806032754.71419-1-philipl@overt.org> <20220806032754.71419-2-philipl@overt.org> In-Reply-To: <20220806032754.71419-2-philipl@overt.org> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c29a3f6-3c92-4b06-a2ec-08da79c99432 x-ms-traffictypediagnostic: MW3PR11MB4617:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 11lRV5LQYJ9ALz4z7kuNyBb1PFfmFa4XXLiAHgEOV/dQRVrEGzuvQcv5NqBkGVUs6tAt8llIEOrKY12VHBg3m78SpH5tX/5vrMtTdxSFYJ5+iRgqnYfhW/PMclCqiP7TFHsQrypSz2BaEQ+u5wA7cLkyWpH51o5A4Sod/Dw0xQ4U85bFDVZOxWAKCeWP8tAaC5pWbzNEN3bUtUf/znlwhpNx7cMmpn7TskOaMbhD6rm+mM/DkSYKZDCKkEmeJhM0TJNwh45cwpIBfce/Tw1jsDhzYySEHDdOpEmppk25o/NbhhuI+W578FISqSwiIGrFT2vRGq1DrIz3wck7lGS07WBBQ6LwZbN26OdyULrVvJjYjhs3NMM0ZZiQer+LUUONDxQWcH7A2lohFE1YjoEBQp7NCK2ZZSZtd6pKXj6mWvapl742nO+6Zagwkrx5M8Nuz02c1wd7OuSRgM5S9eQSd3R4l6fhOpll/ubpTfqPdlwEKIGhaUR+EHblXmhl8eHOm/QB0UyLHMxJH7CbbG9tz1yTw4WLH+Egh87iEzBVByPSUJsKw7wslajpwjUDPNeiU9sUWcR7u+Gzo6aHecIBcP9UIMhemthKaLPzThlXcpSQWkda+q4oNzI0KHdaEq1zBpkn8y5wMGiqekLf3py+xFK1O2wIy5Seyyh3BcXbq4Nk/JEX8VJFw8+6hdowJazww21hoG9imZX9qwcGylmipXBd8jnAcO2gORTKkBTPmRcoo8Neur7T2YI34YpZXBHgvJKqE9JuU2E0uLZlpkpjeUQPGssV+RTQK7qOItNuNVmXfwAU7i6P/BtbskJ2MA22gqvcHGfTfvVJqvag9Ep8OQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(39860400002)(366004)(396003)(346002)(136003)(38100700002)(2906002)(86362001)(38070700005)(66446008)(66476007)(82960400001)(64756008)(66556008)(66946007)(8676002)(76116006)(4326008)(6512007)(6506007)(26005)(478600001)(6916009)(6486002)(316002)(91956017)(71200400001)(41300700001)(36756003)(186003)(122000001)(2616005)(5660300002)(8936002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OUlCeWVESEYxc3hhNHQ3ck43eGRYYUhLd1RhYzREQ04xbUErWG9zSzRabUh5?= =?utf-8?B?ekUvSEtZTGlRdXpjcEpJSG16YWc2aUhydVViZWJaaTgzZU4rNmlIVWxYdTV6?= =?utf-8?B?c3BTdHZlZUErSzRNUXRqYVB2TFVEUi81L29odUJncUNrOHlGSEpGY3NLTUE0?= =?utf-8?B?WG1JV1kyWXlqd2ZldnJuVTAwZDJYZ1d5RFpMcXJFUzY2T2NsOVg1VTJSeFp3?= =?utf-8?B?enNnUXhnYlk1UHlTZjJSWG1OZVpNb1lobUFtazhoK29Ud1pSQlhtdFdyUkp6?= =?utf-8?B?QllJWVkvZjNjZlRuaURIaEhVTVFYSXI3SGxNYUtQNlJBMUpWa1lIZCtNOGQv?= =?utf-8?B?NmhmZEUyWEN5cHhDSnN1Yk9FbTNNOTkzT0hlNmRkakRMQWdYUVNGQVNwZHRY?= =?utf-8?B?LzRGL2xjK0NqOEc3NjNudlpKVEZHTVlGd0VNS2UvcVYwMVF3VFFvc2hrZ1ps?= =?utf-8?B?dWlHb3VIbTdlOHE2cDRnQ0NQK2ZDeXk5MjBwUnpqUEdNeG5Da0ZGcEs5U215?= =?utf-8?B?dm1qakJVYmMyNUhkSFNlWFVPY0tYYklxWTJhek5aR1MrV0w2K3k0MkxBSDBh?= =?utf-8?B?SmxDUW9QQjJRZEFUd0txdTAycExKQ2E1S2hUdWdodTZxVlpVaTYvaXNLZ2kr?= =?utf-8?B?MmY5aDRRaUVCS3dVQXlsR2s0cys5ZG5pekRVQ0swN1dYNDZaVXNmR3FBd2Ew?= =?utf-8?B?NjcybnF2NGFqQ0tqbnYzSVJGMndvZHJNeS91UmVwSVYwdDZRbUFDM3JtZzdt?= =?utf-8?B?N1R0bVIyUDF2cXJPaUhpdHlYRHRFODVtTkdWbi93YllKMGs2V3MvL0VXYjFO?= =?utf-8?B?eE5mTFFZVEVMQ0hIYkdsM2IvSHh3bzlOaU84SDhsUkNYeWQ3QXFwSE8vcVZj?= =?utf-8?B?UUtJakgxbEdvRXpveGd4VHloTU5mMUdTaVdEZnB3bWZFMEwyNXVNaS8zczlZ?= =?utf-8?B?cGZ5OEJlVExQRDBQSUxNc01UOVNyZ29DVWN4ZHZTZ2NENllUTHZTbnZpLzZP?= =?utf-8?B?RU4way9adHAxUCtNd0gxOTlmWWIxdWRmQ2tLMEpEOXNyVWE5Y3lKV3lrR3Vx?= =?utf-8?B?UVp6MkdidG9yanc2dW4rMUQ3aGRSWVFGY2R4cmhRRkxBZC83RlBKS0pmbE13?= =?utf-8?B?QXlObnl4cGhsL1NRUERBY05Jb0hHNUpxSWlTdWtzUjJCNWpxOVkvWGZQWENK?= =?utf-8?B?QXpubWxMN2tzREF1R2ZDcC82MHlJREhXZHMraTJTUDRlMWJWdVJEZkxRb2VV?= =?utf-8?B?VDF2Tk1EL01jR1pUem1MQnFYTzJwR1FzL24yMEtkUGEzQ2xyc0NpcDJMeTVX?= =?utf-8?B?WFNuWUlUaFZGQWVKdWVqTGhELzNMZStDcWJxamFqcmZuNlE4aTRrUFZWS2dP?= =?utf-8?B?ZnJRWmRORkV0VU1ZdHVpUlhSV3VteVRtRmRGbHhVb1p1WjkvTDgvMXBxZkta?= =?utf-8?B?dGljMEViYlRENEU5KzQwZkxyYXFNVnRJdEJHZmE1NzVXK05RTk1vdUVwbGJF?= =?utf-8?B?Yzh2am9IZnJpczA4dUNqTHpjQitTNEpXK0FBcEoxR2RnMis1WVFjc3phNHM1?= =?utf-8?B?azE4SHYwemRNZXU4U3FRQ0N3dTExM2xVdVJoSXJSWEhGakNuZm5XazNSbm9W?= =?utf-8?B?S0FUWE5XSThUVFlBRnZHeC9abjdmdzF1R21qYnAwd3VOSFAyZ0VySHI1ckM0?= =?utf-8?B?em9WaHB4a2gybWlDR2R5UlcxSCtMK1pJZGlJdXU3Zlp0Sk5KWXhmWjNhY2RE?= =?utf-8?B?Y2dtb0ZvaGwxYXpGZ3ZCV2FNKzFrRkFFZXBlMDYzTWV1aWorZy9XRGRBeE9z?= =?utf-8?B?NG9wZ3pLQTg0OHF6dm5CYVlVdVhmZWMwNjNZWHM3b24wN3EvMlh3VzhXMlp3?= =?utf-8?B?Z1czZm9HTWZQc3J0V243aVlQbmZQb1c3L2V6M05SYXRBY2wvR09ja2dzbmdW?= =?utf-8?B?NDJNRHRmZjIrbVpzbFJybmQ2elh0c251UmFsQzRNbFpzQVlBb0lSSjBkMEpj?= =?utf-8?B?elB0NXZPcEgwVzU4ajY3USthc29DUDBxWUJYRFFPRHBtT1g1bHBURDh0cjRt?= =?utf-8?B?VmVzSlpCdXVlK2E5WVkwaE5hTm5XeXluWG42NEMzdlc1TFZTaGs2MTU5UmtQ?= =?utf-8?B?ZnVNL0lBL1hoc0d0cWFxeXhVWEtlY1lJZVhNakdEek1MYW0xWFRXRkFOZ2Ex?= =?utf-8?B?SXc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c29a3f6-3c92-4b06-a2ec-08da79c99432 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2022 05:39:50.7767 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7FclJeDuCAZHArvav2cL23h3cZruc5Qnu8UXbU0VWXSFc6LQZTKV2yo/dBBY2HgUo4iGZW5ZiNFLxg5wBkSxKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4617 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_decode: add missing flag when picking best pixel format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "philipl@overt.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2022-08-05 at 20:27 -0700, Philip Langdale wrote: > vaapi_decode_find_best_format currently does not set the > VA_SURFACE_ATTRIB_SETTABLE flag on the pixel format attribute that it > returns. > > Without this flag, the attribute will be ignored by vaCreateSurfaces, > meaning that the driver's default logic for picking a pixel format will > kick in. > > So far, this hasn't produced visible problems, but when trying to > decode 4:4:4 content, at least on Intel, the driver will pick the > 444P planar format, even though the decoder can only return the AYUV > packed format. > > The hwcontext_vaapi code that sets surface attributes when picking > formats does not have this bug. > > Applications may use their own logic for finding the best format, and > so may not hit this bug. eg: mpv is unaffected. > > Signed-off-by: Philip Langdale > --- > libavcodec/vaapi_decode.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index db48efc3ed..bc2d3ed803 100644 > --- a/libavcodec/vaapi_decode.c > +++ b/libavcodec/vaapi_decode.c > @@ -358,6 +358,8 @@ static int vaapi_decode_find_best_format(AVCodecContext > *avctx, > > ctx->pixel_format_attribute = (VASurfaceAttrib) { > .type = VASurfaceAttribPixelFormat, > + .flags = VA_SURFACE_ATTRIB_SETTABLE, > + .value.type = VAGenericValueTypeInteger, > .value.value.i = best_fourcc, > }; LGTM, thx -Haihao > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".