From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 10E0F43574 for ; Mon, 18 Jul 2022 09:09:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CEB8F68B803; Mon, 18 Jul 2022 12:09:36 +0300 (EEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F2FC768B501 for ; Mon, 18 Jul 2022 12:09:29 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658135375; x=1689671375; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=NhTi49H/uxQQVwKIZm+uw3VU8tv2M7f8LZ1bruWCv3c=; b=UMuKpdfovg76T8l2zUDTIblsvfb9s+/xfcNe/BHf38d5cKAEtse0e1qI WhJ/2LXp8RjC4mjzpy5pw1ztd1ejGJPh4WPX1WjDPpfGgkZ8pvoqVRQui wbe8Hh6jUX6DqsgNKYwWZ8a2dwWBBPp9//Kt3GdeGx9ZgOH3zo9a92n5Z A95yGXt8dQtWASb6iGBOBk5Aua9OEXWQMdcjM8y1nO0k4WCsDaAdTf8pb WnVjcEUARJg3hqLlqNW2oq47bwxFlsaGvJAOaoFg2qg9vwXcIb6ZhG1dq 8h7mO1HrTmsqFuHJflu/pt5Bwj3OFsdx8ozzDjd44kyBl1JY1Od5lG3R9 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10411"; a="283740813" X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="283740813" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 02:09:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="572327229" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 18 Jul 2022 02:09:25 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Jul 2022 02:09:25 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Jul 2022 02:09:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 18 Jul 2022 02:09:24 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 18 Jul 2022 02:09:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m80BM5+t6USA/LewxqcI7XBqfln2xYIfdKsciM3jk/Fj9uLvPuefyQYhWGT0FVQUArnmjUq9lKGaLMW92FLkU1pzPBXFN7kPYhusu/tZILOm6JbFy0BaAkei7g6HBjA+PirmPzK9s144yFamlQ5LVsS6z/iQ3mrjvpbJq4FFavBdamDh/vBYZ6+q7j8S+CubJJpMrgWRrb+lv5DGYWG7NWilNZyWRTiGD7bZX8d19ltueDsCBAtTgV3+1Lpp1O5+zXAaUffkQF7sUZBjrPd0U0VNyX1nl1SIuKmljoB4AXJANgObZPKt44DaJWo8R1e1OBaaLwP3jGNBEtaqsbRZrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NhTi49H/uxQQVwKIZm+uw3VU8tv2M7f8LZ1bruWCv3c=; b=BUO27onN1rFJoMPJn5HcoSer2jGQiagOFsF4PuxA86oBIIz6SObTdA0zh5fcip8A6fNu6h38DN+ZSZO5zLwxyj8n9fz7d8FjXXxjGgzOE9wY8yEewizL6lHpR0LCK/Igq9lhZLB6eLXFzoxwzlzKmht+3ncRCpRwaUzO5njP/t7s9/ZZJzuZlvdtIhjt7NMeoQnOC+BBbAnXur1cbYjT/Lw89i0ZpRNUjhwjVo8ttNKOOfLFKx/pTK3/dw0VRzIROYaHJVNC6pcAD7t9XuYu9VJvb9MFVvYKcS5iCQsMfFGc6VqcTIDsPFtUxcohJe6UlT/NcJQDbiH0/Dsnx16v0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MWHPR1101MB2175.namprd11.prod.outlook.com (2603:10b6:301:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Mon, 18 Jul 2022 09:09:22 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 09:09:22 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v3 1/4] lavc/hevc_refs: fix dpb logical for IRAP Thread-Index: AQHYmAj1tnPPduKrdU+BYVl4nKy9R62D3BCA Date: Mon, 18 Jul 2022 09:09:22 +0000 Message-ID: References: <20220715050644.879488-1-fei.w.wang@intel.com> In-Reply-To: <20220715050644.879488-1-fei.w.wang@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf2eb51f-b55f-459f-f05b-08da689d346f x-ms-traffictypediagnostic: MWHPR1101MB2175:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k1aX3XuSw+A9upIf5GRt7B7iHNzZBw7y/S9w4tgAlbWawCfJXebuXKaLCvPRdrS57zRp+U1hLRyEFoma3uteGG9gYcZNumHPZnMC4GcdX/2Gxa7P4C4gEojFWWz3JLdQvUC/giubynpYUJt550AEfy7OYm5MZOxdxg6bWOUHoPnqIM2j6Q0ky2QhT8yIEAeiiFPocO/Qar2HEib2OvDatMdt7KdI3pCEh3wfCc8ALWD9Wsh0xfNfpgSo+fCHqScftT75YpQi6muASB+xMXaKp+4g1SrPVOBr5D+8p6FbuMSAj6MlHsfv9PTcCJHpYJuLAWpuPD2BeCBY9xACTA382yVXv6/cXknsbpwnBYiUqQE+Owm1EHTdV+nQfoXFyhKhRuUQGPV7nPLYZ9kR/wASeaNbGJQf0JDZ39uQz0Dr6UwuzoVa/dZ3/ZwTGawVCMhjZbFzL9APsHAxWwQino7z04t4P5htXzOjn/CDlmwvK/VQeistG0rxo2BpuUAxVjXXEjFvq73k2vwpDhIDodI1ybT8BYGBW7Pm3nISmWkxPAHLdaeUzJZ/wFeQ3Aq17Oc9zD/hhER8712ZbgELClosiLh94X3MepSEiREbpCPQMxJLEd7B4kOS7UgWhyRAw3MTynbi+5ZGXdxKTB8pjlJz3j5jtvXdCy64j9bMVtOC6em1PXbaC9im+tKDqA/Y7mKWI1jyoqR8LgU92CAI4RCLUceCk1ulDaoLONKCvo0tSkaap5i7PQiJRPMauoOnO7ZF/OkYt3wj8IgCFWZjKSyK8siJLbf6xc6+2ga5FJ7zrlUq/HwihNy27ibnSopjTCa0G0Y/GUZ6VjX0Ej11An99rg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(376002)(366004)(39860400002)(136003)(346002)(64756008)(66446008)(82960400001)(8676002)(4326008)(66476007)(91956017)(66946007)(38100700002)(5660300002)(66556008)(76116006)(2616005)(107886003)(86362001)(8936002)(83380400001)(478600001)(186003)(6916009)(6486002)(6506007)(41300700001)(122000001)(316002)(6512007)(54906003)(71200400001)(38070700005)(26005)(36756003)(2906002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YTg0Y2ozNkZPSzErbk1zTjg2ZEsyV3dOS3pkMzhiTEhWUzF5TmJpMmhZUlR6?= =?utf-8?B?QUVWRjNyWHV0QzhPL2hEU2JLKzdVT3Q3L2E2T09WQjg0RGlERWh2UVQ5aTdo?= =?utf-8?B?aDJxTC92bS9WbmJ6K0srY0E2UCs2Q0hpeG41eWVaK2VJOS9kSlBXWm52T0pp?= =?utf-8?B?Y1AyMUxQbXlwN2tiK1JmT3BPcmZpUmg2ekhIUUU1Tm5iOGNiTGQ2VDdPek1U?= =?utf-8?B?Tkw4OTl6OVgweTRaUWIwb0orRGdYdjc2WjBoemQyVDN1ajlLTCtUZGNrSEhX?= =?utf-8?B?VjNkUnBQcmp0eHRjODhJemM0YVhVRSs1VHJIWHIxVk9xd2VCVUoxdGgwbUJH?= =?utf-8?B?NFpiazFBcU5YdXM2YjNpWlBZTXBaKzBSSVlpWnU3SGJvOFJONnJRZmtTdVNJ?= =?utf-8?B?UFBYOVdPNE1pYXBQQkh6TkRuTWpFTWJxdThVU0Q0eFJ1YXlNeHlWRndOaXFW?= =?utf-8?B?ZW9PNEVnaXJWMGQxd0NSU0NHZ0FWQTVhQldLV3hxdjdNYWxGZmpwQVlZRFM5?= =?utf-8?B?L3g0ak50Y3U5SHhxS0REOVVSMm1mVTFnMTNqNW5jSmgramFncGllQUxMNHpu?= =?utf-8?B?Sk53akcveGZLbG0xTUx3eElldnJ6dXl3VmJDaEJuS3hPdUhZRGttL052MWxQ?= =?utf-8?B?alc0czIxWG45MVdZOFh0aW9Sc01rMy83M05XNnQxS3dUL0tRUGFLSGgyYndp?= =?utf-8?B?N25SU2VGM0xJOGlKU2VoUDI3RmRjQnU2YnFjMEpEUzc5NU9PSyt1NFB3R2tq?= =?utf-8?B?Vkpvd0JrRlQ5NnhSVStLK0VYMG1SN1JBUDRoWXVWemNoMTNwWUVRcFhCNXk2?= =?utf-8?B?UlBkNW5yL1N1V1NSb3VuK2JpWUNEWmk3WjNVNllKN1BQczZRZnp1UlhpL0hT?= =?utf-8?B?STRaUytXSzl4NXNBL0RyUFp4ZVBFeGFzclBUY2k5Z0orNW9kdG45T0hNRlBj?= =?utf-8?B?T3JSUy9KbnNteGkyb1ZsNnkvcFY4SWhtcUxwUUNyYnFGQ1ErUHZad3JzYnYx?= =?utf-8?B?dG1FQU96NDRNZ0JVSWpjVU5jWjk5L2RaM0JKT1pSSUROVTdKenU4OEhERTF0?= =?utf-8?B?NmpieWgwSnBIUCs1QU9GUkRCQzUzREQyc2Z6NUhyRjh4a2lZc0lxWm1pSmor?= =?utf-8?B?RTBmYTd3VHNPT0NXTEhpeG1icE1ESVlDU0RyVlpGRkVBUkYvVENsVlVQcmJI?= =?utf-8?B?NnBGaEwzU1VxTVFKNjhTNmo2azMrb2toSnR5NzBBN3NPYUtWV0puYUUxeGVK?= =?utf-8?B?aDBTZ0ExREdnTWVVd2h3UWk5dS9tTVd0amE4OVpCNjQyTmZBNVduUG41Njdi?= =?utf-8?B?NmpmMzBPRm9TRWdzUlUxeW1JTHlxNSs0eDMxNnVNekRSWnJ4SnF0cU9PTHlS?= =?utf-8?B?c01vZmIyODZXTEloM0RsZ1cxd2dITUZFeitDMlFhem9OUFF6cHRkcGIyeDBt?= =?utf-8?B?OG9MV1lhU1R6RlUxQ2NFWk5nalhvTExMOHNGV1BEM0MyQUU1Rlg5SmxNblZh?= =?utf-8?B?enBwTlZ5RmVYR1c0TUY2bGhEenFLVEhtRnQ4TXJrRjdxZnV5UDdyQ0Z3WHYy?= =?utf-8?B?cGcxanhxTE1va1RpL1BEREZpMjNpK2JUTmJheW9YdXJoSUoxUWg1Q1ZJNlNP?= =?utf-8?B?a25jMEJUc0hoT3JVRldHWnJrOVVsdlJIdExibmh1b05md1Y0K0VqZmpHaE43?= =?utf-8?B?WXYwb0pwL3NZbGUvNk5HM1JhMExBUmFMNmVKQk50RGtoVThzeC9GSW5jSU5E?= =?utf-8?B?Q1pwNzZKdElTczE5b1M2eVpzcHcxRDhzQVNwUmZIeXdKSlB5bG5qeFpsa01K?= =?utf-8?B?WWE5REYvWXcwbVhsdHFtNnFoRG9pRnhxRDBSWXJkVEhwcU43b1k0TG82cTY0?= =?utf-8?B?K2pMNDNYS1JqemovQk96NE9XU3JNWnh3UjFVY0lsclBHNWVtbnJGQkdPcG9C?= =?utf-8?B?YTB5QnV2WnNNck9HQUVBL0FKaW04czJhdEFqc3JyYWV1ZVVpc2dhYjlrRjJT?= =?utf-8?B?aENPNXFjZk56ZDRIRDJ6emZBQ1BkWWwxMXZtUytFWmc3b21yNDdmMFFzdnFl?= =?utf-8?B?ZkpwOFVzZ2ZlN214RFlZdGlzVStyVHJzdlhad2ZUWHhFNytXdmNLaXZ4aERt?= =?utf-8?B?R1RmS0FCVU55ZjlEblZudUc4N1RhY0xvaFJTcllhSGgzalNpMjBSdVFNQlFF?= =?utf-8?B?ZWc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf2eb51f-b55f-459f-f05b-08da689d346f X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 09:09:22.5095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hIgKuvax42x3QUiOs6VTc+raOOwmVI4aSFXpUlLIci7DYvgZpkKP8c5+gRFvfNF0kl1LiiphuO6NEauTlUPIMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2175 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3 1/4] lavc/hevc_refs: fix dpb logical for IRAP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xu, Guangxin" , "Wang, Fei W" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2022-07-15 at 13:06 +0800, Fei Wang wrote: > From: Xu Guangxin > > According to C.5.2.2, item 2. When we got an IRAP, and the > NoOutputOfPriorPicsFlag = 0, we need bump all outputable frames. > > Tested-by: Fei Wang > Signed-off-by: Xu Guangxin > --- > update: > 1. clean and replace 0xff with HEVC_SEQUENCE_COUNTER_MASK > > libavcodec/hevc_refs.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/libavcodec/hevc_refs.c b/libavcodec/hevc_refs.c > index 6a70c817b0..2b0468d6c4 100644 > --- a/libavcodec/hevc_refs.c > +++ b/libavcodec/hevc_refs.c > @@ -175,21 +175,24 @@ int ff_hevc_set_new_ref(HEVCContext *s, AVFrame **frame, > int poc) > > int ff_hevc_output_frame(HEVCContext *s, AVFrame *out, int flush) > { > + if (IS_IRAP(s) && s->no_rasl_output_flag == 1) { > + const static int mask = HEVC_FRAME_FLAG_BUMPING | > HEVC_FRAME_FLAG_OUTPUT; > + for (int i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > + HEVCFrame *frame = &s->DPB[i]; > + if ((frame->flags & mask) == HEVC_FRAME_FLAG_OUTPUT && > + frame->sequence != s->seq_decode) { > + if (s->sh.no_output_of_prior_pics_flag == 1) > + ff_hevc_unref_frame(s, frame, HEVC_FRAME_FLAG_OUTPUT); > + else > + frame->flags |= HEVC_FRAME_FLAG_BUMPING; > + } > + } > + } > do { > int nb_output = 0; > int min_poc = INT_MAX; > int i, min_idx, ret; > > - if (s->sh.no_output_of_prior_pics_flag == 1 && s->no_rasl_output_flag > == 1) { > - for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > - HEVCFrame *frame = &s->DPB[i]; > - if (!(frame->flags & HEVC_FRAME_FLAG_BUMPING) && frame->poc > != s->poc && > - frame->sequence == s->seq_output) { > - ff_hevc_unref_frame(s, frame, HEVC_FRAME_FLAG_OUTPUT); > - } > - } > - } > - > for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > HEVCFrame *frame = &s->DPB[i]; > if ((frame->flags & HEVC_FRAME_FLAG_OUTPUT) && Patchset LGTM. -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".