From: Ramiro Polla <ramiro.polla@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] Misc mpegvideo patches
Date: Tue, 4 Mar 2025 23:08:00 +0100
Message-ID: <e32a7e46-d597-4c7b-8d85-b79517fd6f0a@gmail.com> (raw)
In-Reply-To: <AS8P250MB0744DA6EDBF49052893B94F08FC82@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On 3/4/25 22:06, Andreas Rheinhardt wrote:
> I added a comment to #10 and modified #18 as described. I also changed
> #21 to protect the macro in parentheses and simplified the FF_RC_OFFSET
> macro in #31. Furthermore, there are now five more patches. All
> attached. https://github.com/mkver/FFmpeg/tree/mpegvideo_misc has been
> force-pushed.
> Subject: [PATCH 24/45] avcodec/mpegvideo_enc: Factor checks out of loop
>
> Also move this code to handle_matrices().
handle_matrices() -> init_matrices()
> Subject: [PATCH 44/45] avcodec/mjpegenc: Constify parent ctx in encode_block()
>
> Said parent is shared between all slice contexts and encode_block()
> can be run concurrently by slice threads, so the parent context
> must not (and is not) be modified. So constify the pointers.
"most not be (and is not) modified."
No more comments from me.
Thank you for all this cleanup work, it is really appreciated!
Ramiro
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-03-04 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 13:42 Andreas Rheinhardt
2025-03-04 16:30 ` Ramiro Polla
2025-03-04 17:04 ` Andreas Rheinhardt
2025-03-04 18:39 ` Ramiro Polla
2025-03-04 21:06 ` Andreas Rheinhardt
2025-03-04 22:08 ` Ramiro Polla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e32a7e46-d597-4c7b-8d85-b79517fd6f0a@gmail.com \
--to=ramiro.polla@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git