From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1D83C44DBC for ; Mon, 26 Dec 2022 14:11:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7986468BA1C; Mon, 26 Dec 2022 16:11:15 +0200 (EET) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3253C68B75F for ; Mon, 26 Dec 2022 16:11:09 +0200 (EET) Received: by mail-oi1-f172.google.com with SMTP id v70so10329555oie.3 for ; Mon, 26 Dec 2022 06:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=1aRew416CzA3+TWwVvPPI+yWVAzMQbFREUE5YI1uxE8=; b=p7xaFfzCvhABvysESH9zeQyw6rH52phyH7Tsj4kcz+UCPO9JAdZK9f3chUU2uvboih EfWPPj5N7vKrctQfCxPFUmRx66UkAb+yZumfrnYTVI8bv16Lph4OABin+5PsddOO94mc 5O3YF3dHkmyxxlTGLGtyv2lDTKlQ8dFFL6vRDzE88p9plgWfATnNgurMg8cfv4JGU6bR 5+TD/m0utfPXdqO/QLMymX2c8aZsfvKdhX4oixarBbEq2dkZeENg2xbRYOL+i+h/E83e o/D4Pm2g5cb53iruohCUn9ZL2HZGq3rbL+tCzSpSPsNf7ktUl8VbXd+PBUPbj3cdfrtT TRYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1aRew416CzA3+TWwVvPPI+yWVAzMQbFREUE5YI1uxE8=; b=VFJuX14b+3O9ttb0Mf3V7dEvs9VoEOdjfiWTjbyDRGKdid8hXD724AxFBJC1XU9Gka C2vcFTX92iWVE7nUHA4yzbZh/fpc4sIeH5a4SpEDgBT+IGwC/w/TMhOpAqYugpBnnRe8 IdbWEHp3DqwuOd50R75srcHciYAMdZsjjE/dzugg3NXkZLi5hq25tIyK/7FKxS0nTuLd Z311oBTwRqj5xWa1eOJkWxYGRtizo/WHEMVuyavErQk/GxNKrt1QtwpDJWBqrCxXgKxR XhJdg969wVc8QeZoPnddcj4qUbY4VnASVJGQXZRb862NsRCfkZUdJY2XJZSjshjbQwkD IL7g== X-Gm-Message-State: AFqh2kopsRXAzBUp7xjBG163BlgymLyAnl5KMRF1XgNFWcYWTaSkoh/C y2vaOF4OykF3HEVMMkaOj/iLu2waglE= X-Google-Smtp-Source: AMrXdXtCHbS7SajNQO/6YOp555W6V5s1QEznHWguHtdQDhDTY2E0oJ+zfPgaV4HVktvNZvQFOPOoqQ== X-Received: by 2002:a05:6808:1388:b0:35f:4055:dd96 with SMTP id c8-20020a056808138800b0035f4055dd96mr12198282oiw.8.1672063867181; Mon, 26 Dec 2022 06:11:07 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id e9-20020a544f09000000b0035aa617156bsm4845140oiy.17.2022.12.26.06.11.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Dec 2022 06:11:06 -0800 (PST) Message-ID: Date: Mon, 26 Dec 2022 11:11:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: ffmpeg-devel@ffmpeg.org References: <20221225220323.20968-1-michael@niedermayer.cc> <20221225220323.20968-2-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20221225220323.20968-2-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Use 64bit in remainder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/25/2022 7:03 PM, Michael Niedermayer wrote: > Fixes: signed integer overflow: 48000 * 223587 cannot be represented in type 'int' > Fixes: 54513/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5817594836025344 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index e6118e141d..6150c131ec 100644 > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -3857,8 +3857,8 @@ static int64_t mxf_compute_sample_count(MXFContext *mxf, AVStream *st, > if ((sample_rate.num / sample_rate.den) == 48000) { > return av_rescale_q(edit_unit, sample_rate, track->edit_rate); > } else { > - int remainder = (sample_rate.num * time_base.num) % > - (time_base.den * sample_rate.den); > + int64_t remainder = (sample_rate.num * (int64_t)time_base.num) % > + (time_base.den * (int64_t)sample_rate.den); Don't undo the vertical alignment, please. > if (remainder) > av_log(mxf->fc, AV_LOG_WARNING, > "seeking detected on stream #%d with time base (%d/%d) and " _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".