From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 287A945219 for ; Fri, 13 Jan 2023 11:36:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D79568B71D; Fri, 13 Jan 2023 13:36:33 +0200 (EET) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44C3968B14C for ; Fri, 13 Jan 2023 13:36:27 +0200 (EET) Received: by mail-ot1-f48.google.com with SMTP id v15-20020a9d69cf000000b006709b5a534aso12098893oto.11 for ; Fri, 13 Jan 2023 03:36:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=617+V3mku9Cm5kx2zo/zFfMAJS0wpAz572GvvtSMKLE=; b=Mz6woSOdOZKUvd5jvrqp+e4EZq4fGp0A0zGL0BK2rxCHD3B6A5CK0QQLazB+LEzPNj 7s9nCKZqmPtthQfNJ/PKlWMqecKJjQ8glpbyNbJsX18qaVb4vfkJGh68ni5tayFhmFlb rW2OgFJ8uBMb4Cb90pFwpdg/x0z0+Xu8k/XUDGJxmArrkz+55LDpK3bMKpaIfHKl2UjW 1rPvnXU+pJNtE1tfjLieQlbt9O1GAe54oxjP5bmW6tLDI2r5Sq2bvNwzMZBTG79VEovg tIvpXD9bm5LnW0R6fBZ3aZ5obYcsvstUeiwezmWYprqXDb9FlTt6UeWxVqmgP1c1SkUm QOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=617+V3mku9Cm5kx2zo/zFfMAJS0wpAz572GvvtSMKLE=; b=744vy0UL2JBm9iK1sgkJ6rEFBPVVGVh8AJRLMgw19SChgdNSaiTiO3aiCIrhUfchHM Deh4IkxxzJ9UwtWDbbIutpLne5cNpY4gmsL2sWjdLTI6kaswoFXwKBqkbtBuuuIIrVm4 L05FwC8Vj7MEpdS++/JZFrmPX7dc8Rtc8gPvg7dmjMR1raeNzBOtSVzEx3Q3jRbQjrId pOBqxvcnPGwLOavLtqkgvyfaSjymYZQUUgOBX4CXfSxyg7p9cC3Ysr065XvZBUW5maRF wykJeioWi/KzmzF/eE40Yb1iRo8R9pZxB+2P1hvjb0F0MEKFJgalmxjQaYUxoizCuZDT KWKw== X-Gm-Message-State: AFqh2krTWk44qbQiNMaNUie3AoVzAnoU1BP5Gj9ZIkIA4hrVhj73er8N oq0Hw9b/gs96Wg/62db6KVqnagy4JT4= X-Google-Smtp-Source: AMrXdXsK2eMP1PA3H0bIumwx0zUoeMHEizg2NLY+dsptmHC4LpFCnYwJL2GAkYI0/zPD7LQM9NWbSg== X-Received: by 2002:a9d:6317:0:b0:670:8b28:14b4 with SMTP id q23-20020a9d6317000000b006708b2814b4mr42136071otk.8.1673609785441; Fri, 13 Jan 2023 03:36:25 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id s24-20020a056830125800b00684074fbce6sm10166116otp.54.2023.01.13.03.36.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jan 2023 03:36:24 -0800 (PST) Message-ID: Date: Fri, 13 Jan 2023 08:36:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: ffmpeg-devel@ffmpeg.org References: <20230112222326.22018-1-jamrial@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ac3dec: don't export Matrix Encoding side data when no such info is coded X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/13/2023 4:09 AM, Andreas Rheinhardt wrote: > James Almer: >> No point inserting the side data to all frames just to say there's no >> coded matrix encoding. >> >> Signed-off-by: James Almer >> --- >> libavcodec/ac3dec.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c >> index 0b120e6140..7a84f3c85d 100644 >> --- a/libavcodec/ac3dec.c >> +++ b/libavcodec/ac3dec.c >> @@ -1819,7 +1819,8 @@ skip: >> break; >> } >> } >> - if ((ret = ff_side_data_update_matrix_encoding(frame, matrix_encoding)) < 0) >> + if (matrix_encoding != AV_MATRIX_ENCODING_NONE && >> + (ret = ff_side_data_update_matrix_encoding(frame, matrix_encoding)) < 0) >> return ret; >> >> /* AVDownmixInfo */ > > If the preceding frame had a nontrivial matrix encoding, will users > think that the matrix encoding from the last frame still persists? Yeah, i thought about it after i sent this when i was looking into ways to use this info in swr, so I'm withdrawing this patch (not the second). > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".