Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

[Michael Riedl <michael.riedl@nativewaves.com>]

> Hi Michael,
>
> I haven't tried your patch, but a quick review suggests that while
> you've declared the option as deprecated that it no longer works.
> Presumably somewhere in there should be a line of code that says
> something like "if (ctx->draw_bars == 0) then ctx->signal_loss_action
> = SIGNAL_LOSS_NONE"
>
> Even though the option is deprecated, it should still continue to work
> until it is completely removed.
>
> Devin


Hi Devin,

thank you for reviewing.

I just tested the code again and can confirm that the old option draw_bars still
works as intended (as describe in the table below). If the users explicitly uses
"-draw_bars false" then we set signal_loss_action to SIGNAL_LOSS_NONE (if the
option was not set by the user) and emit a deprecation warning to the user. If
the users leaves draw_bars to the default value, the option signal_loss_action
has priority.

I think this is the best solution for now that keeps the old behavior and allows
us to remove the option in the future.

| draw_bars      | signal_loss_action | new action     |
| -------------- | ------------------ | -------------- |
| true (default) | bars (default)     | bars           |
| true (default) | none               | none           |
| true (default) | repeat             | repeat         |
| false          | bars (default)     | none           |
| false          | none               | none           |
| false          | repeat             | conflict error |


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".