From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [RFC PATCH 2/4] avcodec/cbs_h2645: keep nal->nuh_layer_id > 0
Date: Thu, 5 Jan 2023 08:18:43 -0300
Message-ID: <e1db01f7-0649-02de-de5d-4bb9717a3f09@gmail.com> (raw)
In-Reply-To: <tencent_B8C075B70868EE03216BA67D8AAC6239810A@qq.com>
On 1/5/2023 1:14 PM, Zhao Zhili wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> libavcodec/cbs_h2645.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c
> index 4ee06003c3..b12abede29 100644
> --- a/libavcodec/cbs_h2645.c
> +++ b/libavcodec/cbs_h2645.c
> @@ -477,9 +477,6 @@ static int cbs_h2645_fragment_add_nals(CodedBitstreamContext *ctx,
> AVBufferRef *ref;
> size_t size = nal->size;
>
> - if (nal->nuh_layer_id > 0)
> - continue;
Have you tested samples with NALUs with a layer > 0? How does CBS handle
them in both reading and writing?
> -
> // Remove trailing zeroes.
> while (size > 0 && nal->data[size - 1] == 0)
> --size;
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-01-05 11:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230105161416.194463-1-quinkblack@foxmail.com>
2023-01-05 16:14 ` [FFmpeg-devel] [RFC PATCH 1/4] avcodec/hevc_parse: " Zhao Zhili
2023-01-05 16:14 ` [FFmpeg-devel] [RFC PATCH 2/4] avcodec/cbs_h2645: " Zhao Zhili
2023-01-05 11:18 ` James Almer [this message]
2023-01-05 12:06 ` "zhilizhao(赵志立)"
2023-01-05 16:14 ` [FFmpeg-devel] [RFC PATCH 3/4] avcodec/hevcdec: add nuh_layer_id option Zhao Zhili
2023-01-05 11:21 ` James Almer
2023-01-05 11:59 ` "zhilizhao(赵志立)"
2023-01-05 16:14 ` [FFmpeg-devel] [RFC PATCH 4/4] avcodec/h265_metadata_bsf: " Zhao Zhili
2023-01-05 21:48 ` Mark Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1db01f7-0649-02de-de5d-4bb9717a3f09@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git