From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 45ECE48344
	for <ffmpegdev@gitmailbox.com>; Tue, 28 Nov 2023 13:58:03 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23FBF68CF72;
	Tue, 28 Nov 2023 15:58:00 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C20A968CED6
 for <ffmpeg-devel@ffmpeg.org>; Tue, 28 Nov 2023 15:57:53 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 3ASDvqo1030553-3ASDvqo2030553;
 Tue, 28 Nov 2023 15:57:52 +0200
Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144])
 by mail9.parnet.fi (Postfix) with ESMTPS id DBDBBA1425;
 Tue, 28 Nov 2023 15:57:51 +0200 (EET)
Date: Tue, 28 Nov 2023 15:57:50 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: xufuji456 via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <tencent_6415A1936C8B9809466470816CA2BCCDE507@qq.com>
Message-ID: <e154274-eea-8838-3d13-bc85d794ebe0@martin.st>
References: <tencent_6415A1936C8B9809466470816CA2BCCDE507@qq.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevcdsp_qpel_neon: using movi.16b
 instead of movi.2d
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: xufuji456 <839789740@qq.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/e154274-eea-8838-3d13-bc85d794ebe0@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Hi,

On Wed, 15 Nov 2023, xufuji456 via ffmpeg-devel wrote:

> Building iOS platform with arm64, the compiler has a warning: 
> "instruction movi.2d with immediate #0 may not function correctly on 
> this CPU, converting to movi.16b"

The change is correct and something we should do. However since 
fb1b88af77cd39034cef4b6d08af79496cd75ed8, our asm.S starts with an ".arch" 
directive, and that silences this warning, so I wonder how you've run into 
it or tested it. (I presume you've run into it with an older version, then 
tried to find all cases of this instruction in the codebase and changed 
those?)

(This warning is something that only is triggered when building for iOS, 
not macOS, due to a bug in early iPhone CPUs - see 
https://github.com/llvm/llvm-project/commit/9097a07e4e83b9f394598d53557247277b064b09.)

Anyway, the change looks good, so I'll push it.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".