From: "Martin Storsjö" <martin@martin.st>
To: xufuji456 via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Cc: xufuji456 <839789740@qq.com>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevcdsp_qpel_neon: using movi.16b instead of movi.2d
Date: Tue, 28 Nov 2023 15:57:50 +0200 (EET)
Message-ID: <e154274-eea-8838-3d13-bc85d794ebe0@martin.st> (raw)
In-Reply-To: <tencent_6415A1936C8B9809466470816CA2BCCDE507@qq.com>
Hi,
On Wed, 15 Nov 2023, xufuji456 via ffmpeg-devel wrote:
> Building iOS platform with arm64, the compiler has a warning:
> "instruction movi.2d with immediate #0 may not function correctly on
> this CPU, converting to movi.16b"
The change is correct and something we should do. However since
fb1b88af77cd39034cef4b6d08af79496cd75ed8, our asm.S starts with an ".arch"
directive, and that silences this warning, so I wonder how you've run into
it or tested it. (I presume you've run into it with an older version, then
tried to find all cases of this instruction in the codebase and changed
those?)
(This warning is something that only is triggered when building for iOS,
not macOS, due to a bug in early iPhone CPUs - see
https://github.com/llvm/llvm-project/commit/9097a07e4e83b9f394598d53557247277b064b09.)
Anyway, the change looks good, so I'll push it.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-28 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 3:53 xufuji456 via ffmpeg-devel
2023-11-28 13:57 ` Martin Storsjö [this message]
2023-11-29 10:01 ` 徐福隆 via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e154274-eea-8838-3d13-bc85d794ebe0@martin.st \
--to=martin@martin.st \
--cc=839789740@qq.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git