From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/7 v4] avcodec: add an Immersive Audio Model and Formats frame split bsf
Date: Mon, 12 Feb 2024 13:51:54 -0300
Message-ID: <e0a44a45-4819-4f6a-9824-2529bb869b6e@gmail.com> (raw)
In-Reply-To: <DU0P250MB074708D4721FC142E7E495AF8F482@DU0P250MB0747.EURP250.PROD.OUTLOOK.COM>
On 2/12/2024 1:40 PM, Andreas Rheinhardt wrote:
> James Almer:
>> On 2/6/2024 10:05 AM, James Almer wrote:
>>> Signed-off-by: James Almer <jamrial@gmail.com>
>>> ---
>>> Now reading decriptors from extradata, plus a setting to ensure any
>>> descriptors
>>> present inband are omitted has been added.
>>>
>>> doc/bitstream_filters.texi | 16 +
>>> libavcodec/bitstream_filters.c | 1 +
>>> libavcodec/bsf/Makefile | 1 +
>>> libavcodec/bsf/iamf_frame_split_bsf.c | 887 ++++++++++++++++++++++++++
>>> 4 files changed, 905 insertions(+)
>>> create mode 100644 libavcodec/bsf/iamf_frame_split_bsf.c
>>
>> Will apply the set soon if there are no objections.
>
> I still object to the BSF in #1 existing as it just duplicates parsing
> code into lavc and lavf. And the issue with creating new framings for
> stuff for which no framing except raw data can't exist is still there.
I insist on using the split bsf, but i can try to remove the merge one
and do that within lavf, to avoid creating packets with OBU framing.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-12 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 13:05 James Almer
2024-02-06 13:05 ` [FFmpeg-devel] [PATCH 2/7 v4] avformat/demux: support inserting bitstream filters in demuxing scenarios James Almer
2024-02-06 13:05 ` [FFmpeg-devel] [PATCH 3/7 v4] avformat/mov: make MOVStreamContext refcounted James Almer
2024-02-06 13:05 ` [FFmpeg-devel] [PATCH 4/7 v4] avformat/mov: add support for Immersive Audio Model and Formats in ISOBMFF James Almer
2024-02-06 13:05 ` [FFmpeg-devel] [PATCH 5/7 v3] avcodec: add an Immersive Audio Model and Formats frame merge bsf James Almer
2024-02-06 13:05 ` [FFmpeg-devel] [PATCH 6/7 v3] avformat/movenc: add support for Immersive Audio Model and Formats in ISOBMFF James Almer
2024-02-06 13:05 ` [FFmpeg-devel] [PATCH] fate: add IAMF in mp4 tests James Almer
2024-02-12 13:40 ` [FFmpeg-devel] [PATCH 1/7 v4] avcodec: add an Immersive Audio Model and Formats frame split bsf James Almer
2024-02-12 16:40 ` Andreas Rheinhardt
2024-02-12 16:51 ` James Almer [this message]
2024-02-12 17:04 ` Andreas Rheinhardt
2024-02-12 17:11 ` James Almer
2024-02-12 17:28 ` Andreas Rheinhardt
2024-02-12 18:13 ` James Almer
2024-02-12 18:24 ` Andreas Rheinhardt
2024-02-12 19:55 ` James Almer
2024-02-12 20:08 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0a44a45-4819-4f6a-9824-2529bb869b6e@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git