[FFmpeg-devel] [PATCH] avformat: Fix AV1 RTP wrong log condition

[FFmpeg-devel] [PATCH] avformat: Fix AV1 RTP wrong log condition

[Chris Hodges]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Fixed warning about OBU count being wrong, which can only be
determined when the number of OBUs in the header is non-zero,
not the other way round.

Signed-off-by: Chris Hodges <chris.hodges@axis.com>
---
  libavformat/rtpdec_av1.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/rtpdec_av1.c b/libavformat/rtpdec_av1.c
index af3f9e0f09..7cfc83b03c 100644
--- a/libavformat/rtpdec_av1.c
+++ b/libavformat/rtpdec_av1.c
@@ -373,7 +373,7 @@ static int av1_handle_packet(AVFormatContext *ctx, PayloadContext *data,
          }
          is_frag_cont = 0;

-        if (!rem_pkt_size && !num_obus && (num_obus != obu_cnt)) {
+        if (!rem_pkt_size && num_obus && (num_obus != obu_cnt)) {
              av_log(ctx, AV_LOG_WARNING, "AV1 aggregation header indicated %u OBU elements, was %u\n",
                     num_obus, obu_cnt);
          }
-- 
2.39.5

[-- Attachment #2: 0001-avformat-Fix-AV1-RTP-wrong-log-condition.eml --]
[-- Type: message/rfc822, Size: 1102 bytes --]

From: Chris Hodges <chrishod@axis.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [PATCH] avformat: Fix AV1 RTP wrong log condition
Date: Tue, 1 Apr 2025 10:29:33 +0200

Fixed warning about OBU count being wrong, which can only be
determined when the number of OBUs in the header is non-zero,
not the other way round.

Signed-off-by: Chris Hodges <chris.hodges@axis.com>
---
 libavformat/rtpdec_av1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/rtpdec_av1.c b/libavformat/rtpdec_av1.c
index af3f9e0f09..7cfc83b03c 100644
--- a/libavformat/rtpdec_av1.c
+++ b/libavformat/rtpdec_av1.c
@@ -373,7 +373,7 @@ static int av1_handle_packet(AVFormatContext *ctx, PayloadContext *data,
         }
         is_frag_cont = 0;
 
-        if (!rem_pkt_size && !num_obus && (num_obus != obu_cnt)) {
+        if (!rem_pkt_size && num_obus && (num_obus != obu_cnt)) {
             av_log(ctx, AV_LOG_WARNING, "AV1 aggregation header indicated %u OBU elements, was %u\n",
                    num_obus, obu_cnt);
         }
-- 
2.39.5


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat: Fix AV1 RTP wrong log condition

[Marvin Scholz]

On 1 Apr 2025, at 11:26, Chris Hodges wrote:

> Fixed warning about OBU count being wrong, which can only be
> determined when the number of OBUs in the header is non-zero,
> not the other way round.
>
> Signed-off-by: Chris Hodges <chris.hodges@axis.com>
> ---
>  libavformat/rtpdec_av1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/rtpdec_av1.c b/libavformat/rtpdec_av1.c
> index af3f9e0f09..7cfc83b03c 100644
> --- a/libavformat/rtpdec_av1.c
> +++ b/libavformat/rtpdec_av1.c
> @@ -373,7 +373,7 @@ static int av1_handle_packet(AVFormatContext *ctx, PayloadContext *data,
>          }
>          is_frag_cont = 0;
>
> -        if (!rem_pkt_size && !num_obus && (num_obus != obu_cnt)) {
> +        if (!rem_pkt_size && num_obus && (num_obus != obu_cnt)) {
>              av_log(ctx, AV_LOG_WARNING, "AV1 aggregation header indicated %u OBU elements, was %u\n",
>                     num_obus, obu_cnt);
>          }
> -- 
> 2.39.5

Thanks, LGTM, will apply.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".