Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Chris Hodges <Chris.Hodges@axis.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] avformat: Fix AV1 RTP wrong log condition
Date: Tue, 1 Apr 2025 11:26:47 +0200
Message-ID: <e07c659e-6e35-422a-b345-6d17528169ee@axis.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Fixed warning about OBU count being wrong, which can only be
determined when the number of OBUs in the header is non-zero,
not the other way round.

Signed-off-by: Chris Hodges <chris.hodges@axis.com>
---
  libavformat/rtpdec_av1.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/rtpdec_av1.c b/libavformat/rtpdec_av1.c
index af3f9e0f09..7cfc83b03c 100644
--- a/libavformat/rtpdec_av1.c
+++ b/libavformat/rtpdec_av1.c
@@ -373,7 +373,7 @@ static int av1_handle_packet(AVFormatContext *ctx, PayloadContext *data,
          }
          is_frag_cont = 0;

-        if (!rem_pkt_size && !num_obus && (num_obus != obu_cnt)) {
+        if (!rem_pkt_size && num_obus && (num_obus != obu_cnt)) {
              av_log(ctx, AV_LOG_WARNING, "AV1 aggregation header indicated %u OBU elements, was %u\n",
                     num_obus, obu_cnt);
          }
-- 
2.39.5

[-- Attachment #2: 0001-avformat-Fix-AV1-RTP-wrong-log-condition.eml --]
[-- Type: message/rfc822, Size: 1102 bytes --]

From: Chris Hodges <chrishod@axis.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [PATCH] avformat: Fix AV1 RTP wrong log condition
Date: Tue, 1 Apr 2025 10:29:33 +0200

Fixed warning about OBU count being wrong, which can only be
determined when the number of OBUs in the header is non-zero,
not the other way round.

Signed-off-by: Chris Hodges <chris.hodges@axis.com>
---
 libavformat/rtpdec_av1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/rtpdec_av1.c b/libavformat/rtpdec_av1.c
index af3f9e0f09..7cfc83b03c 100644
--- a/libavformat/rtpdec_av1.c
+++ b/libavformat/rtpdec_av1.c
@@ -373,7 +373,7 @@ static int av1_handle_packet(AVFormatContext *ctx, PayloadContext *data,
         }
         is_frag_cont = 0;
 
-        if (!rem_pkt_size && !num_obus && (num_obus != obu_cnt)) {
+        if (!rem_pkt_size && num_obus && (num_obus != obu_cnt)) {
             av_log(ctx, AV_LOG_WARNING, "AV1 aggregation header indicated %u OBU elements, was %u\n",
                    num_obus, obu_cnt);
         }
-- 
2.39.5


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2025-04-01  9:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  9:26 Chris Hodges [this message]
2025-04-03 14:37 ` Marvin Scholz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e07c659e-6e35-422a-b345-6d17528169ee@axis.com \
    --to=chris.hodges@axis.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git