From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 58E5A44AA0 for ; Tue, 1 Nov 2022 13:26:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1C7468BE98; Tue, 1 Nov 2022 15:26:29 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 21F1868BDA2 for ; Tue, 1 Nov 2022 15:26:23 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 2A1DQCro015998-2A1DQCrp015998; Tue, 1 Nov 2022 15:26:12 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 0DCE0A1445; Tue, 1 Nov 2022 15:26:11 +0200 (EET) Date: Tue, 1 Nov 2022 15:26:11 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Hubert Mazur In-Reply-To: <20221028113439.30279-1-hum@semihalf.com> Message-ID: References: <20221028113439.30279-1-hum@semihalf.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 0/3] sw_scale: Provide neon implementation for hscale X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, ffmpeg-devel@ffmpeg.org, mw@semihalf.com, spop@amazon.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 28 Oct 2022, Hubert Mazur wrote: > This patchset contains arm64 neon implementation of hscale functions. > Fixed minor style issues and declared C function wrappers as static. > This patchset do not contain the patch for checkasm tool, as the > previous one did. The reason behind it was failing tests on x86 arch > but not on aarch64 or loongarch. Probably the hscale functions on x86 > have some bugs. Currently the checkasm tool does not check > the validity of hscale functions on x86 at all. Implementation of hscale > for x86 should be fixed anyway. As it comes to aarch64 the tests were > passing. Attaching a link to fate result in patchwork. After fixing x86 > the patch for checkasm could be merged. It's too bad that we don't have that test mergeable at this point, but I guess we can't hold back the new aarch64 assembly due to that... The patches seem fine as noted before; I found some more cases of missing trailing newlines at the end of the file, and some other minor stray changes in the patches, which I fixed. I also amended the commit messages saying that some of the benchmarks are from the non-merged checkasm test. With that, I pushed these patches. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".