From: "Martin Storsjö" <martin@martin.st>
To: Hubert Mazur <hum@semihalf.com>
Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com,
ffmpeg-devel@ffmpeg.org, mw@semihalf.com, spop@amazon.com
Subject: Re: [FFmpeg-devel] [PATCH 0/3] sw_scale: Provide neon implementation for hscale
Date: Tue, 1 Nov 2022 15:26:11 +0200 (EET)
Message-ID: <dff6450-6723-3b29-17d5-e48836a9b4b6@martin.st> (raw)
In-Reply-To: <20221028113439.30279-1-hum@semihalf.com>
On Fri, 28 Oct 2022, Hubert Mazur wrote:
> This patchset contains arm64 neon implementation of hscale functions.
> Fixed minor style issues and declared C function wrappers as static.
> This patchset do not contain the patch for checkasm tool, as the
> previous one did. The reason behind it was failing tests on x86 arch
> but not on aarch64 or loongarch. Probably the hscale functions on x86
> have some bugs. Currently the checkasm tool does not check
> the validity of hscale functions on x86 at all. Implementation of hscale
> for x86 should be fixed anyway. As it comes to aarch64 the tests were
> passing. Attaching a link to fate result in patchwork. After fixing x86
> the patch for checkasm could be merged.
It's too bad that we don't have that test mergeable at this point, but I
guess we can't hold back the new aarch64 assembly due to that...
The patches seem fine as noted before; I found some more cases of missing
trailing newlines at the end of the file, and some other minor stray
changes in the patches, which I fixed. I also amended the commit messages
saying that some of the benchmarks are from the non-merged checkasm test.
With that, I pushed these patches.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-11-01 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 11:34 Hubert Mazur
2022-10-28 11:34 ` [FFmpeg-devel] [PATCH 1/3] sw_scale: Add specializations for hscale 8 to 19 Hubert Mazur
2022-10-28 11:34 ` [FFmpeg-devel] [PATCH 2/3] sw_scale: Add specializations for hscale 16 to 15 Hubert Mazur
2022-10-28 11:34 ` [FFmpeg-devel] [PATCH 3/3] sw_scale: Add specializations for hscale 16 to 19 Hubert Mazur
2022-11-01 13:26 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dff6450-6723-3b29-17d5-e48836a9b4b6@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=gjb@semihalf.com \
--cc=hum@semihalf.com \
--cc=jswinney@amazon.com \
--cc=mw@semihalf.com \
--cc=spop@amazon.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git