From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E37924BA99 for ; Mon, 12 Aug 2024 18:57:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B895468D9ED; Mon, 12 Aug 2024 21:57:08 +0300 (EEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2042.outbound.protection.outlook.com [40.107.96.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4285A68D789 for ; Mon, 12 Aug 2024 21:57:01 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SuVTEgGecY2OyLyCnk4kQF6yHeQcae5hFmPQiggM0FNbygu/snKyDeldhwcEn6EHZZFVJ/CleTg6HNnzXZtuiDjWXSWpX6Z+1MpWnTgH4QlKDy6jVdT7vkEbcVmHFpxVNYJe3lxIpZw0V8y2piZehDIGZTNzen9B1GMK7Le7Ysr5kOKfc/BH7RRc4zq8yvZAHnlf0Kjyz4c7l8cASdvZvdbNTpMU8uHLEIVboAR6j2oI3T5X28AhYSJrJmWbvsDZ8f3qnXABVQNexiMiY9LPswdAzGU713fyimlNZK4SH3r6dBXj0Mr/ywDG3Q4iidCIvFBO+5IrpKhrhM/70VSrXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6uGr2dYz6rB1lIvUBqGQho7wRq3HRH2v19uC5V5y3wY=; b=pXGerLCzgZfqUo5DKE1/HZ1HAjcwOlmSDRvxIOE6JERxnEEB2iXK10Wq9ZPW6cNWUkZZ+tq0CSMz5VmiHyrDL4/cvER0f3MD+eeW0R0IRdrP5xXzUJ0yKKDsZBXOjysnAgCCK2O+umuzdjxfl1KHMtpb3zuaqheETknVslBIr68NxIvd2JMIQ08bxsFF/kF42JMs6DHj/famrS434Fx/2gyqqTo6VmuMLbkNr1wdw00OODK+sfxy7itA7vu19rp5PF33JcuXP/+lH2XGPZE4TDKJ9uBlPJKCbnG6r7idn1BOhlbv3ZiAa6hcjPuYL/8m5LJrnrF5/V9agIi2QO35YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from PH7PR12MB7210.namprd12.prod.outlook.com (2603:10b6:510:205::17) by CY8PR12MB7492.namprd12.prod.outlook.com (2603:10b6:930:93::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 18:56:56 +0000 Received: from PH7PR12MB7210.namprd12.prod.outlook.com ([fe80::54c:74b2:5935:6041]) by PH7PR12MB7210.namprd12.prod.outlook.com ([fe80::54c:74b2:5935:6041%5]) with mapi id 15.20.7849.019; Mon, 12 Aug 2024 18:56:56 +0000 Message-ID: Date: Mon, 12 Aug 2024 14:56:54 -0400 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240730200235.1828384-1-David.Wu3@amd.com> <489567c4-4149-451c-a479-b9a7c604e65d@jkqxz.net> Content-Language: en-US In-Reply-To: <489567c4-4149-451c-a479-b9a7c604e65d@jkqxz.net> X-ClientProxiedBy: YT3PR01CA0045.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:82::13) To PH7PR12MB7210.namprd12.prod.outlook.com (2603:10b6:510:205::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB7210:EE_|CY8PR12MB7492:EE_ X-MS-Office365-Filtering-Correlation-Id: 3866ed5f-e3f5-43e4-d2cd-08dcbb008988 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|4022899009; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eFpFU1NLTE12WTZnSDdpblJLcDhVN1VSTElQWVJoc0pONExEalNDa3p2dXRp?= =?utf-8?B?SGJ4dG9QeW1vbXkxVEZBcEJSVkFSS0puWm4zMDBsVUllMUVUSERhZDBGanpF?= =?utf-8?B?R25iZUtIVk5NaDhsR3IwTzYwT05ZN2IyZTNDVyt4WkdST3puaHRvREYwbVhi?= =?utf-8?B?MnErdTJtdXE2cnBaM3lBYVFXZSs5a0ZRSndlNnlhQWRENWRNUlhWTHcrSmI5?= =?utf-8?B?SHFybkJZTzRid1lRaDVJM1dudlZQa29ZU2h0WVdtZjBJaVRVWjhjZ1VHYWx1?= =?utf-8?B?dFVXUTM3UUdKeC9mSHZ1QzZDNk9TWDBVU0NSQzlCdE0xUS9Na2h5OHhnTGRP?= =?utf-8?B?NkUwbC9CT2hwUTl5Q3pkWGNJOWJ0Vm9yV2IxMmZPQ2tCQmxsNUJRYklyM1Jk?= =?utf-8?B?RTlVUU0zMEh4NmtlZ2ZrTkpFdFN5TDZQMFVpdE1kR01TMjNTQ01jcUZIcmJT?= =?utf-8?B?YWdmVjV0eTNwd3hya0tmOUVVaW1MUy9helhsQkNnSnhrY3QzRmlvQmgzUlFG?= =?utf-8?B?WkUvYlBHYnRiQ0hYSGRaZHd2eHhacTg2L3BmZnNIdGp1RkdOVlB1UU1FSHk3?= =?utf-8?B?NWdIc3greUhUY0RZNEN1Wk10d0FQWWUxZWZuejVhVmhIbmR1T2dyOFp6TGs3?= =?utf-8?B?OTZzMU40UEd3ejFlQkc5ZFgvVDhRczZYN3Q4QlZFNWQ4R3NNM1l6MlhxdkhO?= =?utf-8?B?bHA3UHk3RXVYMUFDNElZUVp1aUxrM2lYY25YUGx1SWJhalBnQWpsNkQySDd5?= =?utf-8?B?TjBYQ3l0bG54RjV6MVRGR0RqOGQ1eGUweGhjWkNVSERYM051ekVaYk9WUTRz?= =?utf-8?B?bUFUR3MxR3ZhMnAwczREdnJJOFl3TVdKZmIvTU9UL3RZY2hHT01mY2t5cGYw?= =?utf-8?B?RkZzeTlHN2FRZ1J4Z04vOGpOa3RiOWthQU44djgwRVJPbjdCK3UwODg0VmUx?= =?utf-8?B?WDRmcUk5anhvMmNEandJeDltVFJ4WnR1Y3hocUdaZlhPOVRmbFhqQkxxU3lp?= =?utf-8?B?OVAyQ1B3YWFJVjJsNjRuckN6MWNBVC91cW5vN2RUVHIwa2xrOWtrdHFtUU1w?= =?utf-8?B?Wm5MS0tLMVpKQjg2SHJRNkIrK1pOV210N0tGTExza0xkL1FDMGJXL0V6Nk52?= =?utf-8?B?MmdZMk01N0FhdlRQbk5RRktjSHQrU01qSHEyWDE5V2lIR3QzcUpXdURpb1Nj?= =?utf-8?B?b3d4NU00eVJNMFcyd3NSL2c4bWZqV2kvOUZoTFRSaHNVQjdobm9CQS8vUjZ6?= =?utf-8?B?TGVCaTJRWGtObUIwc2RjY2swT1dzeGQxUW5IQ3E4THBDbWUxaURGNXY1UXoz?= =?utf-8?B?MzROSm16VWUraitiQ1NMVmVmMmpHSHVWc29VWnJXcFU1RkE4cXpiWUlndmZh?= =?utf-8?B?amZRZ0cvejBZR3pyZnNhSWxVWU1udlBqNDdIenVjUnIzT2tSRis1NlFuSVRx?= =?utf-8?B?VXpDUng3M21ZdWhBS2JNK3I4RFR5RGNaYzlUcmFhVUgwT054cDR6T0VCeDlv?= =?utf-8?B?OVVBa1J0ZTRJSFA5OWE4SUx3dGF0SVNJMHVEYm95bmY2cHJ2dFRMcmRPOUlG?= =?utf-8?B?Z2ZIWGRSNmhEemJkOFhJWEpiRWE2Y09UWUlwS09Db2NYOTVPQXJIRWlIUHYx?= =?utf-8?B?RlAwU2lnWFY4UGNqR1B0UE1DbDhGSnJ5K2tSeDdvSlRSay96dWNBcDV1M21W?= =?utf-8?B?N0d2Y3JtTm0yQXpUR3BINjZjSTg1b2pBa3JVa1JiMHpqRFNoK3ROMHZtcTM1?= =?utf-8?Q?bEoiSh3aijUMi+2LDA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB7210.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(4022899009); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VytORFRaNzExN2k0M25DUld6bU1uMWFjSGpKYndMNnJMdHhYSnZ5TmgxQXcx?= =?utf-8?B?ZTFEVlNKZFMzMkZrZFB5L3hzc1R0Q0U3MFFnYXM2dnJaSGs4TVN0QnptVVRr?= =?utf-8?B?WTh3MDdXVHVTVUNpQWtGVzRGaElZWFN6ZERqQ1V4QldvRU9GQXZLUGhYN2dq?= =?utf-8?B?N3dHUUl2RytyQm5uWU4wWnJKM1YwOHVpNGNzdk16VXY4YmlUVnBMdjJ0VkU2?= =?utf-8?B?WU10U1dBdVNoYm9rQjZWcktmYlFqYlpPZ2dJQ1JuZUtFQ3QrT00vVXk5NWxB?= =?utf-8?B?d0IxMDlkWVJEQVNIa0tSdDErckwzMU9XenZmZHdWS1BjTXRQdm8yY29oNU9L?= =?utf-8?B?Vm81YkJNRlJmdVk1aDZ0cHV4TjEySHVWdTUrS1UyVU93S0g1ZXZKQnZTOEZM?= =?utf-8?B?aWt3bitsTG5mQkJhT3hjTFpvWHhNOFV5RFRQTTdqeFJPcll5REE5RXhkNXFh?= =?utf-8?B?dGg2aEhvNHRmbzhoRStGR0c1ZHdMQUtQQ0d2MVB3UEsyYzhCdGZXbGoxWm9T?= =?utf-8?B?Z2kvaW5VRmVValUvdFo3aEI3cjltTzVBbXFZbklUdG42elFodUZBeDc3YjZ4?= =?utf-8?B?blo4MDJHOS9aOTBCa3NZZVRWWVdOc1ZxSHJDRUprRk4yMmErSVBCbWtFNDYy?= =?utf-8?B?L2NpK1ZjQzlEeHY4STJSSXcvWmtpZUs1aHhLQXR2WmRRWkJHVlV1NStvUFky?= =?utf-8?B?UDJheUlSaGwwUzkwVU5LOTFYVmxuMUg5Rm84L1V1OVg4emV6NlhNL3YveVBa?= =?utf-8?B?cUpwNyt1aFNXSk4xcFAvcnAwOWRHeGRCcFcvUTdoUDF5SC8wcUN4YU12WHVR?= =?utf-8?B?d1g3S1ptbnd3VWoxU3FzZitTeEJ3NExBcXZaRDRmQ2V4cmo1S01LSE5QbTZt?= =?utf-8?B?aUJMakdhNG1MUmNGSHBLS1VneldHVDU4TTV5MUk2UExuT1BMY0t2aHFRVDV1?= =?utf-8?B?aVY0Z3BLRnFudGhCTkJBK1g5aHEvQ1BmbCtnTzdqdzhtd0E1NWNEQldhY3hV?= =?utf-8?B?MnUvUUNtTmdIS0g1bGJOVU5XUjFSM1pGVnFSajI2cGs5emsxamRtalJkMzVh?= =?utf-8?B?aDBiYmtFeHo5azlId0FHYmVSWW5IVy8xbFdzRW1iYTNGbCt5VUI3REhadXVu?= =?utf-8?B?QVJCS2xkSERJQXo3RTljanoxSG8ycGN6Vk8vdXVCK0FBZUtYVUVVemY0c3Zi?= =?utf-8?B?VDlER01PRGxmSzRJU1J0a2JYUjgzVEhiZHlkenNiMC9wZjFjMzhlRjhPRzRC?= =?utf-8?B?cEdKdG5FdjJYZ0RpR1JyWFAybjN6dU5vK2tqd0hFb2hZRTV5OHVsS0VySVgw?= =?utf-8?B?Si92TlNHUUFzZmwyd2taZWY1S0VWdVRIb1pRYTcvZjhBbHNLSkg3MUpRNFNu?= =?utf-8?B?SXAxM1Z0eHcwOXdQOW5kNFBya1VDTXNRbGZFOC9ubkI2UllPRzkwamRGVG9v?= =?utf-8?B?K0dNNlI2WlNtd2ZkWExEV1ZlRHg4bjFyVnlyZXdUaU56ZFZZajJQR2VyMkFG?= =?utf-8?B?Wi9FYUFXVE5EbCtySGswOE5JUW1teXI4eVpzMGp3dmFGZEduSWY4aXY2VFA1?= =?utf-8?B?bTlsWkN0WC9YY203dlZBS2twZ3NpQ1JBaEFHMkhFS1FxQlFxZzB3NFFxWm9U?= =?utf-8?B?ZjNNUUZ5YlRrQnJsU2ZBSDFpSkt2UkhGbkZSSVdoVFZRakxrUUNKVXBwWjVu?= =?utf-8?B?cnM0YW1tdlJBTGZ6ZEVERHEyMUZsZ1QzN3BUZmdWZFRvQTVmZFFORzdCWWlk?= =?utf-8?B?OU9ESzhJdXJRL2RlYVJIYU5ldlJ0ekZWVnBKOGMwZEZWZUhSeE10ZEpnanZy?= =?utf-8?B?QjAxUGtGY1plcUV5R1FRL0pLYnpibVJTcXdXa2EvR2o4TmQ2cG56MmN0VjQ0?= =?utf-8?B?bUhWR1pacTRrdnNHMFQwcGVCSC9Zb1Y0VGxRL2JkK1Z2dFMzK3grbFd3TElv?= =?utf-8?B?TTBUY2w5cHRIUDdpY0VSTUNzWjBydklLNEQ3ZHFSSGR3U092a1RYeHlueHJn?= =?utf-8?B?NVNKdkdKT2JOZUdtczJMSUhBdmtSY0ZRTS9oSkJXeUxBbjJLVVNUUWVBcU5u?= =?utf-8?B?cWoxejBZWldCNzlUK09HZGIyRXFhcDFDd0p0TzFhYzU5c0QxUzgzN1RlbGhi?= =?utf-8?Q?xKnBnSn4pxEdtAAP8C+WVDvXB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3866ed5f-e3f5-43e4-d2cd-08dcbb008988 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB7210.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 18:56:56.3149 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MzElkUPc9be6ZObDO4uGkMukZYfOIEL7a/qmkpYaf+wDVvnNYzaVsZABvM1ZFdiuuDOsx/3lsv+BuV4W1t4N5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7492 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1_vaapi: Enable AV1Profile2 VAAPI support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: David Wu via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: David Wu Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: thanks you Mark! will follow up on libva changes first. David On 2024-08-11 14:42, Mark Thompson wrote: > On 11/08/2024 19:27, Mark Thompson wrote: >> On 30/07/2024 21:02, David (Ming Qiang) Wu via ffmpeg-devel wrote: >>> AV1Profile2 VAAPI is supported and tested on AMD VCN5. >>> >>> Signed-off-by: David (Ming Qiang) Wu >>> --- >>> libavcodec/av1dec.c | 3 +++ >>> libavcodec/vaapi_decode.c | 3 +++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c >>> index 1d5b9ef4f4..77f63661a0 100644 >>> --- a/libavcodec/av1dec.c >>> +++ b/libavcodec/av1dec.c >>> @@ -599,6 +599,9 @@ static int get_pixel_format(AVCodecContext *avctx) >>> case AV_PIX_FMT_YUV420P12: >>> #if CONFIG_AV1_VULKAN_HWACCEL >>> *fmtp++ = AV_PIX_FMT_VULKAN; >>> +#endif >>> +#if CONFIG_AV1_VAAPI_HWACCEL >>> + *fmtp++ = AV_PIX_FMT_VAAPI; >>> #endif >>> break; >>> case AV_PIX_FMT_YUV422P: >>> diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c >>> index a59194340f..a077e47326 100644 >>> --- a/libavcodec/vaapi_decode.c >>> +++ b/libavcodec/vaapi_decode.c >>> @@ -448,6 +448,9 @@ static const struct { >>> MAP(AV1, AV1_MAIN, AV1Profile0), >>> MAP(AV1, AV1_HIGH, AV1Profile1), >>> #endif >>> +#if VA_CHECK_VERSION(1, 23, 0) >>> + MAP(AV1, AV1_PROFESSIONAL, AV1Profile2), >>> +#endif >>> >>> #undef MAP >>> }; >> Based on this is supporting profile 2 only for 4:2:0 12-bit, and therefore can't advertise profile 2 generally for the decoder because that would imply support for all 4:2:2 and 4:4:4 cases as well. >> >> I think this wants something added to VAAPI in order to be able to advertise partial support for a profile? >> >> (It would be very confusing if we got "AV1Profile2" in VAAPI meaning only 4:2:0 12-bit and then have to add a separate "AV1Profile2exceptreallythistime" to meant actual AV1 profile 2.) > I commented in . > > Please fix this before it get further in Mesa, having a version reporting incorrect decoder capabilities which we need to hack around elsewhere would be non-ideal. > > Thanks, > > - Mark > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".