From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F217045881 for ; Sun, 26 Mar 2023 19:32:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CECFE68C576; Sun, 26 Mar 2023 22:32:47 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7D18A68C431 for ; Sun, 26 Mar 2023 22:32:41 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id CAA59E8A19 for ; Sun, 26 Mar 2023 21:32:21 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h06Bo_xfB_Ut for ; Sun, 26 Mar 2023 21:32:17 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 8AE5BE83AB for ; Sun, 26 Mar 2023 21:32:17 +0200 (CEST) Date: Sun, 26 Mar 2023 21:32:17 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <9225cc71-7a42-f92f-9d8e-139b127eaff3@mediaarea.net> Message-ID: References: <0af7e930-9ec7-dc81-95bc-939eb21e2da0@mediaarea.net> <9a0cde9e-10d4-cf81-4a13-18a3f4959b02@mediaarea.net> <1a453d76-e0ab-81b9-d68c-ae3e23bb9ef9@passwd.hu> <9225cc71-7a42-f92f-9d8e-139b127eaff3@mediaarea.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 14 Mar 2023, Jerome Martinez wrote: > On 10/03/2023 22:10, Marton Balint wrote: >> >> >> On Mon, 6 Mar 2023, Nicolas Gaullier wrote: >> >> [...] >>> >>> Some weeks later now and no replies, maybe time to go on ? >>> I think the "case AV_CODEC_ID_DVVIDEO:" can be removed as discussed, fate >>> updated and that should be ok for everybody. >>> (Ideally, it could have been an opportunity to document why we have this >>> "DV exception", but I understand it is not very comfortable to write as >>> there is no meaningful reason, so forget about this, this won't hold up >>> the patch anyway) >>> For information, there was a long thread recently on ffmpeg-user about a >>> "bug" in dnxhd stored_height (will be fixed with your patch): >>> https://ffmpeg.org/pipermail/ffmpeg-user/2023-February/056111.html >> >> Will apply the patch in a couple of days unless somebody objects. If you >> want to change DV height (seems reasonable), please send a follow up patch >> with fate updates after that. > > > Apologizes for the huge delay. > Attached is an updated patch. > > I changed the DV part (also removed from the 16x16 macroblock thing) > I added some comments about specs (summary: DNxHD is explicit, others are not > but implementation I know don't do the 16x16 macroblock thing). > The FATE tests for DV are not impacted because they are SD and SD > width/height are multiple of 16 so I added a DV100 test. Thanks, will apply with some extended commit description. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".