From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1103944C51 for ; Wed, 14 Jun 2023 01:00:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9442E68C411; Wed, 14 Jun 2023 04:00:15 +0300 (EEST) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 075D368C2E3 for ; Wed, 14 Jun 2023 04:00:10 +0300 (EEST) Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6b2bdca0884so4308700a34.2 for ; Tue, 13 Jun 2023 18:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686704408; x=1689296408; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=JZBJrCnQvvA8QaMc+Bu0ROVmy0SUbfQQjiM0ATkphYU=; b=ajSwxKyitillUsb/3VG1H5CK0KFe9lNO8dypJuHka4Cxc10SoPjMOdK7SyJaNBlxoC BUJPqal+yVWM95S72tQWlNUvsOOQZHvtNWOcJVgQBsVxVuhZPQQirxq5SRGyRuA8ONa0 yN/w9YIumhpqASRSqHOTgSYcnVEd9V/B46i4GlF7Ks+ya2Kv7BK0gRF7pbn7RPwFdYpa QNVEwc+Eo/HnSy+sU7V3UxsfILFm/XeBkgIDSWRamqumGoCq5iuiYF4GDwrWVCQ/gqmx weaiHZBybredUcuMby4ropcXVe6DFyUFSYEdlQ554hze6BJnH+wEhHI0VOLrgUJgzkVF yOUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686704408; x=1689296408; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JZBJrCnQvvA8QaMc+Bu0ROVmy0SUbfQQjiM0ATkphYU=; b=SoNa1tFCA9bWeZYx/mACF/PHCQYHwqeqmv4c4dWFa9f4tXrcjKudkyhhjHVWV+YcSI k5FOsrGIXX712hcjLnYACrinRFVwgTPQZqh0wEnpZIkNaU7FzQ5sGqh9SC0xaMb7cxuG 6a5aTRW/08mYTdaQjRsP00UVZJ6ytfjwZXdCiVXBwJLQycQHnlWljXDgkPX0B37NFMnx Ncg92aFhGPBEU9pCmCVSKd05S/ch7A08U5aA9qqPr1/3iL7+AuQsCrSZwToWI2VFhvjz x/Ubndwxn9U13q0lkdOr/N4kO9b+3ya48/M1T2/ltMqLOCnC+g7ohAIlAZly8RfhoidI feOA== X-Gm-Message-State: AC+VfDzs1cJxpT3kPG/KmyhHOAYz8aEEj81HWDO6L0F0etesyPeVBolB 8ByWpiTVKL9l+JpVczn3N6wwW/CnxKs= X-Google-Smtp-Source: ACHHUZ4xAlr+BP6nq3ROEeEnAFMabOt4qsmZCulyqqOVwFXzD8W2Av2mK1Qt7/4CyvIcOPOM5tlDVg== X-Received: by 2002:a05:6830:145:b0:6b2:94a2:2236 with SMTP id j5-20020a056830014500b006b294a22236mr9970696otp.29.1686704407830; Tue, 13 Jun 2023 18:00:07 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id h15-20020a056830164f00b006b4281cf424sm112586otr.4.2023.06.13.18.00.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 18:00:06 -0700 (PDT) Message-ID: Date: Tue, 13 Jun 2023 22:00:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 To: ffmpeg-devel@ffmpeg.org References: <20230612123027.1865-1-d.kozinski@samsung.com> <20230614002326.GK1391451@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20230614002326.GK1391451@pb2> Subject: Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/13/2023 9:23 PM, Michael Niedermayer wrote: > On Mon, Jun 12, 2023 at 02:30:27PM +0200, Dawid Kozinski wrote: >> - Changes in mov_write_video_tag function to handle EVC elementary stream >> - Provided structure EVCDecoderConfigurationRecord that specifies the decoder configuration information for ISO/IEC 23094-1 video content >> >> Signed-off-by: Dawid Kozinski >> --- >> libavformat/Makefile | 2 +- >> libavformat/evc.c | 422 ++++++++++++++++++++++++++++++++++++++++ >> libavformat/evc.h | 44 +++++ >> libavformat/isom_tags.c | 2 + >> libavformat/movenc.c | 33 ++++ >> 5 files changed, 502 insertions(+), 1 deletion(-) >> create mode 100644 libavformat/evc.c >> create mode 100644 libavformat/evc.h >> >> diff --git a/libavformat/Makefile b/libavformat/Makefile >> index 6e4231fda2..d3503196e3 100644 >> --- a/libavformat/Makefile >> +++ b/libavformat/Makefile >> @@ -364,7 +364,7 @@ OBJS-$(CONFIG_MOV_DEMUXER) += mov.o mov_chan.o mov_esds.o \ >> OBJS-$(CONFIG_MOV_MUXER) += movenc.o av1.o avc.o hevc.o vpcc.o \ >> movenchint.o mov_chan.o rtp.o \ >> movenccenc.o movenc_ttml.o rawutils.o \ >> - dovi_isom.o >> + dovi_isom.o evc.o >> OBJS-$(CONFIG_MP2_MUXER) += rawenc.o >> OBJS-$(CONFIG_MP3_DEMUXER) += mp3dec.o replaygain.o >> OBJS-$(CONFIG_MP3_MUXER) += mp3enc.o rawenc.o id3v2enc.o >> diff --git a/libavformat/evc.c b/libavformat/evc.c >> new file mode 100644 >> index 0000000000..431cb107e3 >> --- /dev/null >> +++ b/libavformat/evc.c >> @@ -0,0 +1,422 @@ >> +/* >> + * EVC helper functions for muxers >> + * Copyright (c) 2022 Dawid Kozinski >> + * >> + * This file is part of FFmpeg. >> + * >> + * FFmpeg is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU Lesser General Public >> + * License as published by the Free Software Foundation; either >> + * version 2.1 of the License, or (at your option) any later version. >> + * >> + * FFmpeg is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + * Lesser General Public License for more details. >> + * >> + * You should have received a copy of the GNU Lesser General Public >> + * License along with FFmpeg; if not, write to the Free Software >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA >> + */ > > [...] > >> + nalu_type = ff_evc_get_nalu_type(data, bytes_to_read, pb); > > functions shared between libavcodec and libavformat need an av*/avpriv* prefix > otherwise linking will fail with shared libs as ff* isnt exported It's small enough that it can go in the header instead. That way we save one unnecessary exported symbol. Same with ff_evc_read_nal_unit_length(). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".