From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C2AFB48160 for ; Mon, 11 Dec 2023 11:54:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C961168D198; Mon, 11 Dec 2023 13:54:41 +0200 (EET) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D95B68D167 for ; Mon, 11 Dec 2023 13:54:35 +0200 (EET) Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-67ab85eee2fso7215776d6.1 for ; Mon, 11 Dec 2023 03:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702295673; x=1702900473; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y9iV5sYOKRkNUgXKM8kkkP9NTGzyHtKmezlNO+jAWpg=; b=Yhy5isIzkUq8VCcMiR9VaVBOniy6DlnvDh+hK1OBSIw2oh1z74TQCuSfYG80kxB2vU kcWz7kaFaI5k6CEgA509G1JJId3ERyhqYavqbhJ5wzy2rJr4yTFf0r5b00SHt8YxfUh9 5EKRvxu4l1m4tiKAsUcAP2Il0/a/SG7rnJAG7EXCButH0V5GpQrfLtiovG05St9t3ehw RC+hqY+14frB/h2vo5AXQo/7flUFKCJoheALjHeCjDcoc+214QrAvH5ohFnj/U3j/5L+ B5xvoOdzY9ii81lbUD0W9Nw2xX/1mGkukpgVWcq77JhbOECtueSlt2cT0UVZVh9Q8Fua XIDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702295673; x=1702900473; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y9iV5sYOKRkNUgXKM8kkkP9NTGzyHtKmezlNO+jAWpg=; b=gtuq1sPLii/GTtIyazJzygbZskQMi9TVfTkZBucy6W0rgsVIpI73PE64qD20aJwI8D rlHcgGHrNQ+TGent2kd9IJ6nELtrcy2qJ+Avl7UQLi/ovD9cGv8hpG45wp47UjG/kpiJ Cnx7Y03MVHzPlYrmdZrgyryqL5iLYGKsOZKAMAd2ht9YhucI9tjmbgBdw5eutBkg7Htd 3Ft8GGS0ts/uPOmfI4PGai/t/PrMlw+lfy28ucqe6xxaMZ5KGouRMfbw8WaLoAW8LE/+ x1395WIhb4XkVI0IY+pa7DbNs/kDJlAnL699g09rq4JRXgwVzC88FSBa/nv9pB81Ui+2 SE4w== X-Gm-Message-State: AOJu0YxZxYcGYsyteXKyMSKFJukKh3shGP/uty9HXK6RNDQUaKMx/s9C +YTJRSFUcSdlVto7fwsVGlBuSla3zoY= X-Google-Smtp-Source: AGHT+IHgKCy9mfV1BdETPM/sTDXH886hXeieLmdM+qUIR+ujfsDtdls4qmgmZpuJqDOjMe4uBw7nog== X-Received: by 2002:a0c:e8cd:0:b0:67a:94bd:f7ee with SMTP id m13-20020a0ce8cd000000b0067a94bdf7eemr7097646qvo.2.1702295673677; Mon, 11 Dec 2023 03:54:33 -0800 (PST) Received: from [192.168.1.35] (c-68-56-149-176.hsd1.mi.comcast.net. [68.56.149.176]) by smtp.gmail.com with ESMTPSA id nd21-20020a056214421500b0067a2a0b44ddsm3224477qvb.44.2023.12.11.03.54.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 03:54:33 -0800 (PST) Message-ID: Date: Mon, 11 Dec 2023 06:54:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US-large To: ffmpeg-devel@ffmpeg.org References: <20230221223555.102670-1-leo.izen@gmail.com> <14122ab6-072a-6a53-0938-7f9e07270495@gmail.com> From: Leo Izen In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/10/23 23:20, Kacper Michajlow wrote: > On Tue, 28 Feb 2023 at 20:46, Leo Izen wrote: >> >> On 2/27/23 11:34, Leo Izen wrote: >>> On 2/21/23 17:35, Leo Izen wrote: >>>> These chunks are lightweight and it's useful information to have when >>>> running ffmpeg -i or ffprobe, for example. >>>> --- >>>> libavcodec/pngdec.c | 136 ++++++++++++++++++++++------------- >>>> tests/ref/fate/png-icc | 8 +-- >>>> tests/ref/fate/png-side-data | 2 +- >>>> 3 files changed, 91 insertions(+), 55 deletions(-) >>>> >>>> diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c >>> >>> I will push this soon-ish if there's no other objections. >>> >>> - Leo Izen (thebombzen) >>> >>> >> >> Pushed as fadfa147f812a3fe9e68723347d37b9cccd6222d. > > Hi, Sorry for digging this old patch, but I'm curious. > > What does "unsupported tv-range cICP chunk\n" and "we only support > pc-range RGB" mean? > > Before this patch the range was properly set: > avctx->color_range = f->color_range = > s->cicp_range == 0 ? AVCOL_RANGE_MPEG : AVCOL_RANGE_JPEG; > > Now it is ignored with a warning. Neither commit message, nor the > comments in the code explain why the cICP range is now ignored in the > decoder and the frames are no longer tagged with proper color range. > It means FFmpeg itself doesn't support tv-range RGB. The PNG format supports it but FFmpeg does not. Since the PNG spec specifies the matrix must equal zero (aka RGB), we can't support tv-range here and print a warning. - Leo Izen (Traneptora) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".