From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] windows: Remove the VS_FFI_FILEFLAGSMASK setting
Date: Wed, 5 Jan 2022 09:31:45 -0300
Message-ID: <dea2dc50-7776-0c72-7da0-02aa97ce184d@gmail.com> (raw)
In-Reply-To: <CA+anqdxkQu5CJ1Q_K2_JWAaqZ7ZswUot1TYawWMxz+BcfdULHw@mail.gmail.com>
On 1/5/2022 9:29 AM, Hendrik Leppkes wrote:
> On Wed, Jan 5, 2022 at 1:21 PM Martin Storsjö <martin@martin.st> wrote:
>>
>> According to the documentation, the VS_FFI_FILEFLAGSMASK mask
>> consists of all the following flags set:
>> VS_FF_DEBUG, VS_FF_PATCHED, VS_FF_PRERELEASE, VS_FF_PRIVATEBUILD,
>> VS_FF_SPECIALBUILD.
>>
>> The documentation of these fields say e.g. this:
>> VS_FF_PATCHED File has been modified and is not identical to the
>> original shipping file of the same version number.
>> VS_FF_PRIVATEBUILD File was not built using standard release procedures.
>> If this value is given, the StringFileInfo block must
>> contain a PrivateBuild string.
>>
>> It doesn't seem like it's intentional to set all of these flags
>> (and setting all of them at once doesn't seem like something one
>> ever would want to do anyway).
>>
>
> FILEFLAGSMASK sets the flags that are valid, not the flags that are
> actually set - FILEFLAGS would do that.
> So what we are actually doing is telling it all flags are valid, and
> none are set (since FILEFLAGS is not set at all).
fwiw, flagging VS_FF_DEBUG sounds like it would be nice if debug symbols
are compiled in (the default behavior), but configure doesn't seem to
signal it in config.mak outside of defining certain cflags and such, so
as is it's not possible.
>
> As far as I can tell, not specifying FILEFLAGSMASK is identical to
> specifying it with VS_FFI_FILEFLAGSMASK, so either applying or not
> should yield identical information in the binaries.
>
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-01-05 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 12:21 Martin Storsjö
2022-01-05 12:29 ` Hendrik Leppkes
2022-01-05 12:31 ` James Almer [this message]
2022-01-05 12:36 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dea2dc50-7776-0c72-7da0-02aa97ce184d@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git