From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B678D45831 for ; Thu, 23 Feb 2023 13:14:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0ABF968C0E5; Thu, 23 Feb 2023 15:14:28 +0200 (EET) Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD30A68C0A8 for ; Thu, 23 Feb 2023 15:14:21 +0200 (EET) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-1720433ba75so15501633fac.5 for ; Thu, 23 Feb 2023 05:14:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=c/7twuyvZsapSiQJUSw2UujC+1CzuVY/1J3y5qap1QA=; b=QvbaaxreMyFEK8iOjTcd8/oBT4aUgl6qNNwbS+TiqC8fcB7gmzbJCGlScGBXfn120+ wmjyjsUTCNC8doRbLAoa15KgV7E5V7mDsN21d/1xaQy3mpwBsBQvDeba31/M/aghiLSJ hI/XBjiXHSqCAvMyRkWZmXMw3dmlw9lYMvjhks49TGVELKpysb/lwxy5UKi6OlVieVe4 nS+2Z674KYN6CRwpXg8C/Nn8gdVDltcDti2YvIMNyj2lMUsrP6WSSP84LjxZ5nwBygFI OJdsq871FYll9/VrDyccDswhuhgCOghPuaUXNKIQTceHiyTiCf2x8cNgy2Wkhm5mbEhh Lrvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c/7twuyvZsapSiQJUSw2UujC+1CzuVY/1J3y5qap1QA=; b=4SAdNlNTNrRloRWibdN6Qn1TWfNyz+s9QC8Dj6yOy0fJToT2LHjPRG0Bl+sGScvAcf 1hXDNzl4mkEoqs46fsfiFKiMlhzJI6M48hkvF2nAYFFfex+yNZbmCxPQfQW903wq7lLk C8nDeSliNTl5UYdzWxLxS74XpSOpMSYF23WTQ/Q2ksqAkR7ROJMvgsV2jIyBk1JE68Qh s+O68q0+AvNOXDS4iVuEmxr9IDmRyu8Im+UCF46pg2W8a6FhjavgNgqb8ji2w83Q1aVj FsXotqq/vfmpjlwEr7ddTtD71c7ekORg6FLvlpkwLXWW8FlJMi1PCty7CgNDrtPnTPzy 4EIw== X-Gm-Message-State: AO0yUKXU9dStOId7ebeBY7F7PitNOEdU6yfdlJR/oAOWa8541DIqjzzo yqkpSpSiCFCnuhqAGmj6fcarqxXxsJw= X-Google-Smtp-Source: AK7set/CzR0pk+yhB2tDcosJU4j7KMMieFCbjjAjnmkXfwQ+CRjrBy6wuH0GEDxaZycsRgwpK+IHFw== X-Received: by 2002:a05:6870:438e:b0:172:473c:5a1b with SMTP id r14-20020a056870438e00b00172473c5a1bmr3917393oah.15.1677158059895; Thu, 23 Feb 2023 05:14:19 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id ee8-20020a056870c80800b0010d7242b623sm7117731oab.21.2023.02.23.05.14.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 05:14:19 -0800 (PST) Message-ID: Date: Thu, 23 Feb 2023 10:14:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: ffmpeg-devel@ffmpeg.org References: <20230124224623.1374077-1-sw@jkqxz.net> Content-Language: en-US From: James Almer In-Reply-To: <20230124224623.1374077-1-sw@jkqxz.net> Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] cbs_av1: Add tracing headers for metadata types X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/24/2023 7:46 PM, Mark Thompson wrote: > Make it a little easier to interpret metadata in trace output. > --- > libavcodec/cbs_av1_syntax_template.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c > index e95925a493..817a0f8ae6 100644 > --- a/libavcodec/cbs_av1_syntax_template.c > +++ b/libavcodec/cbs_av1_syntax_template.c > @@ -1843,6 +1843,8 @@ static int FUNC(metadata_hdr_cll)(CodedBitstreamContext *ctx, RWContext *rw, > { > int err; > > + HEADER("HDR CLL Metadata"); > + > fb(16, max_cll); > fb(16, max_fall); > > @@ -1854,6 +1856,8 @@ static int FUNC(metadata_hdr_mdcv)(CodedBitstreamContext *ctx, RWContext *rw, > { > int err, i; > > + HEADER("HDR MDCV Metadata"); > + > for (i = 0; i < 3; i++) { > fbs(16, primary_chromaticity_x[i], 1, i); > fbs(16, primary_chromaticity_y[i], 1, i); > @@ -1920,6 +1924,8 @@ static int FUNC(metadata_scalability)(CodedBitstreamContext *ctx, RWContext *rw, > { > int err; > > + HEADER("Scalability Metadata"); > + > fb(8, scalability_mode_idc); > > if (current->scalability_mode_idc == AV1_SCALABILITY_SS) > @@ -1934,6 +1940,8 @@ static int FUNC(metadata_itut_t35)(CodedBitstreamContext *ctx, RWContext *rw, > int err; > size_t i; > > + HEADER("ITU-T T.35 Metadata"); > + > fb(8, itu_t_t35_country_code); > if (current->itu_t_t35_country_code == 0xff) > fb(8, itu_t_t35_country_code_extension_byte); > @@ -1961,6 +1969,8 @@ static int FUNC(metadata_timecode)(CodedBitstreamContext *ctx, RWContext *rw, > { > int err; > > + HEADER("Timecode Metadata"); > + > fb(5, counting_type); > flag(full_timestamp_flag); > flag(discontinuity_flag); Set LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".